Lea/web-apps
1
0
Fork 0
Code Issues Pull requests Packages Projects Releases Wiki Activity

[DE] Refactoring bookmarks

Browse source
This commit is contained in:
Julia Radzhabova 2018-03-28 17:44:38 +03:00
parent 685c3073f1
commit 9f77f3d792
1 changed files with 16 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

24
apps/documenteditor/main/app/view/BookmarksDialog.js
View file

@ -157,17 +157,20 @@ define([
this.bookmarksList.on('item:select', _.bind(this.onSelectBookmark, this)); this.bookmarksList.on('item:select', _.bind(this.onSelectBookmark, this));
this.btnAdd = new Common.UI.Button({ this.btnAdd = new Common.UI.Button({
el: $('#bookmarks-btn-add') el: $('#bookmarks-btn-add'),
disabled: true
}); });
this.$window.find('#bookmarks-btn-add').on('click', _.bind(this.onDlgBtnClick, this)); this.$window.find('#bookmarks-btn-add').on('click', _.bind(this.onDlgBtnClick, this));
this.btnGoto = new Common.UI.Button({ this.btnGoto = new Common.UI.Button({
el: $('#bookmarks-btn-goto') el: $('#bookmarks-btn-goto'),
disabled: true
}); });
this.btnGoto.on('click', _.bind(this.gotoBookmark, this)); this.btnGoto.on('click', _.bind(this.gotoBookmark, this));
this.btnDelete = new Common.UI.Button({ this.btnDelete = new Common.UI.Button({
el: $('#bookmarks-btn-delete') el: $('#bookmarks-btn-delete'),
disabled: true
}); });
this.btnDelete.on('click', _.bind(this.deleteBookmark, this)); this.btnDelete.on('click', _.bind(this.deleteBookmark, this));
@ -215,17 +218,19 @@ define([
if (this.props) { if (this.props) {
var store = this.bookmarksList.store, var store = this.bookmarksList.store,
count = this.props.asc_GetCount(), count = this.props.asc_GetCount(),
showHidden = this.chHidden.getValue()=='checked',
arr = []; arr = [];
for (var i=0; i<count; i++) { for (var i=0; i<count; i++) {
// if (this.chHidden.getValue()=='checked' || !this.props.asc_GetHidden(i)) { var name = this.props.asc_GetName(i);
if (!this.props.asc_IsInternalUseBookmark(name) && (showHidden || !this.props.asc_IsHiddenBookmark(name))) {
var rec = new Common.UI.DataViewModel(); var rec = new Common.UI.DataViewModel();
rec.set({ rec.set({
value: this.props.asc_GetName(i), value: name,
location: i location: i
}); });
arr.push(rec); arr.push(rec);
} }
// } }
store.reset(arr, {silent: false}); store.reset(arr, {silent: false});
} }
}, },
@ -233,6 +238,7 @@ define([
onSelectBookmark: function(listView, itemView, record) { onSelectBookmark: function(listView, itemView, record) {
var value = record.get('value'); var value = record.get('value');
this.txtName.setValue(value); this.txtName.setValue(value);
this.btnAdd.setDisabled(false);
this.btnGoto.setDisabled(false); this.btnGoto.setDisabled(false);
this.btnDelete.setDisabled(false); this.btnDelete.setDisabled(false);
}, },
@ -270,9 +276,11 @@ define([
}, },
onNameChanging: function (input, value) { onNameChanging: function (input, value) {
var exist = this.props.asc_HaveBookmark(value);
this.bookmarksList.deselectAll(); this.bookmarksList.deselectAll();
// this.btnGoto.setDisabled(true); this.btnAdd.setDisabled(!this.props.asc_CheckNewBookmarkName(value) && !exist);
// this.btnDelete.setDisabled(true); this.btnGoto.setDisabled(!exist);
this.btnDelete.setDisabled(!exist);
}, },
textTitle: 'Bookmarks', textTitle: 'Bookmarks',