mirrors/legendary
1
0
Fork 0
mirror of https://github.com/derrod/legendary.git synced 2026-07-30 01:59:11 +00:00
Code Issues Projects Releases Wiki Activity

fix: avoid KeyError when game metadata is missing id/namespace (#769)

Browse source 
Signed-off-by: Sai Asish Y <say.apm35@gmail.com>
This commit is contained in:
Sai Asish Y 2026-07-28 05:07:14 -07:00 committed by GitHub
parent ea580df3ff
commit eb76c9f782
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 5 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
legendary/cli.py
View file

@ -242,7 +242,7 @@ class LegendaryCLI:
writer.writerow(['App name', 'App title', 'Version', 'Is DLC'])
for game in games:
writer.writerow((game.app_name, game.app_title, game.app_version(args.platform), False))
for dlc in dlc_list[game.catalog_item_id]:
for dlc in dlc_list.get(game.catalog_item_id, []):
writer.writerow((dlc.app_name, dlc.app_title, dlc.app_version(args.platform), True))
return
@ -250,7 +250,7 @@ class LegendaryCLI:
_out = []
for game in games:
_j = vars(game)
_j['dlcs'] = [vars(dlc) for dlc in dlc_list[game.catalog_item_id]]
_j['dlcs'] = [vars(dlc) for dlc in dlc_list.get(game.catalog_item_id, [])]
_out.append(_j)
return self._print_json(_out, args.pretty_json)
@ -281,7 +281,7 @@ class LegendaryCLI:
else:
print(f' ! This app requires linking to a third-party account (name: "{_type}", not supported)')
for dlc in dlc_list[game.catalog_item_id]:
for dlc in dlc_list.get(game.catalog_item_id, []):
print(f' + {dlc.app_title} (App name: {dlc.app_name} | Version: {dlc.app_version(args.platform)})')
if not dlc.app_version(args.platform):
print(f' ! This DLC is either included in the base game, or not available for {args.platform}')

4
legendary/models/game.py
View file

@ -170,13 +170,13 @@ class Game:
def catalog_item_id(self):
if not self.metadata:
return None
return self.metadata['id']
return self.metadata.get('id')
@property
def namespace(self):
if not self.metadata:
return None
return self.metadata['namespace']
return self.metadata.get('namespace')
@classmethod
def from_json(cls, json):