stuart.morgan
841f5f7390
Sender tweaks; strip whitespace from server-returned ID, and change the title of the dialog a bit.
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@326 4c0a9323-5329-0410-9bdc-e9ce6186880e
2009-04-07 16:31:27 +00:00
stuart.morgan
9290b7062f
Fix framework bundle ID and remove useless autogenerated InfoPlist.strings
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@325 4c0a9323-5329-0410-9bdc-e9ce6186880e
2009-04-06 20:17:09 +00:00
nealsid
77d851c356
Fix my build break due to misnamed constant
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@324 4c0a9323-5329-0410-9bdc-e9ce6186880e
2009-04-06 00:57:06 +00:00
nealsid
a3d4c97336
Incorporate feedback from first Breakpad integration.
...
This upload fixes five issues:
1) Preston's email was hardcoded in the xib :-(
2) Changed from xib to NIB to facilitate Tiger building
3) Changed the logs location to be user specifiable by BreakpadMinidumpLocation
key, or ~/Library/Breakpad/<BREAKPAD_PRODUCT> by default
4) Fixed GTM Defines problem in order to build on Tiger
5) Also set CFBundleIcon in the sender program correctly, and updated plist, and
renamed ReporterIcons to crash_report_sendER.ICNS. However the rietveld upload
script doesn't appear to pick up renamed files correctly, so that file doesn't
show up in the patch upload.
Also various comments were updated for accuracy.
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@323 4c0a9323-5329-0410-9bdc-e9ce6186880e
2009-04-06 00:25:29 +00:00
nealsid
3ebdb1bd7a
Open sourcing the Breakpad framework from Google.
...
A=many, many people
R=nealsid, jeremy moskovich(from Chromium project)
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@322 4c0a9323-5329-0410-9bdc-e9ce6186880e
2009-04-01 03:18:49 +00:00
ted.mielczarek
0abe34ce5d
issue 305 - breakpad Linux handler doesn't build with compiler built from latest GCC sources. Trivial patch by Jim Blandy
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@321 4c0a9323-5329-0410-9bdc-e9ce6186880e
2009-03-24 19:57:46 +00:00
nealsid
3366749ee7
Fix for issue 304: symupload needs to support timeout specifications(wininet can timeout when sending large symbol files).
...
R=doshimun
W=nealsid
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@319 4c0a9323-5329-0410-9bdc-e9ce6186880e
2009-03-20 19:02:12 +00:00
nealsid
2ad976ef0b
Fix for issues 296, 297. Various symbol supplier classes need to be updated with new overload('make check' was failing, as well as crash_report), and remove logging that was flooding output
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@318 4c0a9323-5329-0410-9bdc-e9ce6186880e
2009-02-27 23:59:40 +00:00
nealsid
02c244f1b2
Fix for issue 242, plus a redo of how old exception handlers are tracked, and called.
...
R=Craig.Schlenter, luly81
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@315 4c0a9323-5329-0410-9bdc-e9ce6186880e
2009-02-26 21:31:53 +00:00
nealsid
4af5fe0b59
Fix build breaks on Solaris using Sun Studio.
...
Written by Ginn Chen & Eagle.Lu@
R=nealsid (although I don't have a Solaris machine to build on, & these changes look localized to Sun-only builds)
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@314 4c0a9323-5329-0410-9bdc-e9ce6186880e
2009-02-23 09:28:29 +00:00
nealsid
e1a7efca7d
See https://bugzilla.mozilla.org/show_bug.cgi?id=397200
...
The method of calculating a binary ID using the LC_ID command isn't compatible with non-default build processes, most Mac consumers
use LC_UUID anyway but for those that don't, MD5 is a better choice
R=nealsid
W=Ted.Mielczarek
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@313 4c0a9323-5329-0410-9bdc-e9ce6186880e
2009-02-22 08:16:05 +00:00
nealsid
cadc8ddde9
Issue 294: mmap error checking is not correct.
...
R=Liu
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@312 4c0a9323-5329-0410-9bdc-e9ce6186880e
2009-02-22 01:31:43 +00:00
nealsid
0fd2f1ae21
Modify symbol supplier interface to support an overload that takes a symbol data buffer, to get around an extraneous read/write of symbol data
...
R=doshimun
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@311 4c0a9323-5329-0410-9bdc-e9ce6186880e
2009-02-19 21:26:20 +00:00
nealsid
a285652cba
Issue 275: patch to include list of loaded modules in crash_report output
...
Written by: jum@mac.com
R=nealsid
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@310 4c0a9323-5329-0410-9bdc-e9ce6186880e
2009-02-10 21:29:54 +00:00
doshimun
c9944d96e8
Reinstnate the call to TerminateThread inside ExceptionHandler destructor and put
...
the graceful code inside a #ifdef.
The problem is:
If ExceptionHandler is created and destroyed in DllMain, then the previous change to
remove the call to TerminateThread will lead to a deadlock. This is because inside
DllMain the loader lock is acquired, and the previous change waits for the handler
thread to exit in the destructor, that is with the loader lock acquired. But the
handler thread cannot finish until it gets the loader lock to call DllMain for
THREAD_DETACH.
With this change, we add conditional compilation so that clients that want to
avoid the call to terminate thread can do it by defining the appropriate preprocessor
variable.
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@309 4c0a9323-5329-0410-9bdc-e9ce6186880e
2009-01-20 20:45:28 +00:00
doshimun
104e4e0114
Fix an AppVerifier STOP in OOP server code. In the destructor of
...
the OOP server, we need to wait for any pending I/O to be done.
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@308 4c0a9323-5329-0410-9bdc-e9ce6186880e
2009-01-16 22:37:48 +00:00
doshimun
308947d1ce
Fix some typos in comments.
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@307 4c0a9323-5329-0410-9bdc-e9ce6186880e
2009-01-14 21:54:08 +00:00
doshimun
a6f58a1ac8
Minor fixes to windows exception handler.
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@306 4c0a9323-5329-0410-9bdc-e9ce6186880e
2009-01-14 20:51:51 +00:00
nealsid
8b6271ce2c
New test data to reflect Ted's changes that add function parameters to symbols when using DWARF
...
R=ted.mielczarek
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@305 4c0a9323-5329-0410-9bdc-e9ce6186880e
2008-12-19 22:28:45 +00:00
ted.mielczarek
3751b05354
Issue 283 - DWARF dumper doesn't handle DW_AT_specification. r=nealsid
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@303 4c0a9323-5329-0410-9bdc-e9ce6186880e
2008-12-08 13:12:45 +00:00
ted.mielczarek
d3441c2c96
Issue 284 - DWARF dumper doesn't output function names including arguments. r=nealsid
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@302 4c0a9323-5329-0410-9bdc-e9ce6186880e
2008-12-08 13:00:29 +00:00
ted.mielczarek
7837cb7236
issue 286 - clean up some demangling code in dump_syms.mm. r=chris rogers
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@301 4c0a9323-5329-0410-9bdc-e9ce6186880e
2008-12-03 18:23:09 +00:00
mmentovai
e5c401467b
ExceptionHandler class is not handling initialization errors, such as the
...
handler thread not being created. Protect the exception handler against
failure to create semaphores and a thread handle.
Patch by Marc-André (MAD) Decoste, r=me
http://code.google.com/p/google-breakpad/issues/detail?id=285
http://codereview.chromium.org/13065
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@300 4c0a9323-5329-0410-9bdc-e9ce6186880e
2008-12-03 17:21:34 +00:00
ted.mielczarek
af553e22cb
follow up for issue 281 - dump_syms fails to find dylib symbol file inside of a bundle. handle files without an extension properly
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@299 4c0a9323-5329-0410-9bdc-e9ce6186880e
2008-12-01 18:42:16 +00:00
ted.mielczarek
7b8eb04745
issue 281 - dump_syms fails to find dylib symbol file inside of a bundle. r=nealsid
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@298 4c0a9323-5329-0410-9bdc-e9ce6186880e
2008-12-01 17:05:43 +00:00
ted.mielczarek
5f27d9125c
Followup to address some review comments from Issue 259
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@297 4c0a9323-5329-0410-9bdc-e9ce6186880e
2008-11-25 13:41:41 +00:00
ted.mielczarek
324d84c2f6
Issue 259 - crash when generating large .sym files with dump_syms on Linux. Patch by login_ing@yahoo.com, r=Liu Li
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@296 4c0a9323-5329-0410-9bdc-e9ce6186880e
2008-11-24 20:47:37 +00:00
nealsid
e055207058
Added some sanity checks when iterating over threads in a crashed process. In same cases the ESP could be 0. In other cases it would be borked completely(i.e. pointing to an invalid range).
...
R=Jeremy Moskovich
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@295 4c0a9323-5329-0410-9bdc-e9ce6186880e
2008-11-19 19:07:34 +00:00
nealsid
c85fb043ed
Fix for dump_syms to ignore line number information for addresses that don't have an enclosing function
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@293 4c0a9323-5329-0410-9bdc-e9ce6186880e
2008-11-03 23:23:50 +00:00
nealsid
3a283d8f8b
Undo suspend/resume feature since it was meant as a workaround to a bug in how we handled child process exceptions. Currently we don't return to the kernel when we take an exception from a child process, causing a hang. Now we return KERN_FAILURE, indicating to the kernel to move on to the host-level exception handler(usually Crash Reporter)
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@292 4c0a9323-5329-0410-9bdc-e9ce6186880e
2008-10-27 04:52:16 +00:00
nealsid
32441cc060
Issue 181: Add version info for Mac OS X modules. Found by iterating over load commands until I found LC_ID_DYLIB. Also modified crash_report to generate version number. Also added suspend/resume capability to exception handler, necessary because exception handling can behave strangely across fork() calls. Also added fix for filtering out functions with no line number information, and for filtering out some multiple inheritance glue the compiler generates.
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@291 4c0a9323-5329-0410-9bdc-e9ce6186880e
2008-10-22 05:08:50 +00:00
ted.mielczarek
c5f46b2f4b
Issue 276 - generate GUIDs ahead of time in Linux handler. r=Liu Li
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@290 4c0a9323-5329-0410-9bdc-e9ce6186880e
2008-10-14 11:21:34 +00:00
nealsid
1de70760db
Fix for DWARF processing when inline functions were encountered. Inline functions were part of the debugging information as sequential in the PC range of the function but the source file was where the function was written(as you might expect). However the old dump_syms code, once it switched files as it was iterating over a range of addresses, never switched back, causing inline functions to cause all file numbers for addresses after the PC of the inline function to be wrong
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@289 4c0a9323-5329-0410-9bdc-e9ce6186880e
2008-10-14 01:24:02 +00:00
nealsid
bb067bf185
Fix warning when converting int to bool
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@288 4c0a9323-5329-0410-9bdc-e9ce6186880e
2008-10-10 17:51:32 +00:00
ted.mielczarek
596e476fc2
fix a typo in the makefile, HANDLER_SRC->HANDLER_OBJ
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@287 4c0a9323-5329-0410-9bdc-e9ce6186880e
2008-10-10 15:48:06 +00:00
nealsid
cb4aa6b804
Added DWARF support to Breakpad client. Thanks to Google for open sourcing their DWARF code!
...
Modified dump_syms to detect dSYM bundles or a binary with DWARF data appropriately, and convert data from DWARF reader to dump_syms native structures
R=danny.berlin (original writer of DWARF code)
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@286 4c0a9323-5329-0410-9bdc-e9ce6186880e
2008-10-08 23:56:02 +00:00
mmentovai
a509f4ec4b
Generate Windows full memory dumps as a separate file. Patch by Huan Ren
...
<huanr@google.com>. r=me
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@285 4c0a9323-5329-0410-9bdc-e9ce6186880e
2008-09-16 18:50:02 +00:00
mmentovai
9fcf4db315
Include what you use: include <algorithm> and <string.h> as needed. Patch by
...
Robert Henry. r=me
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@284 4c0a9323-5329-0410-9bdc-e9ce6186880e
2008-09-15 18:16:49 +00:00
doshimun
11dc028694
Log a failure message in case of LOCATE_NOT_FOUND error.
...
Without this change, no error is logged in this case.
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@283 4c0a9323-5329-0410-9bdc-e9ce6186880e
2008-07-30 19:39:48 +00:00
nealsid
85534c2eaf
Now we provide our own implementation of the MIG function exc_server, as recommended by Apple.
...
See
http://groups.google.com/group/google-breakpad-dev/browse_thread/thread/8b363b1f8a404714
For more information
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@282 4c0a9323-5329-0410-9bdc-e9ce6186880e
2008-07-11 17:39:52 +00:00
doshimun
2d7664e8d4
In the destructor of ClientInfo, currently the wait on the clent_crashed_event is
...
unregistered after the handle is closed. MSDN clearly says that the behavior is
undefined in this case. See http://msdn.microsoft.com/en-us/library/ms685061(VS.85).aspx
This change contains the fix for that bug. See attched diff.
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@281 4c0a9323-5329-0410-9bdc-e9ce6186880e
2008-06-09 23:38:24 +00:00
doshimun
3a516e4177
Client process uptime is a very useful metric for crashes. Instead of each client process having to keep track of uptime and report it whenever a crash happens, integrate this feature into breakpad OOP code so that all clients get it for free.
...
I tested this using the test app I have to test OOP stuff.
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@280 4c0a9323-5329-0410-9bdc-e9ce6186880e
2008-06-06 21:41:32 +00:00
nealsid
38bc56cfa8
Modified symupload to correctly handle spaces in module names when processing symbol file
...
Reviewer=mmentovai
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@279 4c0a9323-5329-0410-9bdc-e9ce6186880e
2008-06-05 21:20:53 +00:00
doshimun
cc6cd1ff37
Fix the following bug:
...
The sender updates the checkpoint file even when the report is not
successfully sent.
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@278 4c0a9323-5329-0410-9bdc-e9ce6186880e
2008-06-05 20:59:35 +00:00
nealsid
d55398a492
Filter out duplicates from the image list when creating a minidump. See issue 266 for more details.
...
Reviewer = mmentovai
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@277 4c0a9323-5329-0410-9bdc-e9ce6186880e
2008-06-04 22:57:09 +00:00
doshimun
f6b3e16ef8
Set the dump thread id and the requesting thread id properties of MDRawBreakpadInfo
...
only in case of in-process dump generation; otherwise the dump processing code of
breakpad doesn't identify the crashing thread properly.
I am checking this in to-be-reviewed since it is needed urgently in one of the
products at Google.
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@276 4c0a9323-5329-0410-9bdc-e9ce6186880e
2008-05-31 19:23:20 +00:00
nealsid
b91bb881d5
Fix to ignore source files that have a text address of 0 in their stabs entry
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@275 4c0a9323-5329-0410-9bdc-e9ce6186880e
2008-05-19 17:27:40 +00:00
doshimun
72bafd378d
Microsoft broke PROCESS_ALL_ACCESS when we build with WINVER=0x600. See http://nsylvain.blogspot.com/2008/01/winverwin32winnt-mayhem.html for
...
details (second half of the post).
Changing PROCESS_ALL_ACCESS to GENERIC_ALL in ClientInfo class when
opening the client process handle on the OOP server side.
A minor change to pipe name in the test app also.
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@274 4c0a9323-5329-0410-9bdc-e9ce6186880e
2008-05-15 04:12:34 +00:00
mmentovai
808ff9bc70
64-bit processor can't handle 32-bit ppc minidumps due to struct padding
...
differences on 64- and 32-bit CPUs. Force 32-bit alignment rules for
32-bit ppc context struct. r=nealsid
http://groups.google.com/group/google-breakpad-dev/browse_thread/thread/21a8e99c4800b51d
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@273 4c0a9323-5329-0410-9bdc-e9ce6186880e
2008-05-14 18:24:23 +00:00
nealsid
d318f9efee
Fix to stop unit tests from being compiled & run for non-native architectures
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@272 4c0a9323-5329-0410-9bdc-e9ce6186880e
2008-05-08 23:15:00 +00:00
doshimun
7ab126ecdd
Replace the user of wcscpy_s with safe_wcscpy in common/windows/string_utils-inl.h to
...
make the code compatible for teams that still use VS 2003 to build.
Fix a bug in client ClientInfo class that returned CustomClientInfo struct containing
a pointer in the client process address space instead of pointer to in-process data
structure.
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@271 4c0a9323-5329-0410-9bdc-e9ce6186880e
2008-05-08 18:15:07 +00:00
doshimun
8602aa71ec
Some style guide compliance changes and changed the prototype of the method to get custom client info in ClientInfo class.
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@270 4c0a9323-5329-0410-9bdc-e9ce6186880e
2008-05-07 21:54:12 +00:00
nealsid
c2bdaa613c
Bug fix for issue 263: mach_vm_region_recurse calls have invalid parameter specified, which succeeds on Leopard but fails on Tiger
...
Reviewer: Chris Rogers(ladderbreaker)
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@269 4c0a9323-5329-0410-9bdc-e9ce6186880e
2008-05-07 21:15:12 +00:00
doshimun
3d4dc1f201
Add a convenience method to CustomClientInfo struct to set both name and value in one call.
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@268 4c0a9323-5329-0410-9bdc-e9ce6186880e
2008-05-05 21:03:51 +00:00
doshimun
0ded3d718f
Add a way for the client apps to specify custom information in case of out-of-process
...
scenarios that the OOP server can use in whatever way it wants to.
Fix a bug in CrashGenerationserver where CreateNamedPipe failure was not checked correctly.
TODO in near future: Add a custom stream to minidump files for the custom information.
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@267 4c0a9323-5329-0410-9bdc-e9ce6186880e
2008-05-05 20:03:56 +00:00
nealsid
47df365bf8
Issue 261/262: 64-bit bug fix when iterating through load commands of a 64-bit binary, and added new test case for ReadImageInfoForTask
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@266 4c0a9323-5329-0410-9bdc-e9ce6186880e
2008-05-05 18:20:04 +00:00
nealsid
d6f0f92de3
Style changes
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@265 4c0a9323-5329-0410-9bdc-e9ce6186880e
2008-04-30 00:56:17 +00:00
nealsid
d906d0f7c9
Updated code to be compliant with style guidelines
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@264 4c0a9323-5329-0410-9bdc-e9ce6186880e
2008-04-29 23:49:39 +00:00
nealsid
4c39c138fe
Issue 258: Added test cases for ReadTaskMemory, reorganized project file, renamed filenames inside comments
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@263 4c0a9323-5329-0410-9bdc-e9ce6186880e
2008-04-25 00:37:19 +00:00
doshimun
9033edcd7b
Add one more parameter to the ClientDumpRequestCallback in crash generation server
...
to pass in the path of the dump file if the dump was generated successfully.
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@262 4c0a9323-5329-0410-9bdc-e9ce6186880e
2008-04-17 21:21:48 +00:00
nealsid
9609db8173
Fix a bug in start address calculation
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@261 4c0a9323-5329-0410-9bdc-e9ce6186880e
2008-04-17 04:15:30 +00:00
nealsid
5da03791a7
As part of resolving issue 256 I'd like to check in some unit
...
tests(ok, just one) for the private copy of nlist that I checked in
last week, plus lay some of the ground work for collecting code
coverage numbers. Both of these are accomplished by leveraging the
built-in facilities of Xcode & Developer Tools(namely, CPlusTest and
gcov integration; however, eventually I will also add a way to get
lcov results from the gcov results). I also:
- renamed breakpad_nlist_64.c to breakpad_nlist_64.cc to be more
consistent(even though it's not C++ code it still only gets called by
C++ code so I don't have to deal with extern "C" constructs).
- I created a new target (minidump_tests) that has a "Coverage"
configuration with the appropriate GCC flags turned on. It is only
compiled in 64-bit configurations and has 10.5 as a minimum
deployment target as well as uses the 10.5 SDK.
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@260 4c0a9323-5329-0410-9bdc-e9ce6186880e
2008-04-15 23:09:30 +00:00
nealsid
b0d807666f
Issue 254: The problem is that nlist() is compiled out of libc in
...
64-bit builds of Leopard. I ported the code over myself and will
check it into the Breakpad tree until we decide there's a better
longer-term solution. If you want to diff the changes, the Apple
source is in libc/gen/nlist.c(I used 498 from 10.5.2).
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@259 4c0a9323-5329-0410-9bdc-e9ce6186880e
2008-04-12 01:16:18 +00:00
doshimun
35c34d6bb9
Add a parameter to CrashGenerationServer to let the callers set the
...
security attributes on the pipe. This is useful when the process
hosting the crash server wants to let processes from other users to
connect to it and generate dumps for them.
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@258 4c0a9323-5329-0410-9bdc-e9ce6186880e
2008-04-12 00:00:34 +00:00
doshimun
05ec557277
Some cosmetic/style changes to conform to style guidelines. This time
...
I waited for the style reviewer to approve all my code so hopefully there
should be no more style related check-ins.
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@256 4c0a9323-5329-0410-9bdc-e9ce6186880e
2008-04-08 19:03:57 +00:00
mmentovai
eeca9921c5
Fix newlines ( #253 ). rs=ted.mielczarek
...
http://groups.google.com/group/google-breakpad-dev/browse_thread/thread/7e62a299ce3fa222
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@255 4c0a9323-5329-0410-9bdc-e9ce6186880e
2008-04-07 21:50:57 +00:00
mmentovai
61ea8bf0d5
Processor crashes on some truncated minidumps after #222 . r=ted.mielczarek
...
http://groups.google.com/group/google-breakpad-dev/browse_thread/thread/a451668b1ece259f
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@254 4c0a9323-5329-0410-9bdc-e9ce6186880e
2008-04-04 21:41:50 +00:00
nealsid
867df1c652
Issue 246: Dynamic_images.* needs to be 64-bit ready. Created types that are typedefed to the appropriate types depending on 32/64-bit compilation and modified dynamic_images to use these new types. Tested 32-bit minidump-generation. Also did some code cleanup along the way. Removed all blank lines that had spaces.
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@253 4c0a9323-5329-0410-9bdc-e9ce6186880e
2008-04-04 21:35:41 +00:00
doshimun
fc816a3b3a
Minor style changes to comply with Google style guidelines.
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@252 4c0a9323-5329-0410-9bdc-e9ce6186880e
2008-04-03 21:46:58 +00:00
ted.mielczarek
dd2ff4a21c
issue 223 - Fixes for SOlaris handler during integration with Firefox. patch by Alfred Peng, r=mento,me
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@250 4c0a9323-5329-0410-9bdc-e9ce6186880e
2008-03-18 16:10:10 +00:00
nealsid
a194d6f1ac
Issue 245: refactoring minidump_format.h into architecture & platform specific files
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@249 4c0a9323-5329-0410-9bdc-e9ce6186880e
2008-03-17 05:24:12 +00:00
doshimun@gmail.com
5066fcdb42
TO BE REVIEWED.
...
Have sent an email for code review already but this check-in is urgent
to fix potential build breaks.
It contains the following changes:
- Change project settings for exception_handler.vcproj so that it links in
crash_generation.lib so that the applications using exception_handler.lib
do not have to link to crash_generation.lib. Make these changes for all 4
build configurations.
- Change the test app project settings to not link to crash_generation.lib
and only link to exception_handler.lib; again for all four configurations.
These changes help the applications that are currently linking to exception_handler.lib
in that they don't have to link to one more lib to get out-of-process dump generation
functionality. In fact, even if they do not use out-of-process dump generation functionality,
after those changes, the apps will need to link with crash_generation.lib anyway in order to
build correctly. This change will eliminate that need.
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@248 4c0a9323-5329-0410-9bdc-e9ce6186880e
2008-03-11 22:28:48 +00:00
doshimun@gmail.com
a8b48f29dd
This changelist contains the changes to the configuration of Visual Studio solution and project files that I
...
added in my last check-in for out-of-process dump generation. My last check-in broke the breakpad_client.sln
build for non debug builds since for the new project that I added (crash_generation.vcproj) to that solution,
I always only changed project properties for debug build. In fact, I didn't have the static-crt build configurations
for the new project either. Similar problems existed for the test application I added, windows/test/crash_generation_app).
This changelist contains changes to 2 solution files, 2 vcproj files and 1 .cc file. The fixes to .cc file are to avoid
warnings on variables used only in debug modes (in asserts) when building in release modes.
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@247 4c0a9323-5329-0410-9bdc-e9ce6186880e
2008-03-10 22:37:07 +00:00
doshimun@gmail.com
c79141e306
Overview:
...
Implement out-of-process dump generation for Windows platform.
Details:
- Created a lib, crash_generation.lib, that implements the out-of-process dump generation protocol.
- The lib code is under client/windows/crash_generation folder and is organized in the following way:
- CrashGenerationServer class (crash_generation_server.h/.cc) implements the server side of
the protocol.
- CrashGenerationClient class (crash_generation_client.h/.cc) implements the client side of
the protocol.
- MinidumpGenerator class (minidump_generator.h/.cc) serves as an abstractino for generating
dump files using Windows APIs, coming up with new file names by creating GUIDs, etc.
- ProtocolMessage class (ipc_protocol.h) represents the message format between the client and server
for pipe IPC.
- Server allows one client at a time on the pipe in the current implementation.
- ReadMe.txt explains the state machine the server uses to serve clients.
- ExceptionHandler is modified and a new constructor is added that allows specifying the pipe name. If the
pipe name is NULL, the behavior is backward compatible - in-process dump generation is done as before. If
the pipe name is specified, out-of-process dump generation registration is attempted. If that fails, the
behavior is again backward compatible.
- If out-of-process registration succeeds, all write dump requests, direct or indirect, are directed to
crash server process that served the registration request. NOTE that the explicit dump requests made by
calling the static method of ExceptionHandler are not directed to theserver.
- client/windows/tests/crash_generation_app implements a simple Win32 GUI application to help test the
out-of-process dump generation client and server. Typical use of the app is to start one instance, click
Server --> Start and then start the other instance. The other instance will register with the first
instance automatically at start-up. Then the second instance can be used to request various typoes of
dump requests by using options under the Client menu.
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@244 4c0a9323-5329-0410-9bdc-e9ce6186880e
2008-03-08 00:02:40 +00:00
bryner
98cb0aebff
Use "%" PRIx64 instead of "%llx" for 64-bit portability.
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@243 4c0a9323-5329-0410-9bdc-e9ce6186880e
2008-03-04 20:28:39 +00:00
bryner
76ef9deb31
Don't redefine __STDC_FORMAT_MACROS if it's already defined. r=mmentovai.
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@242 4c0a9323-5329-0410-9bdc-e9ce6186880e
2008-03-04 17:33:25 +00:00
mmentovai
c27cf3e395
Use "%" PRIx64 instead of "%llx" ( #241 ). r=bryner
...
http://groups.google.com/group/google-breakpad-dev/browse_thread/thread/327dc5326077e48d
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@241 4c0a9323-5329-0410-9bdc-e9ce6186880e
2008-02-25 19:32:00 +00:00
ted.mielczarek
2c2ae28541
issue 238 - missing includes compiling with gcc 4.3. patch by taras glek, r=me
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@240 4c0a9323-5329-0410-9bdc-e9ce6186880e
2008-02-24 21:04:51 +00:00
ted.mielczarek
c1e0783204
Use swprintf_s for VC8 or newer. r=mento
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@238 4c0a9323-5329-0410-9bdc-e9ce6186880e
2008-02-04 20:50:07 +00:00
mmentovai
469580e2df
Remove dependency on ole32 on Windows ( #132 ). Patch by Sorin Jianu <sorinj>, r=me.
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@237 4c0a9323-5329-0410-9bdc-e9ce6186880e
2008-01-28 20:02:01 +00:00
luly81
b801cd6d0f
Fix issue 235, properly handling included(inlined) code.
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@236 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-12-13 06:56:23 +00:00
ted.mielczarek
b3673d13a1
Issue 224 - add Tell method to Minidump class. r=mento
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@235 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-12-04 20:41:02 +00:00
ted.mielczarek
e8eafaaa2e
slight fixup from issue 225
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@234 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-12-03 22:12:25 +00:00
ladderbreaker
4139a40807
fix Mac build by adding stackwalker_amd64.cc to project
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@233 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-11-21 21:07:22 +00:00
ted.mielczarek
68b4798eb4
Issue 225 - dynamically load libcurl in http_upload. patch by Andrew Schultz <ajschult@verizon.net>, r=Liu Li
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@232 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-11-20 02:35:47 +00:00
ted.mielczarek
f0a07749af
Fix compile bustage from issue 221
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@231 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-11-20 02:21:49 +00:00
luly81
299c816021
Add MD_CPU_ARCHITECTURE_AMD64 as valid system type when cpu type is MD_CONTEXT_X86
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@230 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-11-19 05:53:21 +00:00
mmentovai
bbd9b47291
The string buffer lengths in a URL_COMPONENTS structure are in TCHARs, so
...
these should be sizeof(z) / sizeof(z[0]) to avoid a buffer overrun. Caught
by Dmitry Titov, r=me.
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@229 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-11-13 22:17:14 +00:00
ted.mielczarek
feff0b300f
Issue 221 - HTTPUpload::SendRequest should provide error code or error description to callers. r=Liu Li
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@228 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-11-02 12:22:35 +00:00
ted.mielczarek
8eb7111814
Issue 196 - Breakpad processor support for x86-64. r=mento
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@227 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-10-31 19:20:31 +00:00
mmentovai
11e180cd3e
Fix warning regarding initialization order compared to definition order
...
following #222 .
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@226 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-10-22 16:00:35 +00:00
ted.mielczarek
d732add382
Issue 222 - processor fails if an entry in the ModuleList is bad. r=mento
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@225 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-10-19 18:44:51 +00:00
mmentovai
f4021f0c68
Make Breakpad's debug-exception-ignoring configurable. r=Nicolas Sylvain
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@224 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-10-18 20:54:20 +00:00
mmentovai
e47d3a6e36
Remove assertion for a variable that doesn't exist. Patch by Alfred Peng
...
<alfred.peng>. r=me.
http://groups.google.com/group/google-breakpad-dev/browse_thread/thread/e5738aed43450365
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@223 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-10-15 20:47:12 +00:00
mmentovai
56d93f4902
Make sure ENOENT is defined. Spotted by jfbastien <bourgeoisie>.
...
http://groups.google.com/group/google-breakpad-discuss/browse_thread/thread/47f82fe37b7a46d8
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@222 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-10-10 21:15:10 +00:00
ladderbreaker
a100421d48
fix crash_report build due to link error
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@221 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-09-29 01:02:13 +00:00
mmentovai
d7d6c74a68
Breakpad rejects valid modules with a vmaddr of zero on Mac ( #176 ). Patch
...
by Benjamin Smedberg <bsmedberg>. r=me
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@220 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-09-28 18:30:48 +00:00
mmentovai
657a6c4a96
Assertion in CrashReportSender (windows) when no checkpoint file is desired
...
(#216 ). Patch by Ben Turner <bent.mozilla>. r=me.
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@219 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-09-28 18:24:13 +00:00
mmentovai
68004c84d6
Solaris version of symbol dumper ( #207 ). Patch by Alfred Peng. r=me
...
http://groups.google.com/group/google-breakpad-dev/browse_thread/thread/e4cbdbf7ddaf7f51
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@218 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-09-28 18:14:48 +00:00
mmentovai
f2fa084fd2
Fix compiler warning C4245: signed/unsigned mismatch when converting between
...
types. Patch by Sorin Jianu. r=me,bryner
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@217 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-09-28 16:27:56 +00:00
mmentovai
ea2bba9706
Add SPARC/Solaris support to client handler and processor ( #201 , 200).
...
Patch by Michael shang <satisfy123>. r=me, r=Alfred Peng.
http://groups.google.com/group/google-breakpad-discuss/browse_thread/thread/2fba07577f1fa35e
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@215 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-09-26 18:28:05 +00:00
mmentovai
278946c3b5
Fix crash reason switching to allow proper behavior for Linux. Spotted by
...
Michael Shang <satisfy123>, mentioned in issue #200 . r=me
http://groups.google.com/group/google-breakpad-discuss/browse_thread/thread/2fba07577f1fa35e
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@214 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-09-26 18:13:38 +00:00
mmentovai
0e6f5c95d7
Allow Breakpad processor library to build on Solaris with the native Sun
...
toolchain (#142 ). Patch by Alfred Peng. r=me.
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@213 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-09-26 18:08:41 +00:00
mmentovai
7e2b64f5fd
Fix license boilerplate on these two files. Apparently these were missed
...
when the boilerplates were fixed in revision 31/bug 29 - these files
were checked in at revision 32.
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@212 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-09-26 17:55:53 +00:00
bryner
28c645f3ee
Silences warning C4701: local variable 'claimed_size' may be used with out
...
having been initialized. The code is correct however the compiler can't see
the relationship between has_content_length_header and the claimed_size so it
generates a warning.
Patch from Sorin Jianu, r=bryner
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@211 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-09-20 21:48:47 +00:00
ladderbreaker
48309a2dbc
Issue 208: Reviewer waylonis
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@210 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-09-19 20:43:38 +00:00
ladderbreaker
30dfc3d392
Issue 208: Reviewer waylonis
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@209 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-09-19 20:15:21 +00:00
ladderbreaker
649967cfd2
Issue 209: Reviewer waylonis
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@208 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-09-19 20:14:21 +00:00
dmaclach
99b36baa82
Adds the ability to designate a folder with sym files in it that will be used for symbol matching
...
to crash_report.
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@207 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-09-15 00:33:09 +00:00
ladderbreaker
d792274003
Issue203 : reviewed by Waylonis
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@206 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-08-29 21:28:46 +00:00
ladderbreaker
69d242245a
Issue 202: reviewed by Waylonis
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@205 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-08-27 19:46:32 +00:00
ladderbreaker
9982e65506
Issue 199: Reviewed by Waylonis
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@204 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-08-17 21:22:16 +00:00
mmentovai
6a3f87982d
Add accessor for ExceptionHandler::requesting_thread_id_ ( #198 ). Patch by Lucas Eckels. r=me
...
http://groups.google.com/group/google-breakpad-dev/browse_thread/thread/37da2dd8c14659c3
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@203 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-08-17 19:42:18 +00:00
ladderbreaker
70c7438bff
Issue 197: reviewed by Waylonis
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@202 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-08-16 20:22:37 +00:00
ladderbreaker
8597ff9fe1
Issue 197: reviewed by Waylonis
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@201 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-08-16 20:20:50 +00:00
ladderbreaker
7d8a79b3e9
Issue 197: reviewed by Waylonis
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@200 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-08-16 20:20:31 +00:00
ladderbreaker
8aef89f021
Issue 197: reviewed by Waylonis
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@199 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-08-16 20:19:45 +00:00
mmentovai
9abfe3d0a5
Solaris port of minidump generator. Port by Alfred Peng. r=me
...
http://groups.google.com/group/google-breakpad-dev/browse_thread/thread/7d8945578e3dac3
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@198 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-08-07 21:16:45 +00:00
ted.mielczarek
b62d01462c
Issue 175 - fix permissions on dump file in MinidumpFileWriter. r=mento
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@197 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-07-05 22:13:02 +00:00
ted.mielczarek
8408a209cd
issue 151 - Crash when processing file names less than 4 bytes. r=me
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@196 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-07-05 19:31:59 +00:00
ladderbreaker
43a81daaba
issue 194: reviewed by waylonis
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@195 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-07-03 00:09:14 +00:00
mmentovai
3c07b28119
These should be int to allow them to be ORed together. Ted, please review.
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@194 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-07-02 20:41:30 +00:00
mmentovai
6a844b1d85
Allow finer control over installed handler types ( #193 ). r=ted.mielczarek
...
http://groups.google.com/group/google-breakpad-dev/browse_thread/thread/992a1bb09dc58a32
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@193 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-07-02 19:41:05 +00:00
ted.mielczarek
1260067e42
Issue 190 - 32 bit build fails on a 64 bit Linux system. Patch by wgianopoulos, r=me
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@192 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-07-02 18:13:33 +00:00
mmentovai
fb6be7cf42
Add an API to pass exception information into the handler ( #192 ).
...
r=ted.mielczarek
http://groups.google.com/group/google-breakpad-dev/browse_thread/thread/42e9ee1a636bca8b
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@191 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-07-02 15:36:56 +00:00
ted.mielczarek
bd7b42587c
Issue 191 - Linux dump_syms produces bad line numbers for some functions (16 bit overflow). r=Liu Li
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@190 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-07-02 12:02:36 +00:00
ted.mielczarek
b5c78cc8d1
issue 185 - Need constants / stringification for Linux exception codes. r=mento
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@189 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-06-11 17:03:30 +00:00
ted.mielczarek
21d58c7281
Issue 182: linux handler doesn't have sigcontext if called from a previous signal handler. r=mento / Liu Li
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@188 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-06-11 16:01:46 +00:00
ladderbreaker
2e86dfe705
issue 154: reviewed by Waylonis
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@187 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-06-06 20:49:48 +00:00
ted.mielczarek
684649a571
Issue 42 - check for non-existent dump file in HTTPUpload::SendRequest. r=bryner
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@186 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-06-01 11:47:28 +00:00
ted.mielczarek
f68536ae50
Issue 169 - Fill in CPU vendor id in MDRawSystemInfo in Linux minidump_generator. r=Liu Li
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@185 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-05-31 20:28:43 +00:00
mmentovai
3114dc8a35
C++ file gets a C++ comment
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@184 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-05-31 19:49:04 +00:00
mmentovai
2e0e2234b9
Allow building with -pedantic ( #186 ). r=ted.mielczarek
...
http://groups.google.com/group/google-breakpad-dev/browse_thread/thread/6aa39d7f0ffa3c42
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@183 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-05-31 19:44:52 +00:00
mmentovai
e96a791d9a
Check allocation and array sizes in minidump.cc ( #12 ). r=bryner
...
http://groups.google.com/group/google-breakpad-dev/browse_thread/thread/7258b34d26ffc890
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@182 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-05-31 15:54:06 +00:00
ted.mielczarek
46b60801cb
Updated test data from Issue 143
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@181 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-05-30 14:06:36 +00:00
ted.mielczarek
90e050e598
Issue 143 - MinidumpProcessor should extract number of processors. r=mento
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@180 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-05-30 12:14:09 +00:00
ted.mielczarek
0e94332f7c
Issue 184 - MinidumpModule::code_identifier doesn't handle MD_OS_LINUX. r=mento
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@179 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-05-29 21:30:48 +00:00
mmentovai
6ed453a770
Processor can attempt processing all threads even when interrupted ( #177 ).
...
r=ted.mielczarek
http://groups.google.com/group/google-breakpad-dev/browse_thread/thread/8fda7c96fa7b5d57
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@178 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-05-25 19:10:19 +00:00
mmentovai
32b802dba3
Provide for logging initialization routines ( #179 ). r=bryner
...
http://groups.google.com/group/google-breakpad-dev/browse_thread/thread/4b196ca0b6d7f9a6
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@177 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-05-25 18:04:17 +00:00
mmentovai
1ef60aaa6c
Fix bustage introduced in [172]
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@176 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-05-25 16:06:53 +00:00
dmaclach
cb449c6c88
Fixup crashreport tool on the mac
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@175 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-05-24 22:07:37 +00:00
ladderbreaker
026b28ec40
issue 167: reviewed by Benjamin Smedberg
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@174 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-05-22 00:25:38 +00:00
mmentovai
fabb8714a7
Strengthen range checks in minidump.cc ( #173 ). r=bryner
...
http://groups.google.com/group/google-breakpad-dev/browse_thread/thread/ad373296bfe5e08b
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@173 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-05-21 21:02:04 +00:00
mmentovai
65571f17ed
Add logging to minidump processor ( #82 ). Part 2: add messages to the rest of
...
the processor. r=ted.mielczarek
http://groups.google.com/group/google-breakpad-dev/browse_thread/thread/cf56b767383a5d4b
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@172 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-05-21 20:09:33 +00:00
bryner
08c8c4ddcf
Add an optional per-day limit to the number of crash reports sent. The state
...
is maintained in an app-specified checkpoint file. (#174 , r=mmentovai)
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@171 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-05-21 18:32:02 +00:00
waylonis
32d4064736
- Add const keyword / casting to supress more stringient compiler warnings
...
- Move DynamicImage::Print() from dynamic_images.h to dynamic_images.cc
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@170 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-05-19 00:41:39 +00:00
mmentovai
af3c43f00e
Add logging to minidump processor ( #82 ). First part: logging infrastructure
...
and messages for minidump.cc and minidump_processor.cc. r=bryner.
http://groups.google.com/group/google-breakpad-dev/browse_thread/thread/b056994d675f623c
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@169 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-05-17 18:34:37 +00:00
ted.mielczarek
95be2b659e
Issue 168 - Output debug file and debug identifier in minidump_stackwalk machine-readable output. r=mento
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@168 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-05-16 18:11:36 +00:00
ted.mielczarek
822ead1319
Issue 140 - Fill in some more cpu information on OS X x86 dumps. r=mento
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@167 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-05-11 00:50:29 +00:00
ted.mielczarek
b86e7ec7f0
Issue 162 - handle pure virtual function calls in VC++. r=mento
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@166 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-05-10 17:12:14 +00:00
ted.mielczarek
b44d391b53
Fixing comment about cpuid vendor_id
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@165 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-05-10 16:01:33 +00:00
ladderbreaker
8deb7b799f
Issue 166 - reviewer Waylonis
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@164 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-05-09 01:32:45 +00:00
mmentovai
436801fa23
Stacks (still) truncated on win32 ( #165 ). Patch by Benjamin Smedberg. r=me
...
Don't require a program string to reset %ebp, as not all program strings
set this value.
http://groups.google.com/group/google-breakpad-dev/browse_thread/thread/ee4854ae7ffce94e
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@163 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-05-08 20:56:30 +00:00
ted.mielczarek
0e668e0783
Issue 164 - MACHINE_THREAD_STATE on older 10.4 versions. Patch by Dave Camp, r=Chris Rogers
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@162 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-05-08 19:04:14 +00:00
ted.mielczarek
980f6dc277
Extraneous newline in format string
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@161 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-05-08 11:31:10 +00:00
ladderbreaker
3d55532df2
Issue 161: reviewer Waylonis
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@160 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-05-07 19:48:02 +00:00
ted.mielczarek
0c70be6873
Issue 163, reviewer mento. Make dynamic_images.cc build on 10.3.9 SDK + update XCode project
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@159 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-05-07 19:32:44 +00:00
ladderbreaker
40a5c0fb0d
simply fix no newline at end of file
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@158 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-05-04 21:23:30 +00:00
ted.mielczarek
663b7904e4
oops, committed accidentally
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@157 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-05-04 19:52:18 +00:00
ted.mielczarek
9a3263a670
Issue 160 - Reviewer Chris Rogers
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@156 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-05-04 19:37:00 +00:00
ted.mielczarek
9be806efde
missed header renames from Issue 152
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@155 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-05-04 12:41:02 +00:00
ladderbreaker
1fa8046e35
Issue 158: reviewer ladderbreaker
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@154 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-05-03 22:58:56 +00:00
luly81
265726e56c
Add md5 implementation into code base to get rid of
...
openssl dependency.
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@153 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-05-03 20:45:27 +00:00
ted.mielczarek
255bbe93ed
Issue 152 - Patch by Dave Camp, Reviewer Chris Rogers
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@152 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-05-03 20:12:41 +00:00
ladderbreaker
de2fd15db9
Issue 159: reviewer Waylonis
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@151 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-05-02 21:05:49 +00:00
ladderbreaker
c455a76c03
Issue 159: reviewer Waylonis
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@150 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-05-02 21:04:57 +00:00
luly81
e219ba182e
Merge Ted's patch for writing symbols to stdout for linux.
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@149 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-05-02 19:13:09 +00:00
mmentovai
3c27dcc1b6
Minidump without context crashes the processor ( #153 ). r=bryner
...
http://groups.google.com/group/google-breakpad-dev/browse_thread/thread/2d221bd478bec550
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@148 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-04-25 19:38:01 +00:00
mmentovai
329e6a9630
Emergency crash fix, tbr=bryner
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@147 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-04-25 15:17:19 +00:00
mmentovai
b63740b329
Truncated Windows/x86 stacks when using FPO. Add stack scanning to recover
...
instruction and frame pointers with better reliability. r=bryner
http://groups.google.com/group/google-breakpad-dev/browse_thread/thread/e74af03fb0629aa0
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@146 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-04-20 18:36:42 +00:00
mmentovai
1d4ce0a1d8
c++filt crashes when fed some mangled ObjC++ names. Oops. Patch by Dave
...
MacLachlan, r=me.
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@145 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-04-12 20:40:22 +00:00
ladderbreaker
e9017f3239
Issue 147 - reviewer Waylonis
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@144 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-04-11 00:45:00 +00:00
mmentovai
29789d8106
Wrong version of swprintf used with VS 2003/7.1 CRT. r=bryner
...
http://groups.google.com/group/google-breakpad-dev/browse_thread/thread/eadfa703d4bd8a4a
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@143 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-04-09 18:35:20 +00:00
mmentovai
375931a680
Revert previous patch, see google-breakpad-dev
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@142 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-04-05 19:44:29 +00:00
mmentovai
fe60ba9789
Fix temp file leak. Patch by Thomas Thiriez. r=me
...
http://groups.google.com/group/google-breakpad-discuss/browse_thread/thread/42293e72537b554
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@141 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-04-05 19:41:33 +00:00
mmentovai
30fc9ce1c0
Replace GB_WSU_SAFE_SWPRINTF_TERMINATE with inline code ( #145 followup).
...
r=bryner
http://groups.google.com/group/google-breakpad-dev/browse_thread/thread/f77da3d219cf9388
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@140 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-04-04 16:13:55 +00:00
luly81
825840253b
Discard age field in the dumped symbol file.
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@139 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-04-04 03:26:40 +00:00
ladderbreaker
e2abee6b01
Issue 147 - reviewer Waylonis
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@138 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-04-03 01:18:18 +00:00
ladderbreaker
aa870d0c1b
Issue 146 - reviewer Waylonis
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@137 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-04-02 23:17:16 +00:00
mmentovai
1de8bed899
Windows http_upload should allow response without Content-Length header ( #144 ).
...
Patch by Ted Mielczarek. r=me
http://groups.google.com/group/google-breakpad-dev/browse_thread/thread/a401434f639e5b2f
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@136 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-04-02 18:24:16 +00:00
mmentovai
aec44489da
vswprintf causes Purify to fail ( #145 ). r=darin
...
http://groups.google.com/group/google-breakpad-dev/browse_thread/thread/88e18d9fac4eee22
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@135 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-03-30 20:30:08 +00:00
luly81
3479e850c5
Fix issue 136.
...
Block signals before writing minidumps.
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@134 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-03-29 01:32:39 +00:00
luly81
ab175ccc2b
Fix bug of issue 135, now can dump symbols for dynamic libraries.
...
Also some minor fixes to make it compile with more strict compiling options.
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@133 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-03-27 02:16:13 +00:00
ladderbreaker
baaeb5af71
issue141: reviewer Waylonis
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@132 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-03-23 20:23:31 +00:00
mmentovai
33f178df55
s/an breakpad/a breakpad/ ( #127 ), patch by techtonik, r=me
...
http://groups.google.com/group/google-breakpad-dev/browse_thread/thread/9610c2878a2bcdc
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@131 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-03-23 16:21:17 +00:00
bryner
809f0cb858
Ignore functions that have invalid addresses or sizes, instead of aborting the
...
symbol file load (#137 ). r=mmentovai.
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@130 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-03-22 23:20:17 +00:00
mmentovai
6bc866cc82
Don't output FUNC lines for 0-length functions ( #139 ). r=bryner
...
http://groups.google.com/group/google-breakpad-dev/browse_thread/thread/c684520587356ec3
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@129 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-03-22 21:10:30 +00:00
ladderbreaker
d128f5f6af
issue 134: reduce timeout period for minidump upload : reviwer waylonis
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@128 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-03-16 18:28:53 +00:00
ladderbreaker
1a4310017e
issue 133: Mach-o UUID generation has problems - reviewed by waylonis
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@127 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-03-16 17:51:43 +00:00
luly81
bcd46f0079
Add Linux exception handler.
...
Add Linux stab symbol dumper.
Add minidump & symbol uploader for Linux.
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@126 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-03-12 01:53:18 +00:00
ladderbreaker
1f3d2571d1
fixes for issue 129 : reviewed by Waylonis
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@125 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-03-09 21:45:42 +00:00
ladderbreaker
530a7ad99e
fixes for issue 128: reviewed by Waylonis
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@124 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-03-08 23:47:37 +00:00
bryner
fce2508282
Fix exception handler build with MSVC versions prior to 2005. r=mmentovai.
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@123 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-03-05 21:13:23 +00:00
mmentovai
e5dc60822e
Rename Airbag to Breakpad.
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@122 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-02-14 19:51:05 +00:00
waylonis
83befb1cb4
Change the symbol table parsing so that it will only use symbols that are from the __TEXT/__text section.
...
Fixes issue #127
tbr=mmentovai.
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@121 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-02-08 18:04:48 +00:00
mmentovai
baff938211
Airbag windows client didn't trap VC8 parameter validation errors. Now it
...
does. (#120 ) r=bryner.
http://groups.google.com/group/airbag-dev/browse_thread/thread/3f21d0e379e32771
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@120 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-02-07 20:20:10 +00:00
waylonis
983264848d
Fix bug with mach-o walker not properly walking universal binary (Issue #125 )
...
Fix exception handler so that it will properly forward exceptions (Issue #126 )
r=mmentovai
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@119 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-02-07 18:57:09 +00:00
bryner
1d78cad82e
Store 128-bit values as a struct with high and low fields, so that consumers
...
of airbag don't have to know the platform endianness.
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@118 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-02-07 04:24:03 +00:00
waylonis
600e56bc39
- Fixes the bug with a fork()'d child's exception being caught in the parent process
...
- Only looks for EXC_MASK_BAD_ACCESS, EXC_MASK_BAD_INSTRUCTION, and EXC_MASK_ARITHMETIC exceptions
- Adds try/catch blocks around "new" for bad_alloc
- Uses map.find() rather than map[] notation so as not to create extraneous objects
- Creates the exception watching thread as detached
r=mmentovai
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@117 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-02-05 18:49:44 +00:00
waylonis
3a9a38a29e
Don't fail the minidump processing if the requesting thread can't be found.
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@116 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-02-01 23:54:05 +00:00