yuzu/breakpad
1
0
Fork 0
mirror of https://github.com/yuzu-emu/breakpad.git synced 2025-01-11 00:05:36 +00:00
Code Issues Packages Projects Releases Wiki Activity
1697 commits 1 branch 0 tags 15 MiB
Commit graph

678 commits

Author SHA1 Message Date
ted.mielczarek@gmail.com 0d9bd40775 Allow writing on-request minidumps with an exception stream 
R=mark at http://breakpad.appspot.com/172001/show

git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@745 4c0a9323-5329-0410-9bdc-e9ce6186880e
 2010-12-15 16:28:28 +00:00
ted.mielczarek@gmail.com cae59b4ae4 issue 334 - Fix a race condition between ExceptionHandler::Teardown and ExceptionHandler::WaitForMessage on OS X 
R=mark at http://breakpad.appspot.com/165001/show

git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@744 4c0a9323-5329-0410-9bdc-e9ce6186880e
 2010-12-15 16:28:22 +00:00
ted.mielczarek efbe428d83 Add some unit tests for the mac MinidumpGenerator 
R=mark at http://breakpad.appspot.com/240001/show

git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@742 4c0a9323-5329-0410-9bdc-e9ce6186880e
 2010-12-13 22:10:32 +00:00
ted.mielczarek ef7262d477 allow passing info about known memory mappings to MinidumpWriter and ExceptionHandler 
r=thestig at http://breakpad.appspot.com/242001/show

git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@741 4c0a9323-5329-0410-9bdc-e9ce6186880e
 2010-12-13 22:10:23 +00:00
kmixter@chromium.org b5dfa2834d Reuse code and fix inconsistent array boundaries. 
R=ted.mielczarek
Review URL: http://breakpad.appspot.com/237001

git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@740 4c0a9323-5329-0410-9bdc-e9ce6186880e
 2010-12-08 22:26:20 +00:00
ted.mielczarek 30b075c4a5 Fix WriteMemoryListStream to remove an extraneous loop index variable increment. 
Patch by timeless <timeless@mozdev.org>, R=me, unittest by me.
See https://bugzilla.mozilla.org/show_bug.cgi?id=615534

git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@735 4c0a9323-5329-0410-9bdc-e9ce6186880e
 2010-11-30 19:19:31 +00:00
thestig@chromium.org 3665a7d09b Linux: Attempt to generate an ELF identifier for deleted running binaries. 
Review URL: http://breakpad.appspot.com/228001

git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@733 4c0a9323-5329-0410-9bdc-e9ce6186880e
 2010-11-19 19:57:07 +00:00
thestig@chromium.org f66ff1afd2 Delete an old Makefile and fix lots of lint errors. 
Review URL: http://breakpad.appspot.com/225001

git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@727 4c0a9323-5329-0410-9bdc-e9ce6186880e
 2010-11-08 19:49:25 +00:00
ted.mielczarek 43378265bf Add asm/ptrace.h include to linux_dumper.cc to fix the silly scratchbox toolchain we're using for Maemo builds. Also shuffle around the include order to comply with style guidelines, while I'm here. 
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@718 4c0a9323-5329-0410-9bdc-e9ce6186880e
 2010-10-21 13:55:07 +00:00
ted.mielczarek cfc8628092 Add support for building the Linux client code using the Android NDK 
r=mwu at http://breakpad.appspot.com/212001/show

git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@716 4c0a9323-5329-0410-9bdc-e9ce6186880e
 2010-10-20 15:51:38 +00:00
thestig@chromium.org 8d1130a89e Only include linux_syscall_support.h on Linux in cross platform files. 
TBR=nealsid
Review URL: http://breakpad.appspot.com/204001

git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@700 4c0a9323-5329-0410-9bdc-e9ce6186880e
 2010-09-24 21:51:09 +00:00
ted.mielczarek 4621ee0691 Write a window of memory around the instruction pointer from the crashing thread to the minidump on OS X. 
R=nealsid at http://breakpad.appspot.com/200001/show

git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@699 4c0a9323-5329-0410-9bdc-e9ce6186880e
 2010-09-23 14:55:50 +00:00
erikwright@chromium.org a91e414f84 Modify crash_generation_app to use GYP instead of VS .sln file for ease of maintenance. 
Backed out r684 (added glog include dir to client gyp files). It was obviated by r685, which removed the dependency on glog from the client projects.

BUG=None
TEST="gclient runhooks --force"; build crash_generation_app; launch crash_generation_app.
r=hansl at http://breakpad.appspot.com/191001/show


git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@696 4c0a9323-5329-0410-9bdc-e9ce6186880e
 2010-09-21 17:27:07 +00:00
erikwright@chromium.org b6ee7dcb22 Fix CrashGenerationServer to recover from protocol errors and a test for same. 
R=siggi at http://breakpad.appspot.com/196001/show


git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@695 4c0a9323-5329-0410-9bdc-e9ce6186880e
 2010-09-20 21:35:24 +00:00
ted.mielczarek efa30c13f2 Write a window of memory around the instruction pointer from the crashing thread to the minidump on Linux. 
R=nealsid at http://breakpad.appspot.com/194001/show

git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@693 4c0a9323-5329-0410-9bdc-e9ce6186880e
 2010-09-17 13:36:11 +00:00
thestig@chromium.org 1efa3f9e10 Fix compilation for minidump-2-core. 
Review URL: http://breakpad.appspot.com/199001

git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@691 4c0a9323-5329-0410-9bdc-e9ce6186880e
 2010-09-16 23:29:04 +00:00
nealsid 4b7f1eba64 Actually treat fatal error codes as fatal 
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@690 4c0a9323-5329-0410-9bdc-e9ce6186880e
 2010-09-16 23:06:43 +00:00
thestig@chromium.org fda6a1e6fe Add a free() to ExceptionHandlerTest.ChildCrash. 
Review URL: http://breakpad.appspot.com/193001

git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@687 4c0a9323-5329-0410-9bdc-e9ce6186880e
 2010-09-16 01:24:32 +00:00
thestig@chromium.org 0e3b7020b8 Import linux_syscall_support.h from linux-syscall-support.googlecode.com instead of using our own copy. 
Review URL: http://breakpad.appspot.com/192001

git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@686 4c0a9323-5329-0410-9bdc-e9ce6186880e
 2010-09-15 22:31:57 +00:00
ted.mielczarek 90a41b68ad Fix include paths in breakpad_client.gyp to make the build work 
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@684 4c0a9323-5329-0410-9bdc-e9ce6186880e
 2010-09-15 14:46:32 +00:00
jessicag.feedback@gmail.com 9fc5812260 Fix a handful of comment spelling errors (Issue 385) 
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@682 4c0a9323-5329-0410-9bdc-e9ce6186880e
 2010-09-09 21:37:54 +00:00
ted.mielczarek 662b6da59d Allow Linux dumper to work on PTRACE-hardened kernels 
A=Chris Coulson <chris.coulson@canonical.com>
R=nealsid at http://breakpad.appspot.com/166001/show

git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@673 4c0a9323-5329-0410-9bdc-e9ce6186880e
 2010-08-27 13:18:49 +00:00
jessicag.feedback@gmail.com 07a1c07b7b Clean up old glog code and move deps to new reference in third_party. 
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@660 4c0a9323-5329-0410-9bdc-e9ce6186880e
 2010-08-19 22:23:03 +00:00
thestig@chromium.org 0b12b34928 When done with crash-dumping, we need to terminate the application. Calling 
tgkill() is not necessarily possible, as a sandbox might block this call.
This changelist tries different approaches depending on whether we received
a synchronous or an asynchronous signal. This fixes unittest failures and
also runs correctly in sandbox'd environments.

TEST=ran unittest, and opened about:crash in sandbox'd Chrome
BUG=395
A=markus@chromium.org
Original review: http://breakpad.appspot.com/159001
Review URL: http://breakpad.appspot.com/146002

git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@656 4c0a9323-5329-0410-9bdc-e9ce6186880e
 2010-08-17 02:59:01 +00:00
ted.mielczarek 2b7ae09319 remove trailing comma that makes gcc -pedantic unhappy 
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@653 4c0a9323-5329-0410-9bdc-e9ce6186880e
 2010-08-16 18:23:52 +00:00
ted.mielczarek@gmail.com 14889c340f Change ClientInfo into a class to match other platforms, rename the current ClientInfo to ExceptionInfo 
R=mark at http://breakpad.appspot.com/156001/show

git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@651 4c0a9323-5329-0410-9bdc-e9ce6186880e
 2010-08-16 16:48:59 +00:00
ted.mielczarek@gmail.com a599ae80aa Put MachIPC into the google_breakpad namespace 
R=mark at http://breakpad.appspot.com/151001/show

git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@650 4c0a9323-5329-0410-9bdc-e9ce6186880e
 2010-08-16 16:44:47 +00:00
thestig@chromium.org f5c8f6fb61 Fix a couple of bugs where we generate incorrect minidump files on Linux.o 
Patch by Markus Gutschke <markus@chromium.org>.  R=thestig

Review URL: http://breakpad.appspot.com/150001
Review URL: http://breakpad.appspot.com/155001

git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@649 4c0a9323-5329-0410-9bdc-e9ce6186880e
 2010-08-14 01:41:39 +00:00
thestig@chromium.org 3a69e0e1d1 Miscellaneous improvements to minidump-2-core. 
Patch by Markus Gutschke <markus@chromium.org>.  R=agl
See http://breakpad.appspot.com/148002 and http://codereview.chromium.org/3152010.
Review URL: http://breakpad.appspot.com/152001

git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@648 4c0a9323-5329-0410-9bdc-e9ce6186880e
 2010-08-14 01:32:54 +00:00
ted.mielczarek@gmail.com 144938cf22 Allow dumping live processes on OS X 
R=mark at http://breakpad.appspot.com/148001/show

git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@647 4c0a9323-5329-0410-9bdc-e9ce6186880e
 2010-08-13 20:19:32 +00:00
ted.mielczarek@gmail.com 315fd78199 Implement CrashGeneration{Client,Server} for OOP dump generation on OS X, enable OOP dump generation in ExceptionHandler 
R=mark at http://breakpad.appspot.com/146001

git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@646 4c0a9323-5329-0410-9bdc-e9ce6186880e
 2010-08-13 20:18:58 +00:00
ted.mielczarek@gmail.com 26ff18d101 fix typo in previous commit 
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@642 4c0a9323-5329-0410-9bdc-e9ce6186880e
 2010-08-12 01:21:58 +00:00
ted.mielczarek@gmail.com 44af96cd2d Change exception_handler_test.cc to use Google Test 
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@641 4c0a9323-5329-0410-9bdc-e9ce6186880e
 2010-08-12 00:22:50 +00:00
ted.mielczarek 0fdc829d32 Fix HandleInvalidParameter/HandlePureVirtualCall to dynamically lookup the RtlCaptureContext symbol so the Windows exception handler will continue to work on Windows 2000. Patch by Jim Mathies <jmathies@mozilla.com> and Timothy Nikkel <tnikkel@gmail.com>. r=ted 
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@637 4c0a9323-5329-0410-9bdc-e9ce6186880e
 2010-08-02 13:56:29 +00:00
dmaclach 0b814c1d2b review: http://breakpad.appspot.com/139001 
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@636 4c0a9323-5329-0410-9bdc-e9ce6186880e
 2010-07-29 15:34:01 +00:00
dmaclach 1b8c24f337 review: http://breakpad.appspot.com/138001 
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@635 4c0a9323-5329-0410-9bdc-e9ce6186880e
 2010-07-29 05:25:43 +00:00
dmaclach 97918069d8 Review: http://breakpad.appspot.com/137001 
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@634 4c0a9323-5329-0410-9bdc-e9ce6186880e
 2010-07-28 19:06:30 +00:00
dmaclach 6e3869c19f Review: http://breakpad.appspot.com/136001 
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@633 4c0a9323-5329-0410-9bdc-e9ce6186880e
 2010-07-28 18:23:15 +00:00
dmaclach b5b8051a23 Review: http://breakpad.appspot.com/135001 
BUG: none
TEST: Build GoogleTalk



git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@632 4c0a9323-5329-0410-9bdc-e9ce6186880e
 2010-07-27 23:21:19 +00:00
stuart.morgan 23eabdedab Adding 11 languages to the crash uploader app on the Mac, contributed by the Camino localization teams 
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@630 4c0a9323-5329-0410-9bdc-e9ce6186880e
 2010-07-25 23:05:09 +00:00
mark@chromium.org 615d2c0d6d Separate the "hello" message from the parameter messages in 
Inspector::ReadMessages as was done before r627. The "hello" message contains
the parameter count and is referenced while the message reader loops through
parameter messages. Prior to r627, both messages were named |message|, which
was confusing, probably caused a compiler warning, and apparently provided the
motivation to share them. This caused the crash inspector to fail to properly
collect the parameters. The common failure mode (although others are possible)
was for the inspector to attempt tor read more parameter messages than were
available, resulting in an IPC timeout and inspector death. No crash report
would be written, and the application expecting its crash to be inspected
would time out waiting for a response from the inspector and then _exit. This
is effectively a failure to properly handle crashes.

The inner message is reintroduced, and named parameter_message for
disambiguation.

BUG=chromium:49821
TEST=Crashes catchable by the Mac Breakpad framework
Review URL: http://breakpad.appspot.com/123002

git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@628 4c0a9323-5329-0410-9bdc-e9ce6186880e
 2010-07-21 21:21:07 +00:00
dmaclach 4ac61acb3a Clean up build for 64 bit. 
Fix up some broken mac projects.
Consolidate project settings in xcconfig files.

http://breakpad.appspot.com/130001



git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@627 4c0a9323-5329-0410-9bdc-e9ce6186880e
 2010-07-19 20:43:49 +00:00
mark@chromium.org 8ffb12eb35 Convert files in .nib format to .xib format. 
Review URL: http://breakpad.appspot.com/122001

git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@609 4c0a9323-5329-0410-9bdc-e9ce6186880e
 2010-06-23 20:06:13 +00:00
nealsid 8e3c63b7f9 Remove LOG statements from linux utilities so there's no dependency on log library 
A=Zhurun
R=nealsid




git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@604 4c0a9323-5329-0410-9bdc-e9ce6186880e
 2010-05-27 19:37:24 +00:00
ted.mielczarek b0059c54da Issue 384 - UnregisterWait error handling is incorrect. Patch by Benjamin Smedberg <benjamin@smedbergs.us>, r=doshimun at http://breakpad.appspot.com/107001 
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@603 4c0a9323-5329-0410-9bdc-e9ce6186880e
 2010-05-19 13:40:59 +00:00
nealsid 0b54af4f91 Patch from Vitaly to remove synchronization and make exception handling code single-threaded 
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@602 4c0a9323-5329-0410-9bdc-e9ce6186880e
 2010-05-18 17:50:25 +00:00
hansl@google.com 7b106e34ba Changed two files end-line to make it work better with GYP. They were DOS (CR/LF), now they are UNIX (CR). 
It seems like the base gyp scripts on Windows were confused about this and didn't handle it well, while using gyp through gclient worked perfectly. I did not investigate the causes further.

Review URL: http://codereview.chromium.org/2128003

git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@599 4c0a9323-5329-0410-9bdc-e9ce6186880e
 2010-05-14 18:43:43 +00:00
hansl@google.com bcf885c807 Added a death test for the pure virtual function call. 
Added a test for the minidump generated by a pure virtual function call.
Changed the pure virtual function call handler so that it creates a minidump with Exception info and a stack.

Review URL: http://codereview.chromium.org/2050013

git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@597 4c0a9323-5329-0410-9bdc-e9ce6186880e
 2010-05-13 21:00:43 +00:00
hansl@google.com 8cf0a52bec Moved exception_handler_test to the more aptly named exception_handler_death_test. It doesn't test anything else than death and exit. 
Created the exception_handler_test that test the generation of dump and the dumps themselves.
Moved all dump analysis code from minidump to its right class DumpAnalysis. The class is used by both minidump_test and exception_handler_test. The tests are way simpler that way (ie. no handling of HANDLE).
minidump_test now uses the minidump_generator class instead of using Win32. It works well and pass all tests.
exception_handler now passes both the exception and assertion infos to the client to generate the dump. If one is NULL it's going to be handled correctly.
crash_generation_client can now RequestDump with both exception and assertion info.
minidump_generator returns both the mini and full dump string pointers, and output both (or either) depending on which was generated.
All original interfaces and method signature are still there, but call the new functions if possible.

Review URL: http://codereview.chromium.org/1994015

git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@596 4c0a9323-5329-0410-9bdc-e9ce6186880e
 2010-05-12 17:51:21 +00:00
nealsid 6bc523c618 Changes to fix build warnings on newer versions of GCC, and a fix to not try to open certain mapped files. 
A=ZhurunZ, Tristan Schmelcher
R=nealsid



git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@593 4c0a9323-5329-0410-9bdc-e9ce6186880e
 2010-05-10 20:35:54 +00:00
hansl@google.com 297b1e5a06 Copied minidump_test.cc from chrome_frame (see http://src.chromium.org/viewvc/chrome/trunk/src/chrome_frame/crash_reporting/minidump_test.cc). 
I had to remove the dependency from base (was using FilePath and ScopedHandle, replaced them by standard std::wstring and HANDLE). Also removed the logging and the main from the original files.

This will serve as a base for testing breakpad's dump generation. It is kept like this for easier tracking.

Review URL: http://codereview.chromium.org/1964006

git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@592 4c0a9323-5329-0410-9bdc-e9ce6186880e
 2010-05-05 21:38:18 +00:00
hansl@google.com ffedcd4945 Replacing solutions with gyp files. Moving tests for windows clients in unittests. 
Review URL: http://codereview.chromium.org/1687018

git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@581 4c0a9323-5329-0410-9bdc-e9ce6186880e
 2010-05-03 20:21:40 +00:00
nealsid eee511f1df Fix dependency on Visual C++ 9 introduced by revision 557. 
A=nealsid
r=mmentovai

http://breakpad.appspot.com/105001/



git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@580 4c0a9323-5329-0410-9bdc-e9ce6186880e
 2010-04-29 22:32:32 +00:00
ted.mielczarek 131c0c6a83 issue 372 - fix Mac OS X minidump generation code to handle x86-64 properly. r=mark at http://breakpad.appspot.com/103001 
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@578 4c0a9323-5329-0410-9bdc-e9ce6186880e
 2010-04-29 18:02:42 +00:00
nealsid d5b689e7af Patch from Zhurun to fix build breaks in gcc 4.4.1 
CR URL: http://breakpad.appspot.com/100001/show

A=Zhurun
R=nealsid


git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@573 4c0a9323-5329-0410-9bdc-e9ce6186880e
 2010-04-26 23:52:50 +00:00
jimblandy f3319839c4 [ Mistakenly committed older version of patch. This is the right one. ] 
Breakpad Linux client: Simplify VerifyStackReadWithMultipleThreads unit test.

As written, the VerifyStackReadWithMultipleThreads unit test makes
assumptions about the layout of thread_function's stack frame. As a result,
the test will fail when compiled with some compilers, or built with certain
optimization levels.

As an extension to C++, the GNU compilers allow you to request that a
variable be placed in a specific register. Using this, we can have
thread_function put the thread id in place where the test can find it
reliably.

a=jimblandy, r=nealsid


git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@559 4c0a9323-5329-0410-9bdc-e9ce6186880e
 2010-03-29 18:27:11 +00:00
jimblandy b68b800189 Breakpad Linux client: Simplify VerifyStackReadWithMultipleThreads unit test. 
As written, the VerifyStackReadWithMultipleThreads unit test makes
assumptions about the layout of thread_function's stack frame. As a result,
the test will fail when compiled with some compilers, or built with certain
optimization levels.

As an extension to C++, the GNU compilers allow you to request that a
variable be placed in a specific register. Using this, we can have
thread_function put the thread id in place where the test can find it
reliably.

a=jimblandy, r=nealsid


git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@558 4c0a9323-5329-0410-9bdc-e9ce6186880e
 2010-03-29 18:23:42 +00:00
siggi@chromium.org 18dd9d0104 Fix HandleInvalidParameter to provide a locally created exception record for the minidump. 
Having an exception of interest makes the resultant minidumps look just like
crash dumps, in that the processor can identify the "crashing" tread. 
This means such minidumps can be classified by the stack signature, in contrast to the current state of things, in which all such dumps get lumped on a single pile.


git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@557 4c0a9323-5329-0410-9bdc-e9ce6186880e
 2010-03-26 16:03:58 +00:00
nealsid de545c09d0 ARM support, with some build system changes to support x86-64, arm, and i386 in an autoconf style build in Linux. The O2 build for the unit tests is still broken but I'm checking this in to unblock people 
A=nealsid
R=ajwong, hannahtang, ted.mielczarek



git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@541 4c0a9323-5329-0410-9bdc-e9ce6186880e
 2010-03-02 00:39:48 +00:00
jimblandy 83e085b7a3 Breakpad: Update copyright notice years on all files changed in 2010. 
We've gotten mixed advice from the lawyery types about whether this
matters. But it's easy enough to do.

a=jimblandy, r=nealsid


git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@517 4c0a9323-5329-0410-9bdc-e9ce6186880e
 2010-02-09 17:08:56 +00:00
ted.mielczarek f480ba1169 Refactor Chrome's out-of-process Linux code into CrashGeneration{Server,Client} classes. Upstreamed from the Mozilla repository. Patch by Chris Jones <jones.chris.g@gmail.com> r=me at https://bugzilla.mozilla.org/show_bug.cgi?id=516759 
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@515 4c0a9323-5329-0410-9bdc-e9ce6186880e
 2010-02-05 18:21:31 +00:00
nealsid e7b2043dd2 Move file_id.cc from test_src to lib_src 
A=nealsid
R=ted.mielczarek



git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@483 4c0a9323-5329-0410-9bdc-e9ce6186880e
 2010-01-12 19:20:39 +00:00
stuart.morgan 910f68a5d4 Make Mac comment and email text field placeholders localizable. r=nealsid 
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@475 4c0a9323-5329-0410-9bdc-e9ce6186880e
 2010-01-01 00:21:18 +00:00
stuart.morgan 6f50ca38bb Add email mapping for Socorro. r=nealsid 
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@474 4c0a9323-5329-0410-9bdc-e9ce6186880e
 2010-01-01 00:17:33 +00:00
ted.mielczarek 9f211b4283 fix compilation on 64-bit, followup from issue 357 
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@463 4c0a9323-5329-0410-9bdc-e9ce6186880e
 2009-12-23 20:44:32 +00:00
ted.mielczarek 0a5fc5d663 Issue 357: New Linux file_id code doesn't persist across strip. r=agl,nealsid at http://breakpad.appspot.com/49008 
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@461 4c0a9323-5329-0410-9bdc-e9ce6186880e
 2009-12-23 17:09:27 +00:00
nealsid e4ffacd0d8 Fix build break for 64-bit compilation. 
A=Gregory Dardyk
R=nealsid



git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@452 4c0a9323-5329-0410-9bdc-e9ce6186880e
 2009-12-17 23:00:12 +00:00
brdevmn f7f9dfcab6 Added on-demand minidump generation for Linux, and a Linux test app. 
A=brdevmn
R=mochalatte

Code review: http://breakpad.appspot.com/48001/show



git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@451 4c0a9323-5329-0410-9bdc-e9ce6186880e
 2009-12-16 20:10:57 +00:00
jimblandy@gmail.com 4969cfc647 Issue 39002: Breakpad DWARF parser: Move DWARF parser to platform-independent directory. 
Move the DWARF parser, and the functioninfo.cc DWARF consumer, from
src/common/mac/dwarf to src/commmon/dwarf, so that it can be shared
between the Mac and Linux dumpers.

Fix up #include directives, multiple inclusion protection macros, and
Xcode build files.

a=jimblandy, r=nealsid


git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@446 4c0a9323-5329-0410-9bdc-e9ce6186880e
 2009-12-15 17:06:21 +00:00
ted.mielczarek 9dcc03f47d Mozilla bug 532713 - OS X client code doesn't decoded extended family ids in CPU info. Patch by Jeff Muizelaar <jmuizelaar@mozilla.com>, r=me 
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@440 4c0a9323-5329-0410-9bdc-e9ce6186880e
 2009-12-14 11:47:53 +00:00
nealsid bb618860df Fix some build warnings 
A=zhurunz
R=nealsid



git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@439 4c0a9323-5329-0410-9bdc-e9ce6186880e
 2009-12-10 19:15:44 +00:00
ted.mielczarek d95a88c3f1 remove trailing comma from enum definition to make it compile with -pedantic 
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@437 4c0a9323-5329-0410-9bdc-e9ce6186880e
 2009-12-03 20:58:31 +00:00
ted.mielczarek b1f271a4ec remove empty file, leftover from r384 
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@434 4c0a9323-5329-0410-9bdc-e9ce6186880e
 2009-12-03 13:59:55 +00:00
nealsid 096992fac7 Upstreaming several patches from Chrome: 
Build fix for systems where sys/user.h needs sys/types.h....
http://breakpad.appspot.com/40002
MDRawSystemInfo.processor_level refers to the CPU family, not the cpuid level..
http://breakpad.appspot.com/40003
Use MD_MODULE_SIZE in place of sizeof(MDRawModule).
http://breakpad.appspot.com/39003
Linux x64 compile fix.
http://breakpad.appspot.com/40004
Include linux_syscall_support.h to get definition of NT_PRXFPREG. This is
Chromium commit 23659.
http://breakpad.appspot.com/40005
Build breakpad / crash reporting on Linux 64-bit. This is Chromium commit
23396.
http://breakpad.appspot.com/40006
Fix #includes in a couple unit tests.
http://breakpad.appspot.com/41001
Clean up unused headers / files for Linux dump_syms.
http://breakpad.appspot.com/40002




git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@432 4c0a9323-5329-0410-9bdc-e9ce6186880e
 2009-12-01 21:35:52 +00:00
nealsid 2712a8c712 Forward exceptions in child processes to Apple's Crash Reporter 
http://breakpad.appspot.com/38001/show
R=mmentovai, jeremy
A=nealsid



git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@429 4c0a9323-5329-0410-9bdc-e9ce6186880e
 2009-11-18 13:59:01 +00:00
mmentovai ebebd0fcef Always export catch_exception_raise. 
Patch by Jeremy Moskovich <jeremy@chromium.org>

Code review URL: http://breakpad.appspot.com/37001


git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@428 4c0a9323-5329-0410-9bdc-e9ce6186880e
 2009-11-11 14:47:01 +00:00
mmentovai a3043159f3 Allow the Breakpad Mac framework to be built without -fexceptions. 
Review URL: http://breakpad.appspot.com/34003

git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@417 4c0a9323-5329-0410-9bdc-e9ce6186880e
 2009-10-15 22:42:54 +00:00
ted.mielczarek b73230385c Fix compilation of OS X handler on PPC with 10.5 SDK. r=nealsid at http://breakpad.appspot.com/30001 
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@404 4c0a9323-5329-0410-9bdc-e9ce6186880e
 2009-09-30 12:01:15 +00:00
nealsid 895d3d17ee New uploader for Linux with unit tests, and gflags/glog libraries 
http://breakpad.appspot.com/29004

A=nealsid
R=chris masone at chromium org



git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@403 4c0a9323-5329-0410-9bdc-e9ce6186880e
 2009-09-29 21:55:19 +00:00
mmentovai 4ee3ddcd33 Check RegisterWaitForSingleObject return in CrashGenerationServer::Start. 
Patch by Matt Mueller <mattm@chromium.org>

Review URL: http://codereview.chromium.org/244028


git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@402 4c0a9323-5329-0410-9bdc-e9ce6186880e
 2009-09-28 23:53:28 +00:00
nealsid ce9178abaa A better makefile for building the Linux client. 
http://breakpad.appspot.com/29003

A=nealsid
R=chris masone



git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@400 4c0a9323-5329-0410-9bdc-e9ce6186880e
 2009-09-18 20:43:35 +00:00
stuartmorgan ddd71b75f7 Fix text field resizing for 10.5+ SDK 
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@392 4c0a9323-5329-0410-9bdc-e9ce6186880e
 2009-08-28 22:08:34 +00:00
nealsid b0baafc4da Merge of Breakpad Chrome Linux fork 
A=agl, Lei Zhang
R=nealsid, agl



git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@384 4c0a9323-5329-0410-9bdc-e9ce6186880e
 2009-08-17 23:12:53 +00:00
nealsid f3f7df33de Fix an INVALIDATE_ITERATOR defect reported by Coverity. 
std::vector::erase() invalidates the iterator, so we need
to advance the iterator by using the return value of erase().

R=nealsid
A=wtc



git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@370 4c0a9323-5329-0410-9bdc-e9ce6186880e
 2009-07-30 22:53:09 +00:00
nealsid 7a5e320f84 Add tool dependencies to the 'Build All' target of Breakpad, so that everything can be built at once! 
R=stuart.morgan
A=nealsid



git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@366 4c0a9323-5329-0410-9bdc-e9ce6186880e
 2009-07-28 21:13:13 +00:00
nealsid 22734848ea Port fixes from internal Google Breakpad to SVN. 
A=preston, nealsid
R=Stuart, Preston



git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@360 4c0a9323-5329-0410-9bdc-e9ce6186880e
 2009-07-21 00:10:57 +00:00
nealsid f4f249e544 Integration test for Windows exception handler/minidump generation. 
R=hannah tang
A=nealsid



git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@358 4c0a9323-5329-0410-9bdc-e9ce6186880e
 2009-07-17 01:15:48 +00:00
nealsid 90a6505b03 The symbol files necessary for the processor to walk stacks on Linux that have __kernel_vsyscall at innermost frame. Special symbol files ar eneeded because EBP does not point to the frame when a thread is inside a system call. 
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@353 4c0a9323-5329-0410-9bdc-e9ce6186880e
 2009-06-25 21:36:39 +00:00
nealsid ae4d8370ee Fix for crashs generation test app to not deadlock 
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@352 4c0a9323-5329-0410-9bdc-e9ce6186880e
 2009-06-22 21:45:31 +00:00
ted.mielczarek 61e88c7ad7 issue 323 - OS X exception handler / minidump generator should set exception address correctly for EXC_BAD_ACCESS . r=nealsid at http://breakpad.appspot.com/15002 
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@350 4c0a9323-5329-0410-9bdc-e9ce6186880e
 2009-06-12 20:36:53 +00:00
nealsid c52715f32f Fix for generating dumps on-demand to set the requesting thread to the current thread 
R=stuartmorgan
A=nealsid



git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@349 4c0a9323-5329-0410-9bdc-e9ce6186880e
 2009-06-12 18:16:09 +00:00
nealsid 2eb356a68d Support custom URL parameters. Added unit tests for Breakpad. Added 
a way to specify server parameters in app plist file, as well.

R=stuartmorgan, jeremy
A=nealsid



git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@346 4c0a9323-5329-0410-9bdc-e9ce6186880e
 2009-06-03 21:51:33 +00:00
stuartmorgan 2a78191cab Show the reporter UI for Breakpad.framework regardless of whether continuing the crashed process succeeded (issue 319) 
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@341 4c0a9323-5329-0410-9bdc-e9ce6186880e
 2009-05-28 16:26:30 +00:00
nealsid 2a4698319a Fix up warnings when building http_upload.cc. Changed warning level to /W4, and also turned off deprecated 64-bit compatability warning flag(since some people are regularly building Breakpad in 64-bit mode, if we turn off this flag we get rid of a warning in 32 bit mode under VS2008) 
R=mmentovai
A=nealsid



git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@340 4c0a9323-5329-0410-9bdc-e9ce6186880e
 2009-05-27 16:54:23 +00:00
nealsid bec07f6972 Patch from Jeremy to have better error reporting, and workaround a Cocoa bug in different locales 
R=nealsid
A=jeremy


git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@339 4c0a9323-5329-0410-9bdc-e9ce6186880e
 2009-05-15 17:54:20 +00:00
stuartmorgan f9c5540ea6 Add a missing include (for gettimeofday) to Inspector.mm 
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@336 4c0a9323-5329-0410-9bdc-e9ce6186880e
 2009-04-30 01:11:36 +00:00
stuartmorgan 33e8fad61d Mac reporter improvements: 
- Made localization for UI entirely string-based, with flexible layout based on the size of the strings inserted.
- Made the request for an email address optional.
- Fixed a bug that would prevent comments or email from being collected if the text field were still focused.
- Refactored askUserPermissionToSend.


git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@335 4c0a9323-5329-0410-9bdc-e9ce6186880e
 2009-04-29 13:50:53 +00:00
stuart.morgan 73afbc7302 Mac framework fixes: Propagate server type from plist, and fix precedence of defaults vs. plist 
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@334 4c0a9323-5329-0410-9bdc-e9ce6186880e
 2009-04-29 13:27:16 +00:00
nealsid ed1f6e754a Code review issue 9002: Add paranoid logging to Inspector & Reporter 
A=jeremy moskovich
R=nealsid



git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@333 4c0a9323-5329-0410-9bdc-e9ce6186880e
 2009-04-23 07:56:16 +00:00
stuartmorgan e438d9cc0b Add a parameter to control the Mac reporter timeout. 
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@332 4c0a9323-5329-0410-9bdc-e9ce6186880e
 2009-04-22 13:22:08 +00:00
nealsid 1cb4ad73a6 Fix to support extensible parameter handling, and add process crashtime/uptime support 
R=stuart morgan
A=nealsid



git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@331 4c0a9323-5329-0410-9bdc-e9ce6186880e
 2009-04-22 06:25:21 +00:00
stuartmorgan 04a7df7acf Give the Mac reporter app a localized name of 'Crash Reporter' 
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@330 4c0a9323-5329-0410-9bdc-e9ce6186880e
 2009-04-22 03:10:03 +00:00
nealsid a0a0de39a8 Patch from Jeremy Moskovich to build with 10.5 SDK correctly. Also removed externals directory. 
A=jeremy
R=nealsid



git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@328 4c0a9323-5329-0410-9bdc-e9ce6186880e
 2009-04-21 08:29:46 +00:00
doshimun ea78675fbd AppVerifier leak test fix for Windows 7. 
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@327 4c0a9323-5329-0410-9bdc-e9ce6186880e
 2009-04-08 18:58:12 +00:00
stuart.morgan 841f5f7390 Sender tweaks; strip whitespace from server-returned ID, and change the title of the dialog a bit. 
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@326 4c0a9323-5329-0410-9bdc-e9ce6186880e
 2009-04-07 16:31:27 +00:00
stuart.morgan 9290b7062f Fix framework bundle ID and remove useless autogenerated InfoPlist.strings 
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@325 4c0a9323-5329-0410-9bdc-e9ce6186880e
 2009-04-06 20:17:09 +00:00
nealsid 77d851c356 Fix my build break due to misnamed constant 
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@324 4c0a9323-5329-0410-9bdc-e9ce6186880e
 2009-04-06 00:57:06 +00:00
nealsid a3d4c97336 Incorporate feedback from first Breakpad integration. 
This upload fixes five issues:

1) Preston's email was hardcoded in the xib :-(
2) Changed from xib to NIB to facilitate Tiger building
3) Changed the logs location to be user specifiable by BreakpadMinidumpLocation
key, or ~/Library/Breakpad/<BREAKPAD_PRODUCT> by default
4) Fixed GTM Defines problem in order to build on Tiger
5) Also set CFBundleIcon in the sender program correctly, and updated plist, and
renamed ReporterIcons to crash_report_sendER.ICNS.  However the rietveld upload
script doesn't appear to pick up renamed files correctly, so that file doesn't
show up in the patch upload.

Also various comments were updated for accuracy.



git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@323 4c0a9323-5329-0410-9bdc-e9ce6186880e
 2009-04-06 00:25:29 +00:00
nealsid 3ebdb1bd7a Open sourcing the Breakpad framework from Google. 
A=many, many people
R=nealsid, jeremy moskovich(from Chromium project)



git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@322 4c0a9323-5329-0410-9bdc-e9ce6186880e
 2009-04-01 03:18:49 +00:00
ted.mielczarek 0abe34ce5d issue 305 - breakpad Linux handler doesn't build with compiler built from latest GCC sources. Trivial patch by Jim Blandy 
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@321 4c0a9323-5329-0410-9bdc-e9ce6186880e
 2009-03-24 19:57:46 +00:00
nealsid 3366749ee7 Fix for issue 304: symupload needs to support timeout specifications(wininet can timeout when sending large symbol files). 
R=doshimun
W=nealsid



git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@319 4c0a9323-5329-0410-9bdc-e9ce6186880e
 2009-03-20 19:02:12 +00:00
nealsid 02c244f1b2 Fix for issue 242, plus a redo of how old exception handlers are tracked, and called. 
R=Craig.Schlenter, luly81



git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@315 4c0a9323-5329-0410-9bdc-e9ce6186880e
 2009-02-26 21:31:53 +00:00
doshimun c9944d96e8 Reinstnate the call to TerminateThread inside ExceptionHandler destructor and put 
the graceful code inside a #ifdef.

The problem is:
If ExceptionHandler is created and destroyed in DllMain, then the previous change to
remove the call to TerminateThread will lead to a deadlock. This is because inside
DllMain the loader lock is acquired, and the previous change waits for the handler
thread to exit in the destructor, that is with the loader lock acquired. But the
handler thread cannot finish until it gets the loader lock to call DllMain for
THREAD_DETACH.

With this change, we add conditional compilation so that clients that want to
avoid the call to terminate thread can do it by defining the appropriate preprocessor
variable.



git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@309 4c0a9323-5329-0410-9bdc-e9ce6186880e
 2009-01-20 20:45:28 +00:00
doshimun 104e4e0114 Fix an AppVerifier STOP in OOP server code. In the destructor of 
the OOP server, we need to wait for any pending I/O to be done.



git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@308 4c0a9323-5329-0410-9bdc-e9ce6186880e
 2009-01-16 22:37:48 +00:00
doshimun 308947d1ce Fix some typos in comments. 
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@307 4c0a9323-5329-0410-9bdc-e9ce6186880e
 2009-01-14 21:54:08 +00:00
doshimun a6f58a1ac8 Minor fixes to windows exception handler. 
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@306 4c0a9323-5329-0410-9bdc-e9ce6186880e
 2009-01-14 20:51:51 +00:00
nealsid 8b6271ce2c New test data to reflect Ted's changes that add function parameters to symbols when using DWARF 
R=ted.mielczarek



git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@305 4c0a9323-5329-0410-9bdc-e9ce6186880e
 2008-12-19 22:28:45 +00:00
mmentovai e5c401467b ExceptionHandler class is not handling initialization errors, such as the 
handler thread not being created.  Protect the exception handler against
failure to create semaphores and a thread handle.

Patch by Marc-André (MAD) Decoste, r=me

http://code.google.com/p/google-breakpad/issues/detail?id=285
http://codereview.chromium.org/13065


git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@300 4c0a9323-5329-0410-9bdc-e9ce6186880e
 2008-12-03 17:21:34 +00:00
nealsid e055207058 Added some sanity checks when iterating over threads in a crashed process. In same cases the ESP could be 0. In other cases it would be borked completely(i.e. pointing to an invalid range). 
R=Jeremy Moskovich



git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@295 4c0a9323-5329-0410-9bdc-e9ce6186880e
 2008-11-19 19:07:34 +00:00
nealsid 3a283d8f8b Undo suspend/resume feature since it was meant as a workaround to a bug in how we handled child process exceptions. Currently we don't return to the kernel when we take an exception from a child process, causing a hang. Now we return KERN_FAILURE, indicating to the kernel to move on to the host-level exception handler(usually Crash Reporter) 
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@292 4c0a9323-5329-0410-9bdc-e9ce6186880e
 2008-10-27 04:52:16 +00:00
nealsid 32441cc060 Issue 181: Add version info for Mac OS X modules. Found by iterating over load commands until I found LC_ID_DYLIB. Also modified crash_report to generate version number. Also added suspend/resume capability to exception handler, necessary because exception handling can behave strangely across fork() calls. Also added fix for filtering out functions with no line number information, and for filtering out some multiple inheritance glue the compiler generates. 
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@291 4c0a9323-5329-0410-9bdc-e9ce6186880e
 2008-10-22 05:08:50 +00:00
ted.mielczarek c5f46b2f4b Issue 276 - generate GUIDs ahead of time in Linux handler. r=Liu Li 
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@290 4c0a9323-5329-0410-9bdc-e9ce6186880e
 2008-10-14 11:21:34 +00:00
nealsid bb067bf185 Fix warning when converting int to bool 
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@288 4c0a9323-5329-0410-9bdc-e9ce6186880e
 2008-10-10 17:51:32 +00:00
ted.mielczarek 596e476fc2 fix a typo in the makefile, HANDLER_SRC->HANDLER_OBJ 
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@287 4c0a9323-5329-0410-9bdc-e9ce6186880e
 2008-10-10 15:48:06 +00:00
nealsid cb4aa6b804 Added DWARF support to Breakpad client. Thanks to Google for open sourcing their DWARF code! 
Modified dump_syms to detect dSYM bundles or a binary with DWARF data appropriately, and convert data from DWARF reader to dump_syms native structures

R=danny.berlin (original writer of DWARF code)



git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@286 4c0a9323-5329-0410-9bdc-e9ce6186880e
 2008-10-08 23:56:02 +00:00
mmentovai a509f4ec4b Generate Windows full memory dumps as a separate file. Patch by Huan Ren 
<huanr@google.com>.  r=me


git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@285 4c0a9323-5329-0410-9bdc-e9ce6186880e
 2008-09-16 18:50:02 +00:00
nealsid 85534c2eaf Now we provide our own implementation of the MIG function exc_server, as recommended by Apple. 
See 
http://groups.google.com/group/google-breakpad-dev/browse_thread/thread/8b363b1f8a404714
For more information



git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@282 4c0a9323-5329-0410-9bdc-e9ce6186880e
 2008-07-11 17:39:52 +00:00
doshimun 2d7664e8d4 In the destructor of ClientInfo, currently the wait on the clent_crashed_event is 
unregistered after the handle is closed. MSDN clearly says that the behavior is
undefined in this case. See http://msdn.microsoft.com/en-us/library/ms685061(VS.85).aspx
 
This change contains the fix for that bug. See attched diff.



git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@281 4c0a9323-5329-0410-9bdc-e9ce6186880e
 2008-06-09 23:38:24 +00:00
doshimun 3a516e4177 Client process uptime is a very useful metric for crashes. Instead of each client process having to keep track of uptime and report it whenever a crash happens, integrate this feature into breakpad OOP code so that all clients get it for free. 
I tested this using the test app I have to test OOP stuff.



git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@280 4c0a9323-5329-0410-9bdc-e9ce6186880e
 2008-06-06 21:41:32 +00:00
doshimun cc6cd1ff37 Fix the following bug: 
The sender updates the checkpoint file even when the report is not
successfully sent.



git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@278 4c0a9323-5329-0410-9bdc-e9ce6186880e
 2008-06-05 20:59:35 +00:00
nealsid d55398a492 Filter out duplicates from the image list when creating a minidump. See issue 266 for more details. 
Reviewer = mmentovai



git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@277 4c0a9323-5329-0410-9bdc-e9ce6186880e
 2008-06-04 22:57:09 +00:00
doshimun f6b3e16ef8 Set the dump thread id and the requesting thread id properties of MDRawBreakpadInfo 
only in case of in-process dump generation; otherwise the dump processing code of
breakpad doesn't identify the crashing thread properly.

I am checking this in to-be-reviewed since it is needed urgently in one of the
products at Google.



git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@276 4c0a9323-5329-0410-9bdc-e9ce6186880e
 2008-05-31 19:23:20 +00:00
doshimun 72bafd378d Microsoft broke PROCESS_ALL_ACCESS when we build with WINVER=0x600. See http://nsylvain.blogspot.com/2008/01/winverwin32winnt-mayhem.html for 
details (second half of the post).

Changing PROCESS_ALL_ACCESS to GENERIC_ALL in ClientInfo class when
opening the client process handle on the OOP server side.

A minor change to pipe name in the test app also.



git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@274 4c0a9323-5329-0410-9bdc-e9ce6186880e
 2008-05-15 04:12:34 +00:00
nealsid d318f9efee Fix to stop unit tests from being compiled & run for non-native architectures 
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@272 4c0a9323-5329-0410-9bdc-e9ce6186880e
 2008-05-08 23:15:00 +00:00
doshimun 7ab126ecdd Replace the user of wcscpy_s with safe_wcscpy in common/windows/string_utils-inl.h to 
make the code compatible for teams that still use VS 2003 to build.

Fix a bug in client ClientInfo class that returned CustomClientInfo struct containing
a pointer in the client process address space instead of pointer to in-process data
structure.



git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@271 4c0a9323-5329-0410-9bdc-e9ce6186880e
 2008-05-08 18:15:07 +00:00
doshimun 8602aa71ec Some style guide compliance changes and changed the prototype of the method to get custom client info in ClientInfo class. 
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@270 4c0a9323-5329-0410-9bdc-e9ce6186880e
 2008-05-07 21:54:12 +00:00
nealsid c2bdaa613c Bug fix for issue 263: mach_vm_region_recurse calls have invalid parameter specified, which succeeds on Leopard but fails on Tiger 
Reviewer: Chris Rogers(ladderbreaker)


git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@269 4c0a9323-5329-0410-9bdc-e9ce6186880e
 2008-05-07 21:15:12 +00:00
doshimun 3d4dc1f201 Add a convenience method to CustomClientInfo struct to set both name and value in one call. 
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@268 4c0a9323-5329-0410-9bdc-e9ce6186880e
 2008-05-05 21:03:51 +00:00
doshimun 0ded3d718f Add a way for the client apps to specify custom information in case of out-of-process 
scenarios that the OOP server can use in whatever way it wants to.

Fix a bug in CrashGenerationserver where CreateNamedPipe failure was not checked correctly.

TODO in near future: Add a custom stream to minidump files for the custom information.



git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@267 4c0a9323-5329-0410-9bdc-e9ce6186880e
 2008-05-05 20:03:56 +00:00
nealsid 47df365bf8 Issue 261/262: 64-bit bug fix when iterating through load commands of a 64-bit binary, and added new test case for ReadImageInfoForTask 
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@266 4c0a9323-5329-0410-9bdc-e9ce6186880e
 2008-05-05 18:20:04 +00:00
nealsid d6f0f92de3 Style changes 
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@265 4c0a9323-5329-0410-9bdc-e9ce6186880e
 2008-04-30 00:56:17 +00:00
nealsid d906d0f7c9 Updated code to be compliant with style guidelines 
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@264 4c0a9323-5329-0410-9bdc-e9ce6186880e
 2008-04-29 23:49:39 +00:00
nealsid 4c39c138fe Issue 258: Added test cases for ReadTaskMemory, reorganized project file, renamed filenames inside comments 
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@263 4c0a9323-5329-0410-9bdc-e9ce6186880e
 2008-04-25 00:37:19 +00:00
doshimun 9033edcd7b Add one more parameter to the ClientDumpRequestCallback in crash generation server 
to pass in the path of the dump file if the dump was generated successfully.



git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@262 4c0a9323-5329-0410-9bdc-e9ce6186880e
 2008-04-17 21:21:48 +00:00
nealsid 9609db8173 Fix a bug in start address calculation 
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@261 4c0a9323-5329-0410-9bdc-e9ce6186880e
 2008-04-17 04:15:30 +00:00
nealsid 5da03791a7 As part of resolving issue 256 I'd like to check in some unit 
tests(ok, just one) for the private copy of nlist that I checked in
last week, plus lay some of the ground work for collecting code
coverage numbers.  Both of these are accomplished by leveraging the
built-in facilities of Xcode & Developer Tools(namely, CPlusTest and
gcov integration; however, eventually I will also add a way to get
lcov results from the gcov results).  I also:

 - renamed breakpad_nlist_64.c to breakpad_nlist_64.cc to be more
consistent(even though it's not C++ code it still only gets called by
C++ code so I don't have to deal with extern "C" constructs).
 - I created a new target (minidump_tests) that has a "Coverage"
configuration with the appropriate GCC flags turned on.  It is only
compiled in 64-bit configurations and has 10.5 as a minimum
deployment target as well as uses the 10.5 SDK.


git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@260 4c0a9323-5329-0410-9bdc-e9ce6186880e
 2008-04-15 23:09:30 +00:00
nealsid b0d807666f Issue 254: The problem is that nlist() is compiled out of libc in 
64-bit builds of Leopard.  I ported the code over myself and will
check it into the Breakpad tree until we decide there's a better
longer-term solution.  If you want to diff the changes, the Apple
source is in libc/gen/nlist.c(I used 498 from 10.5.2).



git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@259 4c0a9323-5329-0410-9bdc-e9ce6186880e
 2008-04-12 01:16:18 +00:00
doshimun 35c34d6bb9 Add a parameter to CrashGenerationServer to let the callers set the 
security attributes on the pipe. This is useful when the process
hosting the crash server wants to let processes from other users to
connect to it and generate dumps for them.



git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@258 4c0a9323-5329-0410-9bdc-e9ce6186880e
 2008-04-12 00:00:34 +00:00
doshimun 05ec557277 Some cosmetic/style changes to conform to style guidelines. This time 
I waited for the style reviewer to approve all my code so hopefully there
should be no more style related check-ins.



git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@256 4c0a9323-5329-0410-9bdc-e9ce6186880e
 2008-04-08 19:03:57 +00:00
mmentovai eeca9921c5 Fix newlines (#253). rs=ted.mielczarek 
http://groups.google.com/group/google-breakpad-dev/browse_thread/thread/7e62a299ce3fa222


git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@255 4c0a9323-5329-0410-9bdc-e9ce6186880e
 2008-04-07 21:50:57 +00:00
nealsid 867df1c652 Issue 246: Dynamic_images.* needs to be 64-bit ready. Created types that are typedefed to the appropriate types depending on 32/64-bit compilation and modified dynamic_images to use these new types. Tested 32-bit minidump-generation. Also did some code cleanup along the way. Removed all blank lines that had spaces. 
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@253 4c0a9323-5329-0410-9bdc-e9ce6186880e
 2008-04-04 21:35:41 +00:00
doshimun fc816a3b3a Minor style changes to comply with Google style guidelines. 
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@252 4c0a9323-5329-0410-9bdc-e9ce6186880e
 2008-04-03 21:46:58 +00:00
ted.mielczarek dd2ff4a21c issue 223 - Fixes for SOlaris handler during integration with Firefox. patch by Alfred Peng, r=mento,me 
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@250 4c0a9323-5329-0410-9bdc-e9ce6186880e
 2008-03-18 16:10:10 +00:00
doshimun@gmail.com 5066fcdb42 TO BE REVIEWED. 
Have sent an email for code review already but this check-in is urgent
to fix potential build breaks.

It contains the following changes:
- Change project settings for exception_handler.vcproj so that it links in
  crash_generation.lib so that the applications using exception_handler.lib
  do not have to link to crash_generation.lib. Make these changes for all 4
  build configurations.
- Change the test app project settings to not link to crash_generation.lib
  and only link to exception_handler.lib; again for all four configurations.

These changes help the applications that are currently linking to exception_handler.lib
in that they don't have to link to one more lib to get out-of-process dump generation
functionality. In fact, even if they do not use out-of-process dump generation functionality,
after those changes, the apps will need to link with crash_generation.lib anyway in order to
build correctly. This change will eliminate that need.



git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@248 4c0a9323-5329-0410-9bdc-e9ce6186880e
 2008-03-11 22:28:48 +00:00
doshimun@gmail.com a8b48f29dd This changelist contains the changes to the configuration of Visual Studio solution and project files that I 
added in my last check-in for out-of-process dump generation. My last check-in broke the breakpad_client.sln
build for non debug builds since for the new project that I added (crash_generation.vcproj) to that solution,
I always only changed project properties for debug build. In fact, I didn't have the static-crt build configurations
for the new project either. Similar problems existed for the test application I added, windows/test/crash_generation_app).
 
This changelist contains changes to 2 solution files, 2 vcproj files and 1 .cc file. The fixes to .cc file are to avoid
warnings on variables used only in debug modes (in asserts) when building in release modes.



git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@247 4c0a9323-5329-0410-9bdc-e9ce6186880e
 2008-03-10 22:37:07 +00:00
doshimun@gmail.com c79141e306 Overview: 
Implement out-of-process dump generation for Windows platform.

Details:
- Created a lib, crash_generation.lib, that implements the out-of-process dump generation protocol.
- The lib code is under client/windows/crash_generation folder and is organized in the following way:
	- CrashGenerationServer class (crash_generation_server.h/.cc) implements the server side of
	  the protocol.
	- CrashGenerationClient class (crash_generation_client.h/.cc) implements the client side of
	  the protocol.
	- MinidumpGenerator class (minidump_generator.h/.cc) serves as an abstractino for generating
	  dump files using Windows APIs, coming up with new file names by creating GUIDs, etc.
	- ProtocolMessage class (ipc_protocol.h) represents the message format between the client and server
	  for pipe IPC.
	- Server allows one client at a time on the pipe in the current implementation.
	- ReadMe.txt explains the state machine the server uses to serve clients.
- ExceptionHandler is modified and a new constructor is added that allows specifying the pipe name. If the
  pipe name is NULL, the behavior is backward compatible - in-process dump generation is done as before. If
  the pipe name is specified, out-of-process dump generation registration is attempted. If that fails, the
  behavior is again backward compatible.
- If out-of-process registration succeeds, all write dump requests, direct or indirect, are directed to
  crash server process that served the registration request. NOTE that the explicit dump requests made by
  calling the static method of ExceptionHandler are not directed to theserver.
- client/windows/tests/crash_generation_app implements a simple Win32 GUI application to help test the
  out-of-process dump generation client and server. Typical use of the app is to start one instance, click
  Server --> Start and then start the other instance. The other instance will register with the first
  instance automatically at start-up. Then the second instance can be used to request various typoes of
  dump requests by using options under the Client menu.




git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@244 4c0a9323-5329-0410-9bdc-e9ce6186880e
 2008-03-08 00:02:40 +00:00
ted.mielczarek 2c2ae28541 issue 238 - missing includes compiling with gcc 4.3. patch by taras glek, r=me 
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@240 4c0a9323-5329-0410-9bdc-e9ce6186880e
 2008-02-24 21:04:51 +00:00
mmentovai 469580e2df Remove dependency on ole32 on Windows (#132). Patch by Sorin Jianu <sorinj>, r=me. 
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@237 4c0a9323-5329-0410-9bdc-e9ce6186880e
 2008-01-28 20:02:01 +00:00
mmentovai f4021f0c68 Make Breakpad's debug-exception-ignoring configurable. r=Nicolas Sylvain 
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@224 4c0a9323-5329-0410-9bdc-e9ce6186880e
 2007-10-18 20:54:20 +00:00
mmentovai e47d3a6e36 Remove assertion for a variable that doesn't exist. Patch by Alfred Peng 
<alfred.peng>.  r=me.

http://groups.google.com/group/google-breakpad-dev/browse_thread/thread/e5738aed43450365


git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@223 4c0a9323-5329-0410-9bdc-e9ce6186880e
 2007-10-15 20:47:12 +00:00
mmentovai 56d93f4902 Make sure ENOENT is defined. Spotted by jfbastien <bourgeoisie>. 
http://groups.google.com/group/google-breakpad-discuss/browse_thread/thread/47f82fe37b7a46d8


git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@222 4c0a9323-5329-0410-9bdc-e9ce6186880e
 2007-10-10 21:15:10 +00:00
mmentovai d7d6c74a68 Breakpad rejects valid modules with a vmaddr of zero on Mac (#176). Patch 
by Benjamin Smedberg <bsmedberg>.  r=me


git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@220 4c0a9323-5329-0410-9bdc-e9ce6186880e
 2007-09-28 18:30:48 +00:00
mmentovai 657a6c4a96 Assertion in CrashReportSender (windows) when no checkpoint file is desired 
(#216).  Patch by Ben Turner <bent.mozilla>.  r=me.


git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@219 4c0a9323-5329-0410-9bdc-e9ce6186880e
 2007-09-28 18:24:13 +00:00
mmentovai 68004c84d6 Solaris version of symbol dumper (#207). Patch by Alfred Peng. r=me 
http://groups.google.com/group/google-breakpad-dev/browse_thread/thread/e4cbdbf7ddaf7f51


git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@218 4c0a9323-5329-0410-9bdc-e9ce6186880e
 2007-09-28 18:14:48 +00:00
mmentovai ea2bba9706 Add SPARC/Solaris support to client handler and processor (#201, 200). 
Patch by Michael shang <satisfy123>.  r=me, r=Alfred Peng.

http://groups.google.com/group/google-breakpad-discuss/browse_thread/thread/2fba07577f1fa35e


git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@215 4c0a9323-5329-0410-9bdc-e9ce6186880e
 2007-09-26 18:28:05 +00:00
ladderbreaker 30dfc3d392 Issue 208: Reviewer waylonis 
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@209 4c0a9323-5329-0410-9bdc-e9ce6186880e
 2007-09-19 20:15:21 +00:00
ladderbreaker 649967cfd2 Issue 209: Reviewer waylonis 
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@208 4c0a9323-5329-0410-9bdc-e9ce6186880e
 2007-09-19 20:14:21 +00:00
ladderbreaker d792274003 Issue203 : reviewed by Waylonis 
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@206 4c0a9323-5329-0410-9bdc-e9ce6186880e
 2007-08-29 21:28:46 +00:00
ladderbreaker 69d242245a Issue 202: reviewed by Waylonis 
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@205 4c0a9323-5329-0410-9bdc-e9ce6186880e
 2007-08-27 19:46:32 +00:00
mmentovai 6a3f87982d Add accessor for ExceptionHandler::requesting_thread_id_ (#198). Patch by Lucas Eckels. r=me 
http://groups.google.com/group/google-breakpad-dev/browse_thread/thread/37da2dd8c14659c3


git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@203 4c0a9323-5329-0410-9bdc-e9ce6186880e
 2007-08-17 19:42:18 +00:00
ladderbreaker 70c7438bff Issue 197: reviewed by Waylonis 
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@202 4c0a9323-5329-0410-9bdc-e9ce6186880e
 2007-08-16 20:22:37 +00:00
mmentovai 9abfe3d0a5 Solaris port of minidump generator. Port by Alfred Peng. r=me 
http://groups.google.com/group/google-breakpad-dev/browse_thread/thread/7d8945578e3dac3


git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@198 4c0a9323-5329-0410-9bdc-e9ce6186880e
 2007-08-07 21:16:45 +00:00
ted.mielczarek b62d01462c Issue 175 - fix permissions on dump file in MinidumpFileWriter. r=mento 
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@197 4c0a9323-5329-0410-9bdc-e9ce6186880e
 2007-07-05 22:13:02 +00:00
ladderbreaker 43a81daaba issue 194: reviewed by waylonis 
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@195 4c0a9323-5329-0410-9bdc-e9ce6186880e
 2007-07-03 00:09:14 +00:00
mmentovai 3c07b28119 These should be int to allow them to be ORed together. Ted, please review. 
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@194 4c0a9323-5329-0410-9bdc-e9ce6186880e
 2007-07-02 20:41:30 +00:00
mmentovai 6a844b1d85 Allow finer control over installed handler types (#193). r=ted.mielczarek 
http://groups.google.com/group/google-breakpad-dev/browse_thread/thread/992a1bb09dc58a32


git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@193 4c0a9323-5329-0410-9bdc-e9ce6186880e
 2007-07-02 19:41:05 +00:00
ted.mielczarek 1260067e42 Issue 190 - 32 bit build fails on a 64 bit Linux system. Patch by wgianopoulos, r=me 
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@192 4c0a9323-5329-0410-9bdc-e9ce6186880e
 2007-07-02 18:13:33 +00:00
mmentovai fb6be7cf42 Add an API to pass exception information into the handler (#192). 
r=ted.mielczarek

http://groups.google.com/group/google-breakpad-dev/browse_thread/thread/42e9ee1a636bca8b


git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@191 4c0a9323-5329-0410-9bdc-e9ce6186880e
 2007-07-02 15:36:56 +00:00
ted.mielczarek 21d58c7281 Issue 182: linux handler doesn't have sigcontext if called from a previous signal handler. r=mento / Liu Li 
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@188 4c0a9323-5329-0410-9bdc-e9ce6186880e
 2007-06-11 16:01:46 +00:00
ted.mielczarek f68536ae50 Issue 169 - Fill in CPU vendor id in MDRawSystemInfo in Linux minidump_generator. r=Liu Li 
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@185 4c0a9323-5329-0410-9bdc-e9ce6186880e
 2007-05-31 20:28:43 +00:00
mmentovai 2e0e2234b9 Allow building with -pedantic (#186). r=ted.mielczarek 
http://groups.google.com/group/google-breakpad-dev/browse_thread/thread/6aa39d7f0ffa3c42


git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@183 4c0a9323-5329-0410-9bdc-e9ce6186880e
 2007-05-31 19:44:52 +00:00
ladderbreaker 026b28ec40 issue 167: reviewed by Benjamin Smedberg 
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@174 4c0a9323-5329-0410-9bdc-e9ce6186880e
 2007-05-22 00:25:38 +00:00
bryner 08c8c4ddcf Add an optional per-day limit to the number of crash reports sent. The state 
is maintained in an app-specified checkpoint file.  (#174, r=mmentovai)



git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@171 4c0a9323-5329-0410-9bdc-e9ce6186880e
 2007-05-21 18:32:02 +00:00
waylonis 32d4064736 - Add const keyword / casting to supress more stringient compiler warnings 
- Move DynamicImage::Print() from dynamic_images.h to dynamic_images.cc



git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@170 4c0a9323-5329-0410-9bdc-e9ce6186880e
 2007-05-19 00:41:39 +00:00
ted.mielczarek 822ead1319 Issue 140 - Fill in some more cpu information on OS X x86 dumps. r=mento 
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@167 4c0a9323-5329-0410-9bdc-e9ce6186880e
 2007-05-11 00:50:29 +00:00
ted.mielczarek b86e7ec7f0 Issue 162 - handle pure virtual function calls in VC++. r=mento 
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@166 4c0a9323-5329-0410-9bdc-e9ce6186880e
 2007-05-10 17:12:14 +00:00
ted.mielczarek 0e668e0783 Issue 164 - MACHINE_THREAD_STATE on older 10.4 versions. Patch by Dave Camp, r=Chris Rogers 
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@162 4c0a9323-5329-0410-9bdc-e9ce6186880e
 2007-05-08 19:04:14 +00:00
ladderbreaker 3d55532df2 Issue 161: reviewer Waylonis 
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@160 4c0a9323-5329-0410-9bdc-e9ce6186880e
 2007-05-07 19:48:02 +00:00
ted.mielczarek 0c70be6873 Issue 163, reviewer mento. Make dynamic_images.cc build on 10.3.9 SDK + update XCode project 
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@159 4c0a9323-5329-0410-9bdc-e9ce6186880e
 2007-05-07 19:32:44 +00:00
ted.mielczarek 9a3263a670 Issue 160 - Reviewer Chris Rogers 
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@156 4c0a9323-5329-0410-9bdc-e9ce6186880e
 2007-05-04 19:37:00 +00:00
ted.mielczarek 9be806efde missed header renames from Issue 152 
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@155 4c0a9323-5329-0410-9bdc-e9ce6186880e
 2007-05-04 12:41:02 +00:00
luly81 265726e56c Add md5 implementation into code base to get rid of 
openssl dependency.




git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@153 4c0a9323-5329-0410-9bdc-e9ce6186880e
 2007-05-03 20:45:27 +00:00
ted.mielczarek 255bbe93ed Issue 152 - Patch by Dave Camp, Reviewer Chris Rogers 
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@152 4c0a9323-5329-0410-9bdc-e9ce6186880e
 2007-05-03 20:12:41 +00:00
ladderbreaker de2fd15db9 Issue 159: reviewer Waylonis 
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@151 4c0a9323-5329-0410-9bdc-e9ce6186880e
 2007-05-02 21:05:49 +00:00
ladderbreaker c455a76c03 Issue 159: reviewer Waylonis 
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@150 4c0a9323-5329-0410-9bdc-e9ce6186880e
 2007-05-02 21:04:57 +00:00
mmentovai 30fc9ce1c0 Replace GB_WSU_SAFE_SWPRINTF_TERMINATE with inline code (#145 followup). 
r=bryner

http://groups.google.com/group/google-breakpad-dev/browse_thread/thread/f77da3d219cf9388


git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@140 4c0a9323-5329-0410-9bdc-e9ce6186880e
 2007-04-04 16:13:55 +00:00
mmentovai aec44489da vswprintf causes Purify to fail (#145). r=darin 
http://groups.google.com/group/google-breakpad-dev/browse_thread/thread/88e18d9fac4eee22


git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@135 4c0a9323-5329-0410-9bdc-e9ce6186880e
 2007-03-30 20:30:08 +00:00
luly81 3479e850c5 Fix issue 136. 
Block signals before writing minidumps.



git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@134 4c0a9323-5329-0410-9bdc-e9ce6186880e
 2007-03-29 01:32:39 +00:00
luly81 ab175ccc2b Fix bug of issue 135, now can dump symbols for dynamic libraries. 
Also some minor fixes to make it compile with more strict compiling options.



git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@133 4c0a9323-5329-0410-9bdc-e9ce6186880e
 2007-03-27 02:16:13 +00:00
luly81 bcd46f0079 Add Linux exception handler. 
Add Linux stab symbol dumper.
Add minidump & symbol uploader for Linux.



git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@126 4c0a9323-5329-0410-9bdc-e9ce6186880e
 2007-03-12 01:53:18 +00:00
ladderbreaker 530a7ad99e fixes for issue 128: reviewed by Waylonis 
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@124 4c0a9323-5329-0410-9bdc-e9ce6186880e
 2007-03-08 23:47:37 +00:00
bryner fce2508282 Fix exception handler build with MSVC versions prior to 2005. r=mmentovai. 
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@123 4c0a9323-5329-0410-9bdc-e9ce6186880e
 2007-03-05 21:13:23 +00:00
mmentovai e5dc60822e Rename Airbag to Breakpad. 
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@122 4c0a9323-5329-0410-9bdc-e9ce6186880e
 2007-02-14 19:51:05 +00:00
mmentovai baff938211 Airbag windows client didn't trap VC8 parameter validation errors. Now it 
does.  (#120) r=bryner.

http://groups.google.com/group/airbag-dev/browse_thread/thread/3f21d0e379e32771


git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@120 4c0a9323-5329-0410-9bdc-e9ce6186880e
 2007-02-07 20:20:10 +00:00
waylonis 983264848d Fix bug with mach-o walker not properly walking universal binary (Issue #125) 
Fix exception handler so that it will properly forward exceptions (Issue #126)
r=mmentovai



git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@119 4c0a9323-5329-0410-9bdc-e9ce6186880e
 2007-02-07 18:57:09 +00:00
waylonis 600e56bc39 - Fixes the bug with a fork()'d child's exception being caught in the parent process 
- Only looks for EXC_MASK_BAD_ACCESS, EXC_MASK_BAD_INSTRUCTION, and EXC_MASK_ARITHMETIC exceptions
- Adds try/catch blocks around "new" for bad_alloc
- Uses map.find() rather than map[] notation so as not to create extraneous objects
- Creates the exception watching thread as detached

r=mmentovai



git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@117 4c0a9323-5329-0410-9bdc-e9ce6186880e
 2007-02-05 18:49:44 +00:00
waylonis d31c8b0292 Changes to support patch #108: 
- Calculate unique file id for mach-o files
- Add file id support to dump_syms and symupload tools
- Fix return values of tools to indicate success or failure
- Change dump_syms class to be Objective-C++



git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@109 4c0a9323-5329-0410-9bdc-e9ce6186880e
 2007-01-23 19:17:03 +00:00
mmentovai f614cb9845 Pass the exception record (EXCEPTION_POINTERS*) to callback functions from 
ExceptionHandler on Windows.  Patch by John Abd-El-Malek.  r=me

Interface change: post-dump and pre-dump (filter) callbacks now must accept
an additional EXCEPTION_POINTERS* argument.


git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@103 4c0a9323-5329-0410-9bdc-e9ce6186880e
 2007-01-12 16:54:10 +00:00
incrementalist d4e527b7ee Allows the caller of CrashReportSender::SendCrashReport() to determine that 
the server rejected a crash report, by changing the return value from a
boolean to a tri-state enum.

Fixes issue #101.  Reviewed by mmentovai.



git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@99 4c0a9323-5329-0410-9bdc-e9ce6186880e
 2007-01-03 23:14:46 +00:00
waylonis 5ac2b9a569 Add Mac exception handler and generator. Fixes issue #69. Reviewed by mmentovai. 
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@98 4c0a9323-5329-0410-9bdc-e9ce6186880e
 2006-12-20 17:41:55 +00:00
waylonis a2fa3dda54 Add better support for UTF character conversions. Fixes Issue 78. 
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@91 4c0a9323-5329-0410-9bdc-e9ce6186880e
 2006-12-16 01:01:19 +00:00
waylonis 8cc32d3bb8 Add unittest for minidump file writer. Fixes issue #85. 
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@90 4c0a9323-5329-0410-9bdc-e9ce6186880e
 2006-12-16 00:42:13 +00:00
mmentovai 65dbfcc15f Removing CRs from #81. Hey, how'd those get in there? 
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@82 4c0a9323-5329-0410-9bdc-e9ce6186880e
 2006-12-08 22:49:07 +00:00
incrementalist dd7c38baae This patch fixes Airbag issue #44. 
Summary of this patch:
* It adds a new wstring* parameter to the end of both
SendCrashReport() and HTTPUpload::SendRequest(), which can be NULL.
* If the request isn't successful, the result parameter isn't touched.
* It adds HTTPUpload::UTF8ToWide() to allow the response to be
returned as a wstring,
* It changes the return value of SendRequest (and by extension,
SendCrashReport) so that if the size of the response body isn't
exactly the same as the value given in the Content-Length header, the
return value is false (in addition to the previous semantics).
* It also updates symupload.cc to account for the new parameter in
SendRequest().



git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@81 4c0a9323-5329-0410-9bdc-e9ce6186880e
 2006-12-08 20:45:20 +00:00
mmentovai 283fd39248 Allow exception handler callbacks more flexibility (#81). r=bryner 
- Provide an optional filter callback that gets triggered before attempting
   to write a dump, to give client code a chance to refuse handling early
   in the process.
 - Allow exceptions that are unhandled by Airbag (due to filter callback or
   dump callback return value, or failure to write a dump) to be passed to the
   previous handler or to the system.
 - In order to pass exceptions unhandled by the topmost Airbag handler to
   lower handlers, fix up the stacking of ExceptionHandler objects, and give
   each ExceptionHandler object its own thread (like the Mac implementation)
   to avoid deadlock.
 - Provide a dump_path argument to callbacks, as requested by developers and
   already implemented in the Mac handler.
 - Avoid calling c_str in exception handler code (#90).

http://groups.google.com/group/airbag-dev/browse_thread/thread/4771825ced38a84c


git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@79 4c0a9323-5329-0410-9bdc-e9ce6186880e
 2006-12-07 20:46:54 +00:00
mmentovai ed61ae0bbd Don't use CRT in exception handler code (#86). r=bryner 
http://groups.google.com/group/airbag-dev/browse_thread/thread/f671277ebd6ea7fd


git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@73 4c0a9323-5329-0410-9bdc-e9ce6186880e
 2006-11-28 19:47:44 +00:00
waylonis 9e586c173e Move some inlined functions to .cc file. Add some assertions. 
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@66 4c0a9323-5329-0410-9bdc-e9ce6186880e
 2006-11-16 22:43:57 +00:00
waylonis ff480d4b4b Add minidump file writer. Tested on Mac, but should compile on POSIX systems. 
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@65 4c0a9323-5329-0410-9bdc-e9ce6186880e
 2006-11-16 21:52:18 +00:00
mmentovai 73cd14b4af Airbag client libraries should compile under MSVC .NET 2003/7.1 (#64). 
r=bryner

http://groups.google.com/group/airbag-dev/browse_thread/thread/b838faeb50f71818


git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@64 4c0a9323-5329-0410-9bdc-e9ce6186880e
 2006-11-15 22:24:42 +00:00
mmentovai 5ac32b6534 Minidumps should indicate which thread generated the dump and which requested 
dump generation (#57).  r=bryner

http://groups.google.com/group/airbag-dev/browse_thread/thread/f11758d171261184


git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@61 4c0a9323-5329-0410-9bdc-e9ce6186880e
 2006-11-06 20:54:19 +00:00
mmentovai b261019951 Windows exception handler does not survive stack overflows (#34). r=brian, 
thanks also to darin
 - All minidump writing is now done on a dedicated thread.  When a stack
   overflow exception occurs, the only work that needs to be done on the
   exception thread will easily fit within the guard page.

http://groups.google.com/group/airbag-dev/browse_thread/thread/3935e339d8354a75


git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@57 4c0a9323-5329-0410-9bdc-e9ce6186880e
 2006-10-31 16:49:38 +00:00
mmentovai 12a5245bfe Disable exception handling warnings in Windows client code (#38). 
Patch by Ted Mielczarek.  r=me

http://groups.google.com/group/airbag-dev/browse_thread/thread/133814673f75d5fa


git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@56 4c0a9323-5329-0410-9bdc-e9ce6186880e
 2006-10-27 19:47:21 +00:00
mmentovai 1bff57e589 Add set_dump_path method to ExceptionHandler (#37). Patch by Ted Mielczarek. 
r=me

http://groups.google.com/group/airbag-dev/browse_thread/thread/06167df948717f4d


git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@55 4c0a9323-5329-0410-9bdc-e9ce6186880e
 2006-10-27 16:10:55 +00:00
mmentovai 29401d2457 Support building with WIN32_LEAN_AND_MEAN (#60) 
- All Windows code now builds with WIN32_LEAN_AND_MEAN by default.
 - Header inclusion is adjusted as needed.
Remove use of UuidToString (#39)
 - Also breaks dependency on RpcStringFree and therefore rpcrt4.lib.
r=bryner

http://groups.google.com/group/airbag-dev/browse_thread/thread/30f844cfc7ccd37f


git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@51 4c0a9323-5329-0410-9bdc-e9ce6186880e
 2006-10-26 18:06:43 +00:00
bryner 7772046297 Update comments to reflect HTTPS support, r=mark. 
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@44 4c0a9323-5329-0410-9bdc-e9ce6186880e
 2006-10-23 17:50:59 +00:00
bryner 8b1645d8cd Implement a tool to upload symbols on Windows, given an exe or dll file with 
debugging info.  Refactor common code into HTTPUpload so that the multipart
POST request code can be shared with CrashReportSender.  #47


git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@39 4c0a9323-5329-0410-9bdc-e9ce6186880e
 2006-10-16 17:27:03 +00:00
bryner f140025664 Add static-CRT build configurations. Get rid of the largely redundant README, 
moving the linkage comments to the corresponding headers.



git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@37 4c0a9323-5329-0410-9bdc-e9ce6186880e
 2006-09-28 19:35:08 +00:00
bryner 1217c1f898 Initial version of Windows exception handler and crash report sender classes 
(#31). r=mmentovai.


git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@36 4c0a9323-5329-0410-9bdc-e9ce6186880e
 2006-09-27 01:00:32 +00:00