nealsid
895d3d17ee
New uploader for Linux with unit tests, and gflags/glog libraries
...
http://breakpad.appspot.com/29004
A=nealsid
R=chris masone at chromium org
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@403 4c0a9323-5329-0410-9bdc-e9ce6186880e
2009-09-29 21:55:19 +00:00
mmentovai
4ee3ddcd33
Check RegisterWaitForSingleObject return in CrashGenerationServer::Start.
...
Patch by Matt Mueller <mattm@chromium.org>
Review URL: http://codereview.chromium.org/244028
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@402 4c0a9323-5329-0410-9bdc-e9ce6186880e
2009-09-28 23:53:28 +00:00
nealsid
ce9178abaa
A better makefile for building the Linux client.
...
http://breakpad.appspot.com/29003
A=nealsid
R=chris masone
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@400 4c0a9323-5329-0410-9bdc-e9ce6186880e
2009-09-18 20:43:35 +00:00
ted.mielczarek
b2bc3bcc84
Issue 328 - should have constant for VC++ exceptions, and stringify in MinidumpProcessor::GetCrashReason
...
r=nealsid at http://breakpad.appspot.com/25001/show
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@394 4c0a9323-5329-0410-9bdc-e9ce6186880e
2009-09-04 20:00:33 +00:00
jimblandy@gmail.com
c426b3d98a
Breakpad: Don't use the deprecated __gnu_cxx::hash_map container.
...
Modern GNU compilers warn about the #inclusion of <ext/hash_map>; that
container is deprecated, and code should use <tr1/unordered_map>
instead. However, to stay within the boundaries of C++ '98, it's
probably fine just to use plain old std::map.
Breakpad uses hash_map in three cases:
o The DWARF reader's SectionMap type maps object file section names to
data. This map is consulted once per section kind per DWARF
compilation unit; it is not performance-critical.
o The Mac dump_syms tool uses it to map machine architectures to
section maps in Universal binaries. It's hard to imagine there
ever being more than two entries in such a map.
o The processor's BasicSourceLineResolver uses a hash_map to map file
numbers to file names. This is the map that will probably have the
most entries, but it's only accessed once per frame, after we've
found the frame's line entry.
a=jimblandy
r=nealsid
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@393 4c0a9323-5329-0410-9bdc-e9ce6186880e
2009-09-03 18:27:16 +00:00
stuartmorgan
ddd71b75f7
Fix text field resizing for 10.5+ SDK
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@392 4c0a9323-5329-0410-9bdc-e9ce6186880e
2009-08-28 22:08:34 +00:00
mmentovai
ebe77d7e3b
Provide a real std::string hash, not just a forward declaration for something
...
that doesn't exist.
TBR=nealsid
Code review URL: http://groups.google.com/group/google-breakpad-dev/browse_thread/thread/292f9ed79dfdbdde
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@391 4c0a9323-5329-0410-9bdc-e9ce6186880e
2009-08-20 19:29:41 +00:00
nealsid
b0baafc4da
Merge of Breakpad Chrome Linux fork
...
A=agl, Lei Zhang
R=nealsid, agl
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@384 4c0a9323-5329-0410-9bdc-e9ce6186880e
2009-08-17 23:12:53 +00:00
mmentovai
7c48629d49
Fix build errors with gcc 4.4. Patch by Silvius Rus <rus@google.com>.
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@383 4c0a9323-5329-0410-9bdc-e9ce6186880e
2009-08-14 18:46:43 +00:00
jimblandy@gmail.com
d4a212a099
Linux dumper: fix comments in src/common/linux/module.h
...
Fix some typos and references to member functions that didn't make the
final cut.
a=jimblandy
r=nealsid
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@381 4c0a9323-5329-0410-9bdc-e9ce6186880e
2009-08-07 22:11:32 +00:00
jimblandy@gmail.com
eab03fdb72
Linux dumper: Move the data structures representing the breakpad data into their own class.
...
src/linux/common/module.h defines a new class, google_breakpad::Module,
that can represent the contents of a breakpad symbol file. Module::Write
writes a well-formed symbol file to the given stream.
src/linux/common/dump_symbols.cc can now lose its symbol-file-writing
code, and change DumpStabsHandler to populate a Module object, rather
than the old SymbolInfo/SourceFileInfo/... collection of types.
The code to compute function and line sizes, even in the absence of
reliable size data in STABS, is moved into a new Finalize method of
DumpStabsHandler, which is responsible for completing the Module's
contents.
a=jimblandy
r=nealsid
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@380 4c0a9323-5329-0410-9bdc-e9ce6186880e
2009-08-07 19:28:45 +00:00
jimblandy@gmail.com
f7cc9ef6f5
Add files left behind by previous commit.
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@379 4c0a9323-5329-0410-9bdc-e9ce6186880e
2009-08-07 19:26:55 +00:00
jimblandy@gmail.com
54bc5cfa2d
Linux dumper: Move STABS parsing into its own class.
...
With this patch, dump_symbols.cc no longer knows about the details of
the STABS debugging format; that is handled by the StabsReader class.
dump_symbols.cc provides a subclass of StabsHandler that builds
dump_symbols' own representation of the data.
a=jimblandy
r=nealsid
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@378 4c0a9323-5329-0410-9bdc-e9ce6186880e
2009-08-07 19:24:32 +00:00
jimblandy@gmail.com
68c8481df6
Linux dumper: Make the 'name' field of FuncInfo a std::string instead of a char *.
...
Because the actual N_FUN strings in the .stabstr section contain type
information after the mangled name, representing this information
using a pointer into .stabstr, while efficient with memory, makes the
FuncInfo data structure STABS-specific: one must know the details of a
STABS N_FUN string's syntax to interpret FuncInfo::name. This patch
removes this STABS dependency from the data structure, and moves us
closer to having an appropriate structure for representing unified
STABS and DWARF data.
a=jimblandy
r=nealsid
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@375 4c0a9323-5329-0410-9bdc-e9ce6186880e
2009-08-05 00:57:48 +00:00
jimblandy@gmail.com
3c4de8e8a7
Linux dumper: Properly separate function names from STABS type data.
...
STABS strings for N_FUN entries contain a mangled function name,
followed by a colon, followed by type information. The type
information itself may contain colons; mangled names never contain
colons (they need to be legal assembly-language identifiers). So the
current code in src/common/linux/dump_symbols.cc:WriteOneFunction that
attempts to separate the mangled name from the STABS junk will
incorrectly include STABS junk in the name, causing demangling to
fail.
Applying the patch below results in changes like these in the symbol
file produced, where an unmangled name followed by STABS junk becomes
a properly demangled name:
## --- base/libxul.so.syms 2009-07-13 21:46:33.000000000 -0700
## +++ tip/libxul.so.syms 2009-07-13 21:51:04.000000000 -0700
## @@ -3907,7 +3907,7 @@
## FILE 3905 /home/jimb/mc/in/gfx/cairo/libpixman/src/pixman-region.c
## FILE 3906 combine.inc
## FILE 3907 /home/jimb/mc/in/gfx/cairo/libpixman/src/pixman-edge-imp.h
## -FUNC 19898c 54 0 _Z20NS_GetCaseConversionv:F(0,1201)=*(0,1202)=xsnsICaseConvers
## ion
## +FUNC 19898c 54 0 NS_GetCaseConversion()
## 19898c 12 54 1
## 19899e 9 56 1
## 1989a7 6 60 1
## @@ -214776,7 +214776,7 @@
## 3847c9 9 57 506
## 3847d2 13 58 506
## 3847e5 7 59 506
## -FUNC 387e89 27 0 _ZN20nsGenericHTMLElement11FromContentEP10nsIContent:F(0,8117)
## =*(0,8118)=xsnsGenericHTMLElement
## +FUNC 387e89 27 0 nsGenericHTMLElement::FromContent(nsIContent*)
## 387e89 7 80 2584
## 387e90 3 80 2584
## 387e93 e 82 2584
## @@ -250473,7 +250473,7 @@
## 3d0d88 7 82 548
## 3d0d8f 25 84 548
## 3d0db4 5 85 548
## -FUNC 3d0e0c 40 0 _ZL21GetEnclosingListFrameP8nsIFrame:f(0,7182)=*(0,7183)=xsnsL
## istControlFrame
## +FUNC 3d0e0c 40 0 GetEnclosingListFrame(nsIFrame*)
## 3d0e0c 5 146 549
## 3d0e11 3 722 2645
## 3d0e14 d 146 549
a=jimblandy
r=nealsid
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@374 4c0a9323-5329-0410-9bdc-e9ce6186880e
2009-08-05 00:56:29 +00:00
jimblandy@gmail.com
15117f9ae0
Linux dumper: Don't switch to wrong source file when starting new function.
...
In STABS, if one function's line number information contains an N_SOL
entry to switch to a new source file, then the next function's line
data should pick up in the same source file where the prior function
left off. However, the Linux dumper restarts each function in the
compilation unit's main source file. This patch fixes that, so that
the output attributes the lines in subsequent functions to the correct
source files.
a=jimblandy
r=nealsid
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@373 4c0a9323-5329-0410-9bdc-e9ce6186880e
2009-08-05 00:54:47 +00:00
jimblandy@gmail.com
f6c98159e2
Linux dumper: Delete non-functional stack parameter size computation.
...
Delete code to compute function stack parameter size. It never did anything.
a=jimblandy
r=nealsid
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@372 4c0a9323-5329-0410-9bdc-e9ce6186880e
2009-08-05 00:53:23 +00:00
jimblandy@gmail.com
133c66ca40
Linux dumper: Let LineInfo structures point directly to their SourceLineInfo structures
...
Let LineInfo structures point directly to their SourceLineInfo
structures, rather than holding the index of the file's name in the
.stabstr section in the early phases, and then later the holding
source_id of the file.
This is another step in the process of moving STABS-specific values
out of the types that represent the breakpad symbol data. When we're
done, the non-STABS structures will be something that we can populate
with both STABS and DWARF data --- or at least it will be more easily
replaced with such.
a=jimblandy
r=nealsid
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@371 4c0a9323-5329-0410-9bdc-e9ce6186880e
2009-08-05 00:51:15 +00:00
nealsid
f3f7df33de
Fix an INVALIDATE_ITERATOR defect reported by Coverity.
...
std::vector::erase() invalidates the iterator, so we need
to advance the iterator by using the return value of erase().
R=nealsid
A=wtc
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@370 4c0a9323-5329-0410-9bdc-e9ce6186880e
2009-07-30 22:53:09 +00:00
jimblandy@gmail.com
0d23e8c686
Linux dumper: Don't record file boundary addresses as null-name SourceFileInfoList entries.
...
STABS information introduces a compilation unit with an N_SO entry
whose address is the start address of the file and whose string is the
name of the compilation unit's main source file. However, STABS
entries can only hold one address, so STABS indicates the compilation
unit's ending address with an N_SO entry whose name is empty.
Currently, the dumper's data structures simply create SourceFileInfo
structures with empty names for these end-of-unit N_SO entries. We
want to remove STABS-specific characteristics from these structures so
that we can replace them with an input-format-independent structure.
This moves end-of-compilation-unit addresses out of the symbol table
structure, and into their own list of boundary addresses.
a=jimblandy
r=nealsid
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@369 4c0a9323-5329-0410-9bdc-e9ce6186880e
2009-07-30 17:54:40 +00:00
jimblandy@gmail.com
e0a2512369
Linux dumper: Use pointers to SourceFileInfo structures.
...
Use a list of pointers to SourceFileInfo structures, not a list of the
structures themselves. This is preparation for a subsequent patch
which makes the data structures less STABS-specific.
This patch introduces a memory leak. If an included file is
referenced only by line entries for functions that LoadFuncSymbols
elected to omit from the func_info list, then its SourceFileInfo
structure is leaked when we destroy the name_to_file map. This leak
is fixed in a subsequent patch by letting the map of files by name own
the file objects.
a=jimblandy
r=nealsid
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@368 4c0a9323-5329-0410-9bdc-e9ce6186880e
2009-07-30 17:39:42 +00:00
jimblandy@gmail.com
4a6e708ed6
Linux dumper: Use a sorted array of addresses in computing function and line sizes.
...
Replace the sorted lists of files and functions with an array of
boundary addresses. This replaces CompareAddress with the default
comparison, and SortByAddress and NextAddress with the stock STL sort
and upper_bound algorithms, losing ~50 lines of code.
a=jimblandy
r=nealsid
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@367 4c0a9323-5329-0410-9bdc-e9ce6186880e
2009-07-30 17:36:23 +00:00
nealsid
7a5e320f84
Add tool dependencies to the 'Build All' target of Breakpad, so that everything can be built at once!
...
R=stuart.morgan
A=nealsid
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@366 4c0a9323-5329-0410-9bdc-e9ce6186880e
2009-07-28 21:13:13 +00:00
jimblandy@gmail.com
0eb3c6e5e2
Linux dumper: Correctly find boundary address when computing line and function sizes.
...
In NextAddress, check both the file list and the function list for the
nearest boundary. Don't assume that, if we find any bounding entry in
the function list, that must be the nearest thing.
A=jimblandy
R=nealsid
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@365 4c0a9323-5329-0410-9bdc-e9ce6186880e
2009-07-27 21:33:25 +00:00
jimblandy@gmail.com
1147cc4920
The has_sol field of struct FuncInfo is unused. This patch removes it.
...
A=jimblandy
R=nealsid
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@364 4c0a9323-5329-0410-9bdc-e9ce6186880e
2009-07-27 21:32:31 +00:00
jimblandy@gmail.com
53cb8044fd
The 'no_next_addr_count' variable in ComputeSizeAndRVA shouldn't be static.
...
The current arrangement would produce needless warnings if
WriteSymbolFile were ever used twice in the same program invocation.
Even if it weren't wrong, it's unnecessary, and local non-const static
variables require extra care when reading to be sure of their effect.
A=jimblandy
R=nealsid
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@363 4c0a9323-5329-0410-9bdc-e9ce6186880e
2009-07-27 21:30:56 +00:00
jimblandy@gmail.com
722afebee0
Use a std::map instead of a linear search to look up files for line records.
...
With this patch, the time required to generate Breakpad symbols for
Firefox's libxul.so on a MacBook Pro 3,1 drops from 32s to 2s.
I verified that this patch had no effect on the output of dump_syms
when applied to firefox-bin and its libraries when built with -gstabs+.
A=jimblandy
R=nealsid
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@362 4c0a9323-5329-0410-9bdc-e9ce6186880e
2009-07-27 21:30:02 +00:00
jimblandy@gmail.com
515f92cd61
Remove warnings about uninitialized fields.
...
A=jimblandy
R=nealsid
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@361 4c0a9323-5329-0410-9bdc-e9ce6186880e
2009-07-27 21:28:57 +00:00
nealsid
22734848ea
Port fixes from internal Google Breakpad to SVN.
...
A=preston, nealsid
R=Stuart, Preston
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@360 4c0a9323-5329-0410-9bdc-e9ce6186880e
2009-07-21 00:10:57 +00:00
nealsid
23c364a2b4
Fix for http://breakpad.appspot.com/18009 - run dump_syms on both PPC & i386 machines correctly, and process STABS/DWARF information in the same binary
...
R=stuart morgan
A=nealsid
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@359 4c0a9323-5329-0410-9bdc-e9ce6186880e
2009-07-17 20:32:08 +00:00
nealsid
f4f249e544
Integration test for Windows exception handler/minidump generation.
...
R=hannah tang
A=nealsid
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@358 4c0a9323-5329-0410-9bdc-e9ce6186880e
2009-07-17 01:15:48 +00:00
nealsid
6e525cbfbb
Add stack-dumping logic to crash_report with -t switch
...
R=jeremy
A=nealsid
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@357 4c0a9323-5329-0410-9bdc-e9ce6186880e
2009-07-02 00:30:44 +00:00
nealsid
90a6505b03
The symbol files necessary for the processor to walk stacks on Linux that have __kernel_vsyscall at innermost frame. Special symbol files ar eneeded because EBP does not point to the frame when a thread is inside a system call.
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@353 4c0a9323-5329-0410-9bdc-e9ce6186880e
2009-06-25 21:36:39 +00:00
nealsid
ae4d8370ee
Fix for crashs generation test app to not deadlock
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@352 4c0a9323-5329-0410-9bdc-e9ce6186880e
2009-06-22 21:45:31 +00:00
nealsid
1d8cba25c7
Fix build break in crash_report caused by my checkin that moved minidump processing error codes to a different namespace
...
R=preston
A=nealsid
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@351 4c0a9323-5329-0410-9bdc-e9ce6186880e
2009-06-16 22:31:51 +00:00
ted.mielczarek
61e88c7ad7
issue 323 - OS X exception handler / minidump generator should set exception address correctly for EXC_BAD_ACCESS . r=nealsid at http://breakpad.appspot.com/15002
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@350 4c0a9323-5329-0410-9bdc-e9ce6186880e
2009-06-12 20:36:53 +00:00
nealsid
c52715f32f
Fix for generating dumps on-demand to set the requesting thread to the current thread
...
R=stuartmorgan
A=nealsid
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@349 4c0a9323-5329-0410-9bdc-e9ce6186880e
2009-06-12 18:16:09 +00:00
nealsid
dae47f0d16
Support overriding makefile variables, changed defaults compilation flags. This patch from Jim Blandy was Merged with a previous change from nealsid to force 32-bit compilation even on 64-bit machines.
...
A=jim blandy
R=nealsid
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@348 4c0a9323-5329-0410-9bdc-e9ce6186880e
2009-06-05 23:06:54 +00:00
nealsid
0eb52ff8cc
Use ctsdio streams for dump_syms for significant speedup. Also contains a makefile fix to build in 32-bit mode, even on 64-bit systems.
...
A=jim blandy
R=nealsid
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@347 4c0a9323-5329-0410-9bdc-e9ce6186880e
2009-06-05 22:40:28 +00:00
nealsid
2eb356a68d
Support custom URL parameters. Added unit tests for Breakpad. Added
...
a way to specify server parameters in app plist file, as well.
R=stuartmorgan, jeremy
A=nealsid
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@346 4c0a9323-5329-0410-9bdc-e9ce6186880e
2009-06-03 21:51:33 +00:00
nealsid
1a997295b6
Removed logging init macro from minidump_processor_unittest, since with the Google Test integration, logging is handled through it's facilities
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@345 4c0a9323-5329-0410-9bdc-e9ce6186880e
2009-05-29 20:49:04 +00:00
nealsid
b56cfa067a
Add more error information to minidump processing return code. Also added dependency on google test, and modified minidump processing unit tests to use google test
...
R=brdevmn
A=nealsid
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@343 4c0a9323-5329-0410-9bdc-e9ce6186880e
2009-05-29 00:53:02 +00:00
ted.mielczarek
aaecb48b3b
Fix minidump_stackwalk compilation on gcc 4.3. Patch by Jim Blandy
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@342 4c0a9323-5329-0410-9bdc-e9ce6186880e
2009-05-28 17:50:33 +00:00
stuartmorgan
2a78191cab
Show the reporter UI for Breakpad.framework regardless of whether continuing the crashed process succeeded (issue 319)
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@341 4c0a9323-5329-0410-9bdc-e9ce6186880e
2009-05-28 16:26:30 +00:00
nealsid
2a4698319a
Fix up warnings when building http_upload.cc. Changed warning level to /W4, and also turned off deprecated 64-bit compatability warning flag(since some people are regularly building Breakpad in 64-bit mode, if we turn off this flag we get rid of a warning in 32 bit mode under VS2008)
...
R=mmentovai
A=nealsid
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@340 4c0a9323-5329-0410-9bdc-e9ce6186880e
2009-05-27 16:54:23 +00:00
nealsid
bec07f6972
Patch from Jeremy to have better error reporting, and workaround a Cocoa bug in different locales
...
R=nealsid
A=jeremy
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@339 4c0a9323-5329-0410-9bdc-e9ce6186880e
2009-05-15 17:54:20 +00:00
nealsid
fc26f4a9b5
Fix memory leak in test case when calling into basic source line resolver.
...
R=brdevmn
A=nealsid
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@338 4c0a9323-5329-0410-9bdc-e9ce6186880e
2009-05-14 21:31:03 +00:00
nealsid
dad1acc2d0
Deleting obsolete file(when I added DWARF support I had to make this a .MM but I forgot to delete the old file)
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@337 4c0a9323-5329-0410-9bdc-e9ce6186880e
2009-05-12 17:19:59 +00:00
stuartmorgan
f9c5540ea6
Add a missing include (for gettimeofday) to Inspector.mm
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@336 4c0a9323-5329-0410-9bdc-e9ce6186880e
2009-04-30 01:11:36 +00:00
stuartmorgan
33e8fad61d
Mac reporter improvements:
...
- Made localization for UI entirely string-based, with flexible layout based on the size of the strings inserted.
- Made the request for an email address optional.
- Fixed a bug that would prevent comments or email from being collected if the text field were still focused.
- Refactored askUserPermissionToSend.
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@335 4c0a9323-5329-0410-9bdc-e9ce6186880e
2009-04-29 13:50:53 +00:00
stuart.morgan
73afbc7302
Mac framework fixes: Propagate server type from plist, and fix precedence of defaults vs. plist
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@334 4c0a9323-5329-0410-9bdc-e9ce6186880e
2009-04-29 13:27:16 +00:00
nealsid
ed1f6e754a
Code review issue 9002: Add paranoid logging to Inspector & Reporter
...
A=jeremy moskovich
R=nealsid
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@333 4c0a9323-5329-0410-9bdc-e9ce6186880e
2009-04-23 07:56:16 +00:00
stuartmorgan
e438d9cc0b
Add a parameter to control the Mac reporter timeout.
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@332 4c0a9323-5329-0410-9bdc-e9ce6186880e
2009-04-22 13:22:08 +00:00
nealsid
1cb4ad73a6
Fix to support extensible parameter handling, and add process crashtime/uptime support
...
R=stuart morgan
A=nealsid
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@331 4c0a9323-5329-0410-9bdc-e9ce6186880e
2009-04-22 06:25:21 +00:00
stuartmorgan
04a7df7acf
Give the Mac reporter app a localized name of 'Crash Reporter'
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@330 4c0a9323-5329-0410-9bdc-e9ce6186880e
2009-04-22 03:10:03 +00:00
nealsid
ad6543e4e7
Fix memory leak when using the basic source line resolver, plus the optimization to load using in-memory buffers. Moved from manually allocating/deallocating memory to using a scoped_array
...
A=nealsid
R=tiger feng
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@329 4c0a9323-5329-0410-9bdc-e9ce6186880e
2009-04-22 00:55:31 +00:00
nealsid
a0a0de39a8
Patch from Jeremy Moskovich to build with 10.5 SDK correctly. Also removed externals directory.
...
A=jeremy
R=nealsid
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@328 4c0a9323-5329-0410-9bdc-e9ce6186880e
2009-04-21 08:29:46 +00:00
doshimun
ea78675fbd
AppVerifier leak test fix for Windows 7.
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@327 4c0a9323-5329-0410-9bdc-e9ce6186880e
2009-04-08 18:58:12 +00:00
stuart.morgan
841f5f7390
Sender tweaks; strip whitespace from server-returned ID, and change the title of the dialog a bit.
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@326 4c0a9323-5329-0410-9bdc-e9ce6186880e
2009-04-07 16:31:27 +00:00
stuart.morgan
9290b7062f
Fix framework bundle ID and remove useless autogenerated InfoPlist.strings
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@325 4c0a9323-5329-0410-9bdc-e9ce6186880e
2009-04-06 20:17:09 +00:00
nealsid
77d851c356
Fix my build break due to misnamed constant
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@324 4c0a9323-5329-0410-9bdc-e9ce6186880e
2009-04-06 00:57:06 +00:00
nealsid
a3d4c97336
Incorporate feedback from first Breakpad integration.
...
This upload fixes five issues:
1) Preston's email was hardcoded in the xib :-(
2) Changed from xib to NIB to facilitate Tiger building
3) Changed the logs location to be user specifiable by BreakpadMinidumpLocation
key, or ~/Library/Breakpad/<BREAKPAD_PRODUCT> by default
4) Fixed GTM Defines problem in order to build on Tiger
5) Also set CFBundleIcon in the sender program correctly, and updated plist, and
renamed ReporterIcons to crash_report_sendER.ICNS. However the rietveld upload
script doesn't appear to pick up renamed files correctly, so that file doesn't
show up in the patch upload.
Also various comments were updated for accuracy.
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@323 4c0a9323-5329-0410-9bdc-e9ce6186880e
2009-04-06 00:25:29 +00:00
nealsid
3ebdb1bd7a
Open sourcing the Breakpad framework from Google.
...
A=many, many people
R=nealsid, jeremy moskovich(from Chromium project)
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@322 4c0a9323-5329-0410-9bdc-e9ce6186880e
2009-04-01 03:18:49 +00:00
ted.mielczarek
0abe34ce5d
issue 305 - breakpad Linux handler doesn't build with compiler built from latest GCC sources. Trivial patch by Jim Blandy
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@321 4c0a9323-5329-0410-9bdc-e9ce6186880e
2009-03-24 19:57:46 +00:00
nealsid
3366749ee7
Fix for issue 304: symupload needs to support timeout specifications(wininet can timeout when sending large symbol files).
...
R=doshimun
W=nealsid
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@319 4c0a9323-5329-0410-9bdc-e9ce6186880e
2009-03-20 19:02:12 +00:00
nealsid
2ad976ef0b
Fix for issues 296, 297. Various symbol supplier classes need to be updated with new overload('make check' was failing, as well as crash_report), and remove logging that was flooding output
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@318 4c0a9323-5329-0410-9bdc-e9ce6186880e
2009-02-27 23:59:40 +00:00
nealsid
02c244f1b2
Fix for issue 242, plus a redo of how old exception handlers are tracked, and called.
...
R=Craig.Schlenter, luly81
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@315 4c0a9323-5329-0410-9bdc-e9ce6186880e
2009-02-26 21:31:53 +00:00
nealsid
4af5fe0b59
Fix build breaks on Solaris using Sun Studio.
...
Written by Ginn Chen & Eagle.Lu@
R=nealsid (although I don't have a Solaris machine to build on, & these changes look localized to Sun-only builds)
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@314 4c0a9323-5329-0410-9bdc-e9ce6186880e
2009-02-23 09:28:29 +00:00
nealsid
e1a7efca7d
See https://bugzilla.mozilla.org/show_bug.cgi?id=397200
...
The method of calculating a binary ID using the LC_ID command isn't compatible with non-default build processes, most Mac consumers
use LC_UUID anyway but for those that don't, MD5 is a better choice
R=nealsid
W=Ted.Mielczarek
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@313 4c0a9323-5329-0410-9bdc-e9ce6186880e
2009-02-22 08:16:05 +00:00
nealsid
cadc8ddde9
Issue 294: mmap error checking is not correct.
...
R=Liu
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@312 4c0a9323-5329-0410-9bdc-e9ce6186880e
2009-02-22 01:31:43 +00:00
nealsid
0fd2f1ae21
Modify symbol supplier interface to support an overload that takes a symbol data buffer, to get around an extraneous read/write of symbol data
...
R=doshimun
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@311 4c0a9323-5329-0410-9bdc-e9ce6186880e
2009-02-19 21:26:20 +00:00
nealsid
a285652cba
Issue 275: patch to include list of loaded modules in crash_report output
...
Written by: jum@mac.com
R=nealsid
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@310 4c0a9323-5329-0410-9bdc-e9ce6186880e
2009-02-10 21:29:54 +00:00
doshimun
c9944d96e8
Reinstnate the call to TerminateThread inside ExceptionHandler destructor and put
...
the graceful code inside a #ifdef.
The problem is:
If ExceptionHandler is created and destroyed in DllMain, then the previous change to
remove the call to TerminateThread will lead to a deadlock. This is because inside
DllMain the loader lock is acquired, and the previous change waits for the handler
thread to exit in the destructor, that is with the loader lock acquired. But the
handler thread cannot finish until it gets the loader lock to call DllMain for
THREAD_DETACH.
With this change, we add conditional compilation so that clients that want to
avoid the call to terminate thread can do it by defining the appropriate preprocessor
variable.
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@309 4c0a9323-5329-0410-9bdc-e9ce6186880e
2009-01-20 20:45:28 +00:00
doshimun
104e4e0114
Fix an AppVerifier STOP in OOP server code. In the destructor of
...
the OOP server, we need to wait for any pending I/O to be done.
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@308 4c0a9323-5329-0410-9bdc-e9ce6186880e
2009-01-16 22:37:48 +00:00
doshimun
308947d1ce
Fix some typos in comments.
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@307 4c0a9323-5329-0410-9bdc-e9ce6186880e
2009-01-14 21:54:08 +00:00
doshimun
a6f58a1ac8
Minor fixes to windows exception handler.
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@306 4c0a9323-5329-0410-9bdc-e9ce6186880e
2009-01-14 20:51:51 +00:00
nealsid
8b6271ce2c
New test data to reflect Ted's changes that add function parameters to symbols when using DWARF
...
R=ted.mielczarek
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@305 4c0a9323-5329-0410-9bdc-e9ce6186880e
2008-12-19 22:28:45 +00:00
ted.mielczarek
3751b05354
Issue 283 - DWARF dumper doesn't handle DW_AT_specification. r=nealsid
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@303 4c0a9323-5329-0410-9bdc-e9ce6186880e
2008-12-08 13:12:45 +00:00
ted.mielczarek
d3441c2c96
Issue 284 - DWARF dumper doesn't output function names including arguments. r=nealsid
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@302 4c0a9323-5329-0410-9bdc-e9ce6186880e
2008-12-08 13:00:29 +00:00
ted.mielczarek
7837cb7236
issue 286 - clean up some demangling code in dump_syms.mm. r=chris rogers
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@301 4c0a9323-5329-0410-9bdc-e9ce6186880e
2008-12-03 18:23:09 +00:00
mmentovai
e5c401467b
ExceptionHandler class is not handling initialization errors, such as the
...
handler thread not being created. Protect the exception handler against
failure to create semaphores and a thread handle.
Patch by Marc-André (MAD) Decoste, r=me
http://code.google.com/p/google-breakpad/issues/detail?id=285
http://codereview.chromium.org/13065
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@300 4c0a9323-5329-0410-9bdc-e9ce6186880e
2008-12-03 17:21:34 +00:00
ted.mielczarek
af553e22cb
follow up for issue 281 - dump_syms fails to find dylib symbol file inside of a bundle. handle files without an extension properly
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@299 4c0a9323-5329-0410-9bdc-e9ce6186880e
2008-12-01 18:42:16 +00:00
ted.mielczarek
7b8eb04745
issue 281 - dump_syms fails to find dylib symbol file inside of a bundle. r=nealsid
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@298 4c0a9323-5329-0410-9bdc-e9ce6186880e
2008-12-01 17:05:43 +00:00
ted.mielczarek
5f27d9125c
Followup to address some review comments from Issue 259
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@297 4c0a9323-5329-0410-9bdc-e9ce6186880e
2008-11-25 13:41:41 +00:00
ted.mielczarek
324d84c2f6
Issue 259 - crash when generating large .sym files with dump_syms on Linux. Patch by login_ing@yahoo.com, r=Liu Li
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@296 4c0a9323-5329-0410-9bdc-e9ce6186880e
2008-11-24 20:47:37 +00:00
nealsid
e055207058
Added some sanity checks when iterating over threads in a crashed process. In same cases the ESP could be 0. In other cases it would be borked completely(i.e. pointing to an invalid range).
...
R=Jeremy Moskovich
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@295 4c0a9323-5329-0410-9bdc-e9ce6186880e
2008-11-19 19:07:34 +00:00
nealsid
c85fb043ed
Fix for dump_syms to ignore line number information for addresses that don't have an enclosing function
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@293 4c0a9323-5329-0410-9bdc-e9ce6186880e
2008-11-03 23:23:50 +00:00
nealsid
3a283d8f8b
Undo suspend/resume feature since it was meant as a workaround to a bug in how we handled child process exceptions. Currently we don't return to the kernel when we take an exception from a child process, causing a hang. Now we return KERN_FAILURE, indicating to the kernel to move on to the host-level exception handler(usually Crash Reporter)
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@292 4c0a9323-5329-0410-9bdc-e9ce6186880e
2008-10-27 04:52:16 +00:00
nealsid
32441cc060
Issue 181: Add version info for Mac OS X modules. Found by iterating over load commands until I found LC_ID_DYLIB. Also modified crash_report to generate version number. Also added suspend/resume capability to exception handler, necessary because exception handling can behave strangely across fork() calls. Also added fix for filtering out functions with no line number information, and for filtering out some multiple inheritance glue the compiler generates.
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@291 4c0a9323-5329-0410-9bdc-e9ce6186880e
2008-10-22 05:08:50 +00:00
ted.mielczarek
c5f46b2f4b
Issue 276 - generate GUIDs ahead of time in Linux handler. r=Liu Li
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@290 4c0a9323-5329-0410-9bdc-e9ce6186880e
2008-10-14 11:21:34 +00:00
nealsid
1de70760db
Fix for DWARF processing when inline functions were encountered. Inline functions were part of the debugging information as sequential in the PC range of the function but the source file was where the function was written(as you might expect). However the old dump_syms code, once it switched files as it was iterating over a range of addresses, never switched back, causing inline functions to cause all file numbers for addresses after the PC of the inline function to be wrong
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@289 4c0a9323-5329-0410-9bdc-e9ce6186880e
2008-10-14 01:24:02 +00:00
nealsid
bb067bf185
Fix warning when converting int to bool
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@288 4c0a9323-5329-0410-9bdc-e9ce6186880e
2008-10-10 17:51:32 +00:00
ted.mielczarek
596e476fc2
fix a typo in the makefile, HANDLER_SRC->HANDLER_OBJ
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@287 4c0a9323-5329-0410-9bdc-e9ce6186880e
2008-10-10 15:48:06 +00:00
nealsid
cb4aa6b804
Added DWARF support to Breakpad client. Thanks to Google for open sourcing their DWARF code!
...
Modified dump_syms to detect dSYM bundles or a binary with DWARF data appropriately, and convert data from DWARF reader to dump_syms native structures
R=danny.berlin (original writer of DWARF code)
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@286 4c0a9323-5329-0410-9bdc-e9ce6186880e
2008-10-08 23:56:02 +00:00
mmentovai
a509f4ec4b
Generate Windows full memory dumps as a separate file. Patch by Huan Ren
...
<huanr@google.com>. r=me
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@285 4c0a9323-5329-0410-9bdc-e9ce6186880e
2008-09-16 18:50:02 +00:00
mmentovai
9fcf4db315
Include what you use: include <algorithm> and <string.h> as needed. Patch by
...
Robert Henry. r=me
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@284 4c0a9323-5329-0410-9bdc-e9ce6186880e
2008-09-15 18:16:49 +00:00
doshimun
11dc028694
Log a failure message in case of LOCATE_NOT_FOUND error.
...
Without this change, no error is logged in this case.
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@283 4c0a9323-5329-0410-9bdc-e9ce6186880e
2008-07-30 19:39:48 +00:00
nealsid
85534c2eaf
Now we provide our own implementation of the MIG function exc_server, as recommended by Apple.
...
See
http://groups.google.com/group/google-breakpad-dev/browse_thread/thread/8b363b1f8a404714
For more information
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@282 4c0a9323-5329-0410-9bdc-e9ce6186880e
2008-07-11 17:39:52 +00:00
doshimun
2d7664e8d4
In the destructor of ClientInfo, currently the wait on the clent_crashed_event is
...
unregistered after the handle is closed. MSDN clearly says that the behavior is
undefined in this case. See http://msdn.microsoft.com/en-us/library/ms685061(VS.85).aspx
This change contains the fix for that bug. See attched diff.
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@281 4c0a9323-5329-0410-9bdc-e9ce6186880e
2008-06-09 23:38:24 +00:00
doshimun
3a516e4177
Client process uptime is a very useful metric for crashes. Instead of each client process having to keep track of uptime and report it whenever a crash happens, integrate this feature into breakpad OOP code so that all clients get it for free.
...
I tested this using the test app I have to test OOP stuff.
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@280 4c0a9323-5329-0410-9bdc-e9ce6186880e
2008-06-06 21:41:32 +00:00
nealsid
38bc56cfa8
Modified symupload to correctly handle spaces in module names when processing symbol file
...
Reviewer=mmentovai
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@279 4c0a9323-5329-0410-9bdc-e9ce6186880e
2008-06-05 21:20:53 +00:00
doshimun
cc6cd1ff37
Fix the following bug:
...
The sender updates the checkpoint file even when the report is not
successfully sent.
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@278 4c0a9323-5329-0410-9bdc-e9ce6186880e
2008-06-05 20:59:35 +00:00
nealsid
d55398a492
Filter out duplicates from the image list when creating a minidump. See issue 266 for more details.
...
Reviewer = mmentovai
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@277 4c0a9323-5329-0410-9bdc-e9ce6186880e
2008-06-04 22:57:09 +00:00
doshimun
f6b3e16ef8
Set the dump thread id and the requesting thread id properties of MDRawBreakpadInfo
...
only in case of in-process dump generation; otherwise the dump processing code of
breakpad doesn't identify the crashing thread properly.
I am checking this in to-be-reviewed since it is needed urgently in one of the
products at Google.
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@276 4c0a9323-5329-0410-9bdc-e9ce6186880e
2008-05-31 19:23:20 +00:00
nealsid
b91bb881d5
Fix to ignore source files that have a text address of 0 in their stabs entry
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@275 4c0a9323-5329-0410-9bdc-e9ce6186880e
2008-05-19 17:27:40 +00:00
doshimun
72bafd378d
Microsoft broke PROCESS_ALL_ACCESS when we build with WINVER=0x600. See http://nsylvain.blogspot.com/2008/01/winverwin32winnt-mayhem.html for
...
details (second half of the post).
Changing PROCESS_ALL_ACCESS to GENERIC_ALL in ClientInfo class when
opening the client process handle on the OOP server side.
A minor change to pipe name in the test app also.
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@274 4c0a9323-5329-0410-9bdc-e9ce6186880e
2008-05-15 04:12:34 +00:00
mmentovai
808ff9bc70
64-bit processor can't handle 32-bit ppc minidumps due to struct padding
...
differences on 64- and 32-bit CPUs. Force 32-bit alignment rules for
32-bit ppc context struct. r=nealsid
http://groups.google.com/group/google-breakpad-dev/browse_thread/thread/21a8e99c4800b51d
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@273 4c0a9323-5329-0410-9bdc-e9ce6186880e
2008-05-14 18:24:23 +00:00
nealsid
d318f9efee
Fix to stop unit tests from being compiled & run for non-native architectures
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@272 4c0a9323-5329-0410-9bdc-e9ce6186880e
2008-05-08 23:15:00 +00:00
doshimun
7ab126ecdd
Replace the user of wcscpy_s with safe_wcscpy in common/windows/string_utils-inl.h to
...
make the code compatible for teams that still use VS 2003 to build.
Fix a bug in client ClientInfo class that returned CustomClientInfo struct containing
a pointer in the client process address space instead of pointer to in-process data
structure.
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@271 4c0a9323-5329-0410-9bdc-e9ce6186880e
2008-05-08 18:15:07 +00:00
doshimun
8602aa71ec
Some style guide compliance changes and changed the prototype of the method to get custom client info in ClientInfo class.
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@270 4c0a9323-5329-0410-9bdc-e9ce6186880e
2008-05-07 21:54:12 +00:00
nealsid
c2bdaa613c
Bug fix for issue 263: mach_vm_region_recurse calls have invalid parameter specified, which succeeds on Leopard but fails on Tiger
...
Reviewer: Chris Rogers(ladderbreaker)
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@269 4c0a9323-5329-0410-9bdc-e9ce6186880e
2008-05-07 21:15:12 +00:00
doshimun
3d4dc1f201
Add a convenience method to CustomClientInfo struct to set both name and value in one call.
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@268 4c0a9323-5329-0410-9bdc-e9ce6186880e
2008-05-05 21:03:51 +00:00
doshimun
0ded3d718f
Add a way for the client apps to specify custom information in case of out-of-process
...
scenarios that the OOP server can use in whatever way it wants to.
Fix a bug in CrashGenerationserver where CreateNamedPipe failure was not checked correctly.
TODO in near future: Add a custom stream to minidump files for the custom information.
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@267 4c0a9323-5329-0410-9bdc-e9ce6186880e
2008-05-05 20:03:56 +00:00
nealsid
47df365bf8
Issue 261/262: 64-bit bug fix when iterating through load commands of a 64-bit binary, and added new test case for ReadImageInfoForTask
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@266 4c0a9323-5329-0410-9bdc-e9ce6186880e
2008-05-05 18:20:04 +00:00
nealsid
d6f0f92de3
Style changes
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@265 4c0a9323-5329-0410-9bdc-e9ce6186880e
2008-04-30 00:56:17 +00:00
nealsid
d906d0f7c9
Updated code to be compliant with style guidelines
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@264 4c0a9323-5329-0410-9bdc-e9ce6186880e
2008-04-29 23:49:39 +00:00
nealsid
4c39c138fe
Issue 258: Added test cases for ReadTaskMemory, reorganized project file, renamed filenames inside comments
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@263 4c0a9323-5329-0410-9bdc-e9ce6186880e
2008-04-25 00:37:19 +00:00
doshimun
9033edcd7b
Add one more parameter to the ClientDumpRequestCallback in crash generation server
...
to pass in the path of the dump file if the dump was generated successfully.
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@262 4c0a9323-5329-0410-9bdc-e9ce6186880e
2008-04-17 21:21:48 +00:00
nealsid
9609db8173
Fix a bug in start address calculation
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@261 4c0a9323-5329-0410-9bdc-e9ce6186880e
2008-04-17 04:15:30 +00:00
nealsid
5da03791a7
As part of resolving issue 256 I'd like to check in some unit
...
tests(ok, just one) for the private copy of nlist that I checked in
last week, plus lay some of the ground work for collecting code
coverage numbers. Both of these are accomplished by leveraging the
built-in facilities of Xcode & Developer Tools(namely, CPlusTest and
gcov integration; however, eventually I will also add a way to get
lcov results from the gcov results). I also:
- renamed breakpad_nlist_64.c to breakpad_nlist_64.cc to be more
consistent(even though it's not C++ code it still only gets called by
C++ code so I don't have to deal with extern "C" constructs).
- I created a new target (minidump_tests) that has a "Coverage"
configuration with the appropriate GCC flags turned on. It is only
compiled in 64-bit configurations and has 10.5 as a minimum
deployment target as well as uses the 10.5 SDK.
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@260 4c0a9323-5329-0410-9bdc-e9ce6186880e
2008-04-15 23:09:30 +00:00
nealsid
b0d807666f
Issue 254: The problem is that nlist() is compiled out of libc in
...
64-bit builds of Leopard. I ported the code over myself and will
check it into the Breakpad tree until we decide there's a better
longer-term solution. If you want to diff the changes, the Apple
source is in libc/gen/nlist.c(I used 498 from 10.5.2).
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@259 4c0a9323-5329-0410-9bdc-e9ce6186880e
2008-04-12 01:16:18 +00:00
doshimun
35c34d6bb9
Add a parameter to CrashGenerationServer to let the callers set the
...
security attributes on the pipe. This is useful when the process
hosting the crash server wants to let processes from other users to
connect to it and generate dumps for them.
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@258 4c0a9323-5329-0410-9bdc-e9ce6186880e
2008-04-12 00:00:34 +00:00
doshimun
05ec557277
Some cosmetic/style changes to conform to style guidelines. This time
...
I waited for the style reviewer to approve all my code so hopefully there
should be no more style related check-ins.
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@256 4c0a9323-5329-0410-9bdc-e9ce6186880e
2008-04-08 19:03:57 +00:00
mmentovai
eeca9921c5
Fix newlines ( #253 ). rs=ted.mielczarek
...
http://groups.google.com/group/google-breakpad-dev/browse_thread/thread/7e62a299ce3fa222
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@255 4c0a9323-5329-0410-9bdc-e9ce6186880e
2008-04-07 21:50:57 +00:00
mmentovai
61ea8bf0d5
Processor crashes on some truncated minidumps after #222 . r=ted.mielczarek
...
http://groups.google.com/group/google-breakpad-dev/browse_thread/thread/a451668b1ece259f
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@254 4c0a9323-5329-0410-9bdc-e9ce6186880e
2008-04-04 21:41:50 +00:00
nealsid
867df1c652
Issue 246: Dynamic_images.* needs to be 64-bit ready. Created types that are typedefed to the appropriate types depending on 32/64-bit compilation and modified dynamic_images to use these new types. Tested 32-bit minidump-generation. Also did some code cleanup along the way. Removed all blank lines that had spaces.
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@253 4c0a9323-5329-0410-9bdc-e9ce6186880e
2008-04-04 21:35:41 +00:00
doshimun
fc816a3b3a
Minor style changes to comply with Google style guidelines.
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@252 4c0a9323-5329-0410-9bdc-e9ce6186880e
2008-04-03 21:46:58 +00:00
ted.mielczarek
dd2ff4a21c
issue 223 - Fixes for SOlaris handler during integration with Firefox. patch by Alfred Peng, r=mento,me
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@250 4c0a9323-5329-0410-9bdc-e9ce6186880e
2008-03-18 16:10:10 +00:00
nealsid
a194d6f1ac
Issue 245: refactoring minidump_format.h into architecture & platform specific files
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@249 4c0a9323-5329-0410-9bdc-e9ce6186880e
2008-03-17 05:24:12 +00:00
doshimun@gmail.com
5066fcdb42
TO BE REVIEWED.
...
Have sent an email for code review already but this check-in is urgent
to fix potential build breaks.
It contains the following changes:
- Change project settings for exception_handler.vcproj so that it links in
crash_generation.lib so that the applications using exception_handler.lib
do not have to link to crash_generation.lib. Make these changes for all 4
build configurations.
- Change the test app project settings to not link to crash_generation.lib
and only link to exception_handler.lib; again for all four configurations.
These changes help the applications that are currently linking to exception_handler.lib
in that they don't have to link to one more lib to get out-of-process dump generation
functionality. In fact, even if they do not use out-of-process dump generation functionality,
after those changes, the apps will need to link with crash_generation.lib anyway in order to
build correctly. This change will eliminate that need.
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@248 4c0a9323-5329-0410-9bdc-e9ce6186880e
2008-03-11 22:28:48 +00:00
doshimun@gmail.com
a8b48f29dd
This changelist contains the changes to the configuration of Visual Studio solution and project files that I
...
added in my last check-in for out-of-process dump generation. My last check-in broke the breakpad_client.sln
build for non debug builds since for the new project that I added (crash_generation.vcproj) to that solution,
I always only changed project properties for debug build. In fact, I didn't have the static-crt build configurations
for the new project either. Similar problems existed for the test application I added, windows/test/crash_generation_app).
This changelist contains changes to 2 solution files, 2 vcproj files and 1 .cc file. The fixes to .cc file are to avoid
warnings on variables used only in debug modes (in asserts) when building in release modes.
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@247 4c0a9323-5329-0410-9bdc-e9ce6186880e
2008-03-10 22:37:07 +00:00
doshimun@gmail.com
c79141e306
Overview:
...
Implement out-of-process dump generation for Windows platform.
Details:
- Created a lib, crash_generation.lib, that implements the out-of-process dump generation protocol.
- The lib code is under client/windows/crash_generation folder and is organized in the following way:
- CrashGenerationServer class (crash_generation_server.h/.cc) implements the server side of
the protocol.
- CrashGenerationClient class (crash_generation_client.h/.cc) implements the client side of
the protocol.
- MinidumpGenerator class (minidump_generator.h/.cc) serves as an abstractino for generating
dump files using Windows APIs, coming up with new file names by creating GUIDs, etc.
- ProtocolMessage class (ipc_protocol.h) represents the message format between the client and server
for pipe IPC.
- Server allows one client at a time on the pipe in the current implementation.
- ReadMe.txt explains the state machine the server uses to serve clients.
- ExceptionHandler is modified and a new constructor is added that allows specifying the pipe name. If the
pipe name is NULL, the behavior is backward compatible - in-process dump generation is done as before. If
the pipe name is specified, out-of-process dump generation registration is attempted. If that fails, the
behavior is again backward compatible.
- If out-of-process registration succeeds, all write dump requests, direct or indirect, are directed to
crash server process that served the registration request. NOTE that the explicit dump requests made by
calling the static method of ExceptionHandler are not directed to theserver.
- client/windows/tests/crash_generation_app implements a simple Win32 GUI application to help test the
out-of-process dump generation client and server. Typical use of the app is to start one instance, click
Server --> Start and then start the other instance. The other instance will register with the first
instance automatically at start-up. Then the second instance can be used to request various typoes of
dump requests by using options under the Client menu.
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@244 4c0a9323-5329-0410-9bdc-e9ce6186880e
2008-03-08 00:02:40 +00:00
bryner
98cb0aebff
Use "%" PRIx64 instead of "%llx" for 64-bit portability.
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@243 4c0a9323-5329-0410-9bdc-e9ce6186880e
2008-03-04 20:28:39 +00:00
bryner
76ef9deb31
Don't redefine __STDC_FORMAT_MACROS if it's already defined. r=mmentovai.
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@242 4c0a9323-5329-0410-9bdc-e9ce6186880e
2008-03-04 17:33:25 +00:00
mmentovai
c27cf3e395
Use "%" PRIx64 instead of "%llx" ( #241 ). r=bryner
...
http://groups.google.com/group/google-breakpad-dev/browse_thread/thread/327dc5326077e48d
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@241 4c0a9323-5329-0410-9bdc-e9ce6186880e
2008-02-25 19:32:00 +00:00
ted.mielczarek
2c2ae28541
issue 238 - missing includes compiling with gcc 4.3. patch by taras glek, r=me
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@240 4c0a9323-5329-0410-9bdc-e9ce6186880e
2008-02-24 21:04:51 +00:00
ted.mielczarek
c1e0783204
Use swprintf_s for VC8 or newer. r=mento
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@238 4c0a9323-5329-0410-9bdc-e9ce6186880e
2008-02-04 20:50:07 +00:00
mmentovai
469580e2df
Remove dependency on ole32 on Windows ( #132 ). Patch by Sorin Jianu <sorinj>, r=me.
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@237 4c0a9323-5329-0410-9bdc-e9ce6186880e
2008-01-28 20:02:01 +00:00
luly81
b801cd6d0f
Fix issue 235, properly handling included(inlined) code.
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@236 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-12-13 06:56:23 +00:00
ted.mielczarek
b3673d13a1
Issue 224 - add Tell method to Minidump class. r=mento
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@235 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-12-04 20:41:02 +00:00
ted.mielczarek
e8eafaaa2e
slight fixup from issue 225
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@234 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-12-03 22:12:25 +00:00
ladderbreaker
4139a40807
fix Mac build by adding stackwalker_amd64.cc to project
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@233 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-11-21 21:07:22 +00:00
ted.mielczarek
68b4798eb4
Issue 225 - dynamically load libcurl in http_upload. patch by Andrew Schultz <ajschult@verizon.net>, r=Liu Li
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@232 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-11-20 02:35:47 +00:00
ted.mielczarek
f0a07749af
Fix compile bustage from issue 221
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@231 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-11-20 02:21:49 +00:00
luly81
299c816021
Add MD_CPU_ARCHITECTURE_AMD64 as valid system type when cpu type is MD_CONTEXT_X86
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@230 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-11-19 05:53:21 +00:00
mmentovai
bbd9b47291
The string buffer lengths in a URL_COMPONENTS structure are in TCHARs, so
...
these should be sizeof(z) / sizeof(z[0]) to avoid a buffer overrun. Caught
by Dmitry Titov, r=me.
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@229 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-11-13 22:17:14 +00:00
ted.mielczarek
feff0b300f
Issue 221 - HTTPUpload::SendRequest should provide error code or error description to callers. r=Liu Li
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@228 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-11-02 12:22:35 +00:00
ted.mielczarek
8eb7111814
Issue 196 - Breakpad processor support for x86-64. r=mento
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@227 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-10-31 19:20:31 +00:00
mmentovai
11e180cd3e
Fix warning regarding initialization order compared to definition order
...
following #222 .
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@226 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-10-22 16:00:35 +00:00
ted.mielczarek
d732add382
Issue 222 - processor fails if an entry in the ModuleList is bad. r=mento
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@225 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-10-19 18:44:51 +00:00
mmentovai
f4021f0c68
Make Breakpad's debug-exception-ignoring configurable. r=Nicolas Sylvain
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@224 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-10-18 20:54:20 +00:00
mmentovai
e47d3a6e36
Remove assertion for a variable that doesn't exist. Patch by Alfred Peng
...
<alfred.peng>. r=me.
http://groups.google.com/group/google-breakpad-dev/browse_thread/thread/e5738aed43450365
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@223 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-10-15 20:47:12 +00:00
mmentovai
56d93f4902
Make sure ENOENT is defined. Spotted by jfbastien <bourgeoisie>.
...
http://groups.google.com/group/google-breakpad-discuss/browse_thread/thread/47f82fe37b7a46d8
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@222 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-10-10 21:15:10 +00:00
ladderbreaker
a100421d48
fix crash_report build due to link error
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@221 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-09-29 01:02:13 +00:00
mmentovai
d7d6c74a68
Breakpad rejects valid modules with a vmaddr of zero on Mac ( #176 ). Patch
...
by Benjamin Smedberg <bsmedberg>. r=me
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@220 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-09-28 18:30:48 +00:00
mmentovai
657a6c4a96
Assertion in CrashReportSender (windows) when no checkpoint file is desired
...
(#216 ). Patch by Ben Turner <bent.mozilla>. r=me.
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@219 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-09-28 18:24:13 +00:00
mmentovai
68004c84d6
Solaris version of symbol dumper ( #207 ). Patch by Alfred Peng. r=me
...
http://groups.google.com/group/google-breakpad-dev/browse_thread/thread/e4cbdbf7ddaf7f51
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@218 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-09-28 18:14:48 +00:00
mmentovai
f2fa084fd2
Fix compiler warning C4245: signed/unsigned mismatch when converting between
...
types. Patch by Sorin Jianu. r=me,bryner
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@217 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-09-28 16:27:56 +00:00
mmentovai
ea2bba9706
Add SPARC/Solaris support to client handler and processor ( #201 , 200).
...
Patch by Michael shang <satisfy123>. r=me, r=Alfred Peng.
http://groups.google.com/group/google-breakpad-discuss/browse_thread/thread/2fba07577f1fa35e
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@215 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-09-26 18:28:05 +00:00
mmentovai
278946c3b5
Fix crash reason switching to allow proper behavior for Linux. Spotted by
...
Michael Shang <satisfy123>, mentioned in issue #200 . r=me
http://groups.google.com/group/google-breakpad-discuss/browse_thread/thread/2fba07577f1fa35e
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@214 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-09-26 18:13:38 +00:00
mmentovai
0e6f5c95d7
Allow Breakpad processor library to build on Solaris with the native Sun
...
toolchain (#142 ). Patch by Alfred Peng. r=me.
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@213 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-09-26 18:08:41 +00:00
mmentovai
7e2b64f5fd
Fix license boilerplate on these two files. Apparently these were missed
...
when the boilerplates were fixed in revision 31/bug 29 - these files
were checked in at revision 32.
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@212 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-09-26 17:55:53 +00:00
bryner
28c645f3ee
Silences warning C4701: local variable 'claimed_size' may be used with out
...
having been initialized. The code is correct however the compiler can't see
the relationship between has_content_length_header and the claimed_size so it
generates a warning.
Patch from Sorin Jianu, r=bryner
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@211 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-09-20 21:48:47 +00:00
ladderbreaker
48309a2dbc
Issue 208: Reviewer waylonis
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@210 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-09-19 20:43:38 +00:00
ladderbreaker
30dfc3d392
Issue 208: Reviewer waylonis
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@209 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-09-19 20:15:21 +00:00
ladderbreaker
649967cfd2
Issue 209: Reviewer waylonis
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@208 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-09-19 20:14:21 +00:00
dmaclach
99b36baa82
Adds the ability to designate a folder with sym files in it that will be used for symbol matching
...
to crash_report.
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@207 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-09-15 00:33:09 +00:00
ladderbreaker
d792274003
Issue203 : reviewed by Waylonis
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@206 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-08-29 21:28:46 +00:00
ladderbreaker
69d242245a
Issue 202: reviewed by Waylonis
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@205 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-08-27 19:46:32 +00:00
ladderbreaker
9982e65506
Issue 199: Reviewed by Waylonis
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@204 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-08-17 21:22:16 +00:00
mmentovai
6a3f87982d
Add accessor for ExceptionHandler::requesting_thread_id_ ( #198 ). Patch by Lucas Eckels. r=me
...
http://groups.google.com/group/google-breakpad-dev/browse_thread/thread/37da2dd8c14659c3
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@203 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-08-17 19:42:18 +00:00
ladderbreaker
70c7438bff
Issue 197: reviewed by Waylonis
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@202 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-08-16 20:22:37 +00:00
ladderbreaker
8597ff9fe1
Issue 197: reviewed by Waylonis
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@201 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-08-16 20:20:50 +00:00
ladderbreaker
7d8a79b3e9
Issue 197: reviewed by Waylonis
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@200 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-08-16 20:20:31 +00:00
ladderbreaker
8aef89f021
Issue 197: reviewed by Waylonis
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@199 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-08-16 20:19:45 +00:00
mmentovai
9abfe3d0a5
Solaris port of minidump generator. Port by Alfred Peng. r=me
...
http://groups.google.com/group/google-breakpad-dev/browse_thread/thread/7d8945578e3dac3
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@198 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-08-07 21:16:45 +00:00
ted.mielczarek
b62d01462c
Issue 175 - fix permissions on dump file in MinidumpFileWriter. r=mento
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@197 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-07-05 22:13:02 +00:00
ted.mielczarek
8408a209cd
issue 151 - Crash when processing file names less than 4 bytes. r=me
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@196 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-07-05 19:31:59 +00:00
ladderbreaker
43a81daaba
issue 194: reviewed by waylonis
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@195 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-07-03 00:09:14 +00:00
mmentovai
3c07b28119
These should be int to allow them to be ORed together. Ted, please review.
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@194 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-07-02 20:41:30 +00:00
mmentovai
6a844b1d85
Allow finer control over installed handler types ( #193 ). r=ted.mielczarek
...
http://groups.google.com/group/google-breakpad-dev/browse_thread/thread/992a1bb09dc58a32
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@193 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-07-02 19:41:05 +00:00
ted.mielczarek
1260067e42
Issue 190 - 32 bit build fails on a 64 bit Linux system. Patch by wgianopoulos, r=me
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@192 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-07-02 18:13:33 +00:00
mmentovai
fb6be7cf42
Add an API to pass exception information into the handler ( #192 ).
...
r=ted.mielczarek
http://groups.google.com/group/google-breakpad-dev/browse_thread/thread/42e9ee1a636bca8b
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@191 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-07-02 15:36:56 +00:00
ted.mielczarek
bd7b42587c
Issue 191 - Linux dump_syms produces bad line numbers for some functions (16 bit overflow). r=Liu Li
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@190 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-07-02 12:02:36 +00:00
ted.mielczarek
b5c78cc8d1
issue 185 - Need constants / stringification for Linux exception codes. r=mento
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@189 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-06-11 17:03:30 +00:00
ted.mielczarek
21d58c7281
Issue 182: linux handler doesn't have sigcontext if called from a previous signal handler. r=mento / Liu Li
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@188 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-06-11 16:01:46 +00:00
ladderbreaker
2e86dfe705
issue 154: reviewed by Waylonis
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@187 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-06-06 20:49:48 +00:00
ted.mielczarek
684649a571
Issue 42 - check for non-existent dump file in HTTPUpload::SendRequest. r=bryner
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@186 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-06-01 11:47:28 +00:00
ted.mielczarek
f68536ae50
Issue 169 - Fill in CPU vendor id in MDRawSystemInfo in Linux minidump_generator. r=Liu Li
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@185 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-05-31 20:28:43 +00:00
mmentovai
3114dc8a35
C++ file gets a C++ comment
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@184 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-05-31 19:49:04 +00:00
mmentovai
2e0e2234b9
Allow building with -pedantic ( #186 ). r=ted.mielczarek
...
http://groups.google.com/group/google-breakpad-dev/browse_thread/thread/6aa39d7f0ffa3c42
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@183 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-05-31 19:44:52 +00:00
mmentovai
e96a791d9a
Check allocation and array sizes in minidump.cc ( #12 ). r=bryner
...
http://groups.google.com/group/google-breakpad-dev/browse_thread/thread/7258b34d26ffc890
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@182 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-05-31 15:54:06 +00:00
ted.mielczarek
46b60801cb
Updated test data from Issue 143
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@181 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-05-30 14:06:36 +00:00
ted.mielczarek
90e050e598
Issue 143 - MinidumpProcessor should extract number of processors. r=mento
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@180 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-05-30 12:14:09 +00:00
ted.mielczarek
0e94332f7c
Issue 184 - MinidumpModule::code_identifier doesn't handle MD_OS_LINUX. r=mento
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@179 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-05-29 21:30:48 +00:00
mmentovai
6ed453a770
Processor can attempt processing all threads even when interrupted ( #177 ).
...
r=ted.mielczarek
http://groups.google.com/group/google-breakpad-dev/browse_thread/thread/8fda7c96fa7b5d57
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@178 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-05-25 19:10:19 +00:00
mmentovai
32b802dba3
Provide for logging initialization routines ( #179 ). r=bryner
...
http://groups.google.com/group/google-breakpad-dev/browse_thread/thread/4b196ca0b6d7f9a6
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@177 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-05-25 18:04:17 +00:00
mmentovai
1ef60aaa6c
Fix bustage introduced in [172]
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@176 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-05-25 16:06:53 +00:00
dmaclach
cb449c6c88
Fixup crashreport tool on the mac
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@175 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-05-24 22:07:37 +00:00
ladderbreaker
026b28ec40
issue 167: reviewed by Benjamin Smedberg
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@174 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-05-22 00:25:38 +00:00
mmentovai
fabb8714a7
Strengthen range checks in minidump.cc ( #173 ). r=bryner
...
http://groups.google.com/group/google-breakpad-dev/browse_thread/thread/ad373296bfe5e08b
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@173 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-05-21 21:02:04 +00:00
mmentovai
65571f17ed
Add logging to minidump processor ( #82 ). Part 2: add messages to the rest of
...
the processor. r=ted.mielczarek
http://groups.google.com/group/google-breakpad-dev/browse_thread/thread/cf56b767383a5d4b
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@172 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-05-21 20:09:33 +00:00
bryner
08c8c4ddcf
Add an optional per-day limit to the number of crash reports sent. The state
...
is maintained in an app-specified checkpoint file. (#174 , r=mmentovai)
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@171 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-05-21 18:32:02 +00:00
waylonis
32d4064736
- Add const keyword / casting to supress more stringient compiler warnings
...
- Move DynamicImage::Print() from dynamic_images.h to dynamic_images.cc
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@170 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-05-19 00:41:39 +00:00
mmentovai
af3c43f00e
Add logging to minidump processor ( #82 ). First part: logging infrastructure
...
and messages for minidump.cc and minidump_processor.cc. r=bryner.
http://groups.google.com/group/google-breakpad-dev/browse_thread/thread/b056994d675f623c
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@169 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-05-17 18:34:37 +00:00
ted.mielczarek
95be2b659e
Issue 168 - Output debug file and debug identifier in minidump_stackwalk machine-readable output. r=mento
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@168 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-05-16 18:11:36 +00:00
ted.mielczarek
822ead1319
Issue 140 - Fill in some more cpu information on OS X x86 dumps. r=mento
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@167 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-05-11 00:50:29 +00:00
ted.mielczarek
b86e7ec7f0
Issue 162 - handle pure virtual function calls in VC++. r=mento
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@166 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-05-10 17:12:14 +00:00
ted.mielczarek
b44d391b53
Fixing comment about cpuid vendor_id
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@165 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-05-10 16:01:33 +00:00
ladderbreaker
8deb7b799f
Issue 166 - reviewer Waylonis
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@164 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-05-09 01:32:45 +00:00
mmentovai
436801fa23
Stacks (still) truncated on win32 ( #165 ). Patch by Benjamin Smedberg. r=me
...
Don't require a program string to reset %ebp, as not all program strings
set this value.
http://groups.google.com/group/google-breakpad-dev/browse_thread/thread/ee4854ae7ffce94e
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@163 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-05-08 20:56:30 +00:00
ted.mielczarek
0e668e0783
Issue 164 - MACHINE_THREAD_STATE on older 10.4 versions. Patch by Dave Camp, r=Chris Rogers
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@162 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-05-08 19:04:14 +00:00
ted.mielczarek
980f6dc277
Extraneous newline in format string
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@161 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-05-08 11:31:10 +00:00
ladderbreaker
3d55532df2
Issue 161: reviewer Waylonis
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@160 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-05-07 19:48:02 +00:00
ted.mielczarek
0c70be6873
Issue 163, reviewer mento. Make dynamic_images.cc build on 10.3.9 SDK + update XCode project
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@159 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-05-07 19:32:44 +00:00
ladderbreaker
40a5c0fb0d
simply fix no newline at end of file
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@158 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-05-04 21:23:30 +00:00
ted.mielczarek
663b7904e4
oops, committed accidentally
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@157 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-05-04 19:52:18 +00:00
ted.mielczarek
9a3263a670
Issue 160 - Reviewer Chris Rogers
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@156 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-05-04 19:37:00 +00:00
ted.mielczarek
9be806efde
missed header renames from Issue 152
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@155 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-05-04 12:41:02 +00:00
ladderbreaker
1fa8046e35
Issue 158: reviewer ladderbreaker
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@154 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-05-03 22:58:56 +00:00
luly81
265726e56c
Add md5 implementation into code base to get rid of
...
openssl dependency.
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@153 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-05-03 20:45:27 +00:00
ted.mielczarek
255bbe93ed
Issue 152 - Patch by Dave Camp, Reviewer Chris Rogers
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@152 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-05-03 20:12:41 +00:00
ladderbreaker
de2fd15db9
Issue 159: reviewer Waylonis
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@151 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-05-02 21:05:49 +00:00
ladderbreaker
c455a76c03
Issue 159: reviewer Waylonis
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@150 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-05-02 21:04:57 +00:00
luly81
e219ba182e
Merge Ted's patch for writing symbols to stdout for linux.
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@149 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-05-02 19:13:09 +00:00
mmentovai
3c27dcc1b6
Minidump without context crashes the processor ( #153 ). r=bryner
...
http://groups.google.com/group/google-breakpad-dev/browse_thread/thread/2d221bd478bec550
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@148 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-04-25 19:38:01 +00:00
mmentovai
329e6a9630
Emergency crash fix, tbr=bryner
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@147 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-04-25 15:17:19 +00:00
mmentovai
b63740b329
Truncated Windows/x86 stacks when using FPO. Add stack scanning to recover
...
instruction and frame pointers with better reliability. r=bryner
http://groups.google.com/group/google-breakpad-dev/browse_thread/thread/e74af03fb0629aa0
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@146 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-04-20 18:36:42 +00:00
mmentovai
1d4ce0a1d8
c++filt crashes when fed some mangled ObjC++ names. Oops. Patch by Dave
...
MacLachlan, r=me.
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@145 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-04-12 20:40:22 +00:00
ladderbreaker
e9017f3239
Issue 147 - reviewer Waylonis
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@144 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-04-11 00:45:00 +00:00
mmentovai
29789d8106
Wrong version of swprintf used with VS 2003/7.1 CRT. r=bryner
...
http://groups.google.com/group/google-breakpad-dev/browse_thread/thread/eadfa703d4bd8a4a
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@143 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-04-09 18:35:20 +00:00
mmentovai
375931a680
Revert previous patch, see google-breakpad-dev
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@142 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-04-05 19:44:29 +00:00
mmentovai
fe60ba9789
Fix temp file leak. Patch by Thomas Thiriez. r=me
...
http://groups.google.com/group/google-breakpad-discuss/browse_thread/thread/42293e72537b554
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@141 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-04-05 19:41:33 +00:00
mmentovai
30fc9ce1c0
Replace GB_WSU_SAFE_SWPRINTF_TERMINATE with inline code ( #145 followup).
...
r=bryner
http://groups.google.com/group/google-breakpad-dev/browse_thread/thread/f77da3d219cf9388
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@140 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-04-04 16:13:55 +00:00
luly81
825840253b
Discard age field in the dumped symbol file.
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@139 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-04-04 03:26:40 +00:00
ladderbreaker
e2abee6b01
Issue 147 - reviewer Waylonis
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@138 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-04-03 01:18:18 +00:00
ladderbreaker
aa870d0c1b
Issue 146 - reviewer Waylonis
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@137 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-04-02 23:17:16 +00:00
mmentovai
1de8bed899
Windows http_upload should allow response without Content-Length header ( #144 ).
...
Patch by Ted Mielczarek. r=me
http://groups.google.com/group/google-breakpad-dev/browse_thread/thread/a401434f639e5b2f
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@136 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-04-02 18:24:16 +00:00
mmentovai
aec44489da
vswprintf causes Purify to fail ( #145 ). r=darin
...
http://groups.google.com/group/google-breakpad-dev/browse_thread/thread/88e18d9fac4eee22
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@135 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-03-30 20:30:08 +00:00
luly81
3479e850c5
Fix issue 136.
...
Block signals before writing minidumps.
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@134 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-03-29 01:32:39 +00:00
luly81
ab175ccc2b
Fix bug of issue 135, now can dump symbols for dynamic libraries.
...
Also some minor fixes to make it compile with more strict compiling options.
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@133 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-03-27 02:16:13 +00:00
ladderbreaker
baaeb5af71
issue141: reviewer Waylonis
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@132 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-03-23 20:23:31 +00:00
mmentovai
33f178df55
s/an breakpad/a breakpad/ ( #127 ), patch by techtonik, r=me
...
http://groups.google.com/group/google-breakpad-dev/browse_thread/thread/9610c2878a2bcdc
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@131 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-03-23 16:21:17 +00:00
bryner
809f0cb858
Ignore functions that have invalid addresses or sizes, instead of aborting the
...
symbol file load (#137 ). r=mmentovai.
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@130 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-03-22 23:20:17 +00:00
mmentovai
6bc866cc82
Don't output FUNC lines for 0-length functions ( #139 ). r=bryner
...
http://groups.google.com/group/google-breakpad-dev/browse_thread/thread/c684520587356ec3
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@129 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-03-22 21:10:30 +00:00
ladderbreaker
d128f5f6af
issue 134: reduce timeout period for minidump upload : reviwer waylonis
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@128 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-03-16 18:28:53 +00:00
ladderbreaker
1a4310017e
issue 133: Mach-o UUID generation has problems - reviewed by waylonis
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@127 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-03-16 17:51:43 +00:00
luly81
bcd46f0079
Add Linux exception handler.
...
Add Linux stab symbol dumper.
Add minidump & symbol uploader for Linux.
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@126 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-03-12 01:53:18 +00:00
ladderbreaker
1f3d2571d1
fixes for issue 129 : reviewed by Waylonis
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@125 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-03-09 21:45:42 +00:00
ladderbreaker
530a7ad99e
fixes for issue 128: reviewed by Waylonis
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@124 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-03-08 23:47:37 +00:00
bryner
fce2508282
Fix exception handler build with MSVC versions prior to 2005. r=mmentovai.
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@123 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-03-05 21:13:23 +00:00
mmentovai
e5dc60822e
Rename Airbag to Breakpad.
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@122 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-02-14 19:51:05 +00:00
waylonis
83befb1cb4
Change the symbol table parsing so that it will only use symbols that are from the __TEXT/__text section.
...
Fixes issue #127
tbr=mmentovai.
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@121 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-02-08 18:04:48 +00:00
mmentovai
baff938211
Airbag windows client didn't trap VC8 parameter validation errors. Now it
...
does. (#120 ) r=bryner.
http://groups.google.com/group/airbag-dev/browse_thread/thread/3f21d0e379e32771
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@120 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-02-07 20:20:10 +00:00
waylonis
983264848d
Fix bug with mach-o walker not properly walking universal binary (Issue #125 )
...
Fix exception handler so that it will properly forward exceptions (Issue #126 )
r=mmentovai
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@119 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-02-07 18:57:09 +00:00
bryner
1d78cad82e
Store 128-bit values as a struct with high and low fields, so that consumers
...
of airbag don't have to know the platform endianness.
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@118 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-02-07 04:24:03 +00:00
waylonis
600e56bc39
- Fixes the bug with a fork()'d child's exception being caught in the parent process
...
- Only looks for EXC_MASK_BAD_ACCESS, EXC_MASK_BAD_INSTRUCTION, and EXC_MASK_ARITHMETIC exceptions
- Adds try/catch blocks around "new" for bad_alloc
- Uses map.find() rather than map[] notation so as not to create extraneous objects
- Creates the exception watching thread as detached
r=mmentovai
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@117 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-02-05 18:49:44 +00:00
waylonis
3a9a38a29e
Don't fail the minidump processing if the requesting thread can't be found.
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@116 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-02-01 23:54:05 +00:00
waylonis
87d965538b
Only use the segments that contain sections in the identifer calculation.
...
Fixes Issue #121 .
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@115 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-01-31 19:31:52 +00:00
mmentovai
d986a54f67
Add module list to machine-readable minidump_stackwalk output ( #119 ).
...
Patch by Ted Mielczarek. r=me
http://groups.google.com/group/airbag-dev/browse_thread/thread/144e66b1de80b1db
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@114 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-01-29 21:30:31 +00:00
mmentovai
482e44bf51
Qualify string and vector with std namespace when used without
...
using-declaration (#118 ). r=bryner
http://groups.google.com/group/airbag-dev/browse_thread/thread/4946d156a37331df
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@113 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-01-25 21:56:18 +00:00
mmentovai
a14ef803d7
Support machine-readable output format from minidump_stackwalk;
...
Support multiple symbol paths in SimpleSymbolSupplier (#113 ).
Patch by Ted Mielczarek. r=me
http://groups.google.com/group/airbag-dev/browse_thread/thread/44b91a9112618b26
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@112 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-01-25 00:17:02 +00:00
waylonis
4b987df62b
Update crash_report tool and internal classes to reflect change to ProcessState (Issue #116 )
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@110 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-01-24 00:28:24 +00:00
waylonis
d31c8b0292
Changes to support patch #108 :
...
- Calculate unique file id for mach-o files
- Add file id support to dump_syms and symupload tools
- Fix return values of tools to indicate success or failure
- Change dump_syms class to be Objective-C++
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@109 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-01-23 19:17:03 +00:00
mmentovai
50e299b00e
Library to handle SymSrv integration ( #111 ). r=bryner
...
http://groups.google.com/group/airbag-dev/browse_thread/thread/b40e66d1d57e61b5
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@105 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-01-18 21:13:14 +00:00
mmentovai
48dab62c2d
Be lenient when reading CodeView records of unknown types ( #110 ). r=bryner
...
- Read (but don't use) CodeView records with unknown signature values
instead of failing. This allows the module list to be read in, and
will result in better stack traces in affected dumps.
http://groups.google.com/group/airbag-dev/browse_thread/thread/2c7d3e3b1fd6ea96
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@104 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-01-17 00:16:37 +00:00
mmentovai
f614cb9845
Pass the exception record (EXCEPTION_POINTERS*) to callback functions from
...
ExceptionHandler on Windows. Patch by John Abd-El-Malek. r=me
Interface change: post-dump and pre-dump (filter) callbacks now must accept
an additional EXCEPTION_POINTERS* argument.
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@103 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-01-12 16:54:10 +00:00
waylonis
fd98b2af37
Add classes to: walk mach-o files, look for identifiers, and return a 16 byte unique identifier. Fixes #106 .
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@102 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-01-11 01:49:07 +00:00
mmentovai
97d392dc4b
Communicate OS and CPU to SymbolSupplier ( #107 ). r=bryner
...
Interface change: moved a few fields around in ProcessState; added new
arguments to Stackwalker and SymbolSupplier.
http://groups.google.com/group/airbag-dev/browse_thread/thread/17e4a48ec3ede932
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@101 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-01-10 22:47:56 +00:00
waylonis
0ec76c7fad
Added method to allow adding a file's contents directly. Fixes issue #105 .
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@100 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-01-04 04:43:41 +00:00
incrementalist
d4e527b7ee
Allows the caller of CrashReportSender::SendCrashReport() to determine that
...
the server rejected a crash report, by changing the return value from a
boolean to a tri-state enum.
Fixes issue #101 . Reviewed by mmentovai.
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@99 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-01-03 23:14:46 +00:00
waylonis
5ac2b9a569
Add Mac exception handler and generator. Fixes issue #69 . Reviewed by mmentovai.
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@98 4c0a9323-5329-0410-9bdc-e9ce6186880e
2006-12-20 17:41:55 +00:00
waylonis
c4d599912c
Fix UTF32ToUTF16Char() conversion. Fixes issue #99 . Reviewed by bryner.
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@97 4c0a9323-5329-0410-9bdc-e9ce6186880e
2006-12-20 17:22:41 +00:00
waylonis
70b5efdda7
Add Mac string utilities. Reviewed by mmentovai. Fixes issue #98 .
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@96 4c0a9323-5329-0410-9bdc-e9ce6186880e
2006-12-19 22:11:46 +00:00
waylonis
62c79c5a40
Add Mac symupload tool. Reviewed by bryner. Fixes issue #96 .
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@95 4c0a9323-5329-0410-9bdc-e9ce6186880e
2006-12-19 21:57:09 +00:00
waylonis
9ddb3ae949
Add Mac dump_syms tool and support class. Fixes issue #73 .
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@94 4c0a9323-5329-0410-9bdc-e9ce6186880e
2006-12-19 20:28:32 +00:00
waylonis
b65dce60f1
Add crash_report tool that will:
...
- Generate local symbol file for module
- Output minidump report in a format similar to Apple's crash reporter
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@93 4c0a9323-5329-0410-9bdc-e9ce6186880e
2006-12-18 23:59:48 +00:00
waylonis
a2fa3dda54
Add better support for UTF character conversions. Fixes Issue 78.
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@91 4c0a9323-5329-0410-9bdc-e9ce6186880e
2006-12-16 01:01:19 +00:00
waylonis
8cc32d3bb8
Add unittest for minidump file writer. Fixes issue #85 .
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@90 4c0a9323-5329-0410-9bdc-e9ce6186880e
2006-12-16 00:42:13 +00:00
waylonis
3782a335d3
Change function declarations to match those of the header file. Amazingly, gcc did not complain.
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@89 4c0a9323-5329-0410-9bdc-e9ce6186880e
2006-12-15 00:09:07 +00:00
waylonis
eee138c2f3
Add unicode.org UTF-8/16/32 conversion code.
...
Add wrapper functions to make things more convenient.
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@88 4c0a9323-5329-0410-9bdc-e9ce6186880e
2006-12-15 00:03:27 +00:00
waylonis
b7b89b3b01
Changed files_ to be a Dictionary.
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@87 4c0a9323-5329-0410-9bdc-e9ce6186880e
2006-12-14 23:23:21 +00:00
waylonis
5b9bc2fd5e
Add the HTTP uploading class for Mac.
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@86 4c0a9323-5329-0410-9bdc-e9ce6186880e
2006-12-14 23:17:46 +00:00
mmentovai
c7b6c11f32
Fix capitalization of identifiers ( #94 ). r=bryner
...
http://groups.google.com/group/airbag-dev/browse_thread/thread/15cf4d0ce5ed1014
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@85 4c0a9323-5329-0410-9bdc-e9ce6186880e
2006-12-12 21:52:56 +00:00
mmentovai
fb35cf79e2
Fix stackwalker_selftest following #89 ( #95 ). r=bryner
...
http://groups.google.com/group/airbag-dev/browse_thread/thread/d6d6a83ec41f4e0f
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@84 4c0a9323-5329-0410-9bdc-e9ce6186880e
2006-12-12 21:51:36 +00:00
bryner
fd38d48e6d
Add an abstract interface to SourceLineResolver, and allow any implementation
...
to be used with MinidumpProcessor. The basic SourceLineResolver is now a
public interface (#89 )
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@83 4c0a9323-5329-0410-9bdc-e9ce6186880e
2006-12-11 23:22:54 +00:00
mmentovai
65dbfcc15f
Removing CRs from #81 . Hey, how'd those get in there?
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@82 4c0a9323-5329-0410-9bdc-e9ce6186880e
2006-12-08 22:49:07 +00:00
incrementalist
dd7c38baae
This patch fixes Airbag issue #44 .
...
Summary of this patch:
* It adds a new wstring* parameter to the end of both
SendCrashReport() and HTTPUpload::SendRequest(), which can be NULL.
* If the request isn't successful, the result parameter isn't touched.
* It adds HTTPUpload::UTF8ToWide() to allow the response to be
returned as a wstring,
* It changes the return value of SendRequest (and by extension,
SendCrashReport) so that if the size of the response body isn't
exactly the same as the value given in the Content-Length header, the
return value is false (in addition to the previous semantics).
* It also updates symupload.cc to account for the new parameter in
SendRequest().
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@81 4c0a9323-5329-0410-9bdc-e9ce6186880e
2006-12-08 20:45:20 +00:00
bryner
f33b8d2d07
Provide a mechanism for SymbolSuppliers to interrupt processing ( #93 )
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@80 4c0a9323-5329-0410-9bdc-e9ce6186880e
2006-12-08 04:13:51 +00:00
mmentovai
283fd39248
Allow exception handler callbacks more flexibility ( #81 ). r=bryner
...
- Provide an optional filter callback that gets triggered before attempting
to write a dump, to give client code a chance to refuse handling early
in the process.
- Allow exceptions that are unhandled by Airbag (due to filter callback or
dump callback return value, or failure to write a dump) to be passed to the
previous handler or to the system.
- In order to pass exceptions unhandled by the topmost Airbag handler to
lower handlers, fix up the stacking of ExceptionHandler objects, and give
each ExceptionHandler object its own thread (like the Mac implementation)
to avoid deadlock.
- Provide a dump_path argument to callbacks, as requested by developers and
already implemented in the Mac handler.
- Avoid calling c_str in exception handler code (#90 ).
http://groups.google.com/group/airbag-dev/browse_thread/thread/4771825ced38a84c
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@79 4c0a9323-5329-0410-9bdc-e9ce6186880e
2006-12-07 20:46:54 +00:00
mmentovai
94f07040ce
Test data update following PDBSourceLineWriter change ( #91 ). r=bryner
...
http://groups.google.com/group/airbag-dev/browse_thread/thread/d713d3e73aa1a0dd
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@78 4c0a9323-5329-0410-9bdc-e9ce6186880e
2006-12-07 15:55:30 +00:00
mmentovai
93fa375b58
symupload parameters don't match processor expectations ( #91 ). r=bryner
...
- Interface change: the "guid" and "age" parameters supplied to a symbol
server by symupload have been merged into "debug_identifier". Some
other parameters have had their names changed. Additional code_file,
os, and cpu parameters have been added.
- Interface change: the format of the MODULE line at the top of dumped .sym
files has changed slightly. The fields used for uuid and age have
merged into a debug_identifier-type field.
- debug_identifier is formatted the same way as CodeModule::debug_identifier
for ease of server-side processing.
http://groups.google.com/group/airbag-dev/browse_thread/thread/8022f504cf01f994
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@77 4c0a9323-5329-0410-9bdc-e9ce6186880e
2006-12-06 20:18:26 +00:00
mmentovai
28e5990b57
Fix possible null pointer dereference in MinidumpModule (following #32 ).
...
r=waylonis
http://groups.google.com/group/airbag-dev/browse_thread/thread/b684b775078d91ca
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@76 4c0a9323-5329-0410-9bdc-e9ce6186880e
2006-12-06 05:03:48 +00:00
waylonis
daf4211942
Update reporting strings for exceptions (Issue 88)
...
Add time_date_stamp to process state.
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@75 4c0a9323-5329-0410-9bdc-e9ce6186880e
2006-12-06 04:58:27 +00:00
mmentovai
db3342a10e
Module API ( #32 ). r=waylonis, bryner
...
- Introduces a standard API for dealing with modules. MinidumpModule
is now a concrete implementation of this API. Code may interact with
single modules using the CodeModule interface, and collections of
modules using its container, the CodeModules interface.
- CodeModule is used directly by SymbolSupplier implementations and
SourceLineResolver. Reliance on the specific implementation in
MinidumpModule has been eliminated.
- Module lists are now added to ProcessState objects. Module references
in each stack frame are now pointers to objects in these module lists.
- The sample minidump_stackwalk tool prints the module list after printing
all threads' stacks.
http://groups.google.com/group/airbag-dev/browse_frm/thread/a9c0550edde54cf8
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@74 4c0a9323-5329-0410-9bdc-e9ce6186880e
2006-12-05 22:52:28 +00:00
mmentovai
ed61ae0bbd
Don't use CRT in exception handler code ( #86 ). r=bryner
...
http://groups.google.com/group/airbag-dev/browse_thread/thread/f671277ebd6ea7fd
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@73 4c0a9323-5329-0410-9bdc-e9ce6186880e
2006-11-28 19:47:44 +00:00
mmentovai
373c49b416
Eliminate usage of vector<>[0] for 0-sized vectors in processor library ( #84 ).
...
r=bryner
http://groups.google.com/group/airbag-dev/browse_thread/thread/8eb9277ac06425e3
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@72 4c0a9323-5329-0410-9bdc-e9ce6186880e
2006-11-27 21:42:07 +00:00
bryner
c297c50f83
Fix a crash when attempting to upload a zero-length dump file ( #83 ) r=mmentovai
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@71 4c0a9323-5329-0410-9bdc-e9ce6186880e
2006-11-27 18:38:39 +00:00
mmentovai
4365e2fe41
Support GUID-less PDBs ( #77 ). r=bryner
...
- Handle MDCVInfoPDB20-based PDBs by outputting a signature instead of a guid
in the MODULE line.
- Identify the OS and CPU in the MODULE line.
- Suppress multiple subsequent identical STACK WIN lines.
http://groups.google.com/group/airbag-dev/browse_thread/thread/0f54e2c33ed5d82d
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@70 4c0a9323-5329-0410-9bdc-e9ce6186880e
2006-11-21 16:58:36 +00:00
bryner
042ca733d3
Use the reentrant versions of strtok() and gmtime() ( #79 ) r=mmentovai
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@69 4c0a9323-5329-0410-9bdc-e9ce6186880e
2006-11-20 20:58:10 +00:00
mmentovai
7a983e94d0
Removing erroneous svn:executable setting.
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@68 4c0a9323-5329-0410-9bdc-e9ce6186880e
2006-11-18 23:37:52 +00:00
mmentovai
7573d1dd44
Modify SimpleSymbolSupplier for easier sublcassing ( #75 ).
...
Patch by Ted Mielczarek <ted.mielczarek>. r=me
http://groups.google.com/group/airbag-dev/browse_thread/thread/34690777576ccf7e
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@67 4c0a9323-5329-0410-9bdc-e9ce6186880e
2006-11-17 18:50:19 +00:00
waylonis
9e586c173e
Move some inlined functions to .cc file. Add some assertions.
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@66 4c0a9323-5329-0410-9bdc-e9ce6186880e
2006-11-16 22:43:57 +00:00
waylonis
ff480d4b4b
Add minidump file writer. Tested on Mac, but should compile on POSIX systems.
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@65 4c0a9323-5329-0410-9bdc-e9ce6186880e
2006-11-16 21:52:18 +00:00
mmentovai
73cd14b4af
Airbag client libraries should compile under MSVC .NET 2003/7.1 ( #64 ).
...
r=bryner
http://groups.google.com/group/airbag-dev/browse_thread/thread/b838faeb50f71818
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@64 4c0a9323-5329-0410-9bdc-e9ce6186880e
2006-11-15 22:24:42 +00:00
mmentovai
8647dde8cc
Limit use of default namespace in tests and utility programs ( #71 ). r=bryner
...
- main is now the only thing you'll find in the default namespace.
Everything else has been moved into an unnamed namespace.
http://groups.google.com/group/airbag-dev/browse_thread/thread/14130a0284a0307f
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@63 4c0a9323-5329-0410-9bdc-e9ce6186880e
2006-11-09 17:04:56 +00:00
mmentovai
76f052f8fb
Suppress handler thread from appearing in MinidumpProcessor's ProcessState
...
(#65 ). r=bryner
- Interface change: (ProcessState).crash_thread is now requesting_thread and
will be populated for non-crash dumps. If the requesting thread cannot
be determined, requesting_thread is set to -1.
http://groups.google.com/group/airbag-dev/browse_thread/thread/c422ec481a2db440
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@62 4c0a9323-5329-0410-9bdc-e9ce6186880e
2006-11-06 23:00:19 +00:00
mmentovai
5ac32b6534
Minidumps should indicate which thread generated the dump and which requested
...
dump generation (#57 ). r=bryner
http://groups.google.com/group/airbag-dev/browse_thread/thread/f11758d171261184
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@61 4c0a9323-5329-0410-9bdc-e9ce6186880e
2006-11-06 20:54:19 +00:00
mmentovai
fe82bf24a9
Move headers for exported interfaces into src/google_airbag ( #51 ). r=bryner
...
http://groups.google.com/group/airbag-dev/browse_thread/thread/e01f177386e8794a
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@60 4c0a9323-5329-0410-9bdc-e9ce6186880e
2006-11-06 19:39:47 +00:00
mmentovai
80866e7945
Symbol file should contain module GUID at beginning ( #66 ). r=bryner
...
- The dumped symbol format now begins with a MODULE line identifying the
uuid, age, and name of the source pdb file.
- The processor ignores MODULE lines, but they are useful in figuring out
how to index symbol files in a symbol store.
- dump_syms and symupload now both accept either a pdb or exe/dll and
will read the pdb regardless.
- Figured out that MSSS always represents a module's age in pathnames in
hexadecimal, and updated SimpleSymbolSupplier to match.
http://groups.google.com/group/airbag-dev/browse_thread/thread/572108d6567edd58
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@59 4c0a9323-5329-0410-9bdc-e9ce6186880e
2006-11-06 19:34:19 +00:00
waylonis
e47047b383
Fix minor naming inconsistency ( #67 ). r=mmentovai
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@58 4c0a9323-5329-0410-9bdc-e9ce6186880e
2006-11-02 01:02:39 +00:00
mmentovai
b261019951
Windows exception handler does not survive stack overflows ( #34 ). r=brian,
...
thanks also to darin
- All minidump writing is now done on a dedicated thread. When a stack
overflow exception occurs, the only work that needs to be done on the
exception thread will easily fit within the guard page.
http://groups.google.com/group/airbag-dev/browse_thread/thread/3935e339d8354a75
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@57 4c0a9323-5329-0410-9bdc-e9ce6186880e
2006-10-31 16:49:38 +00:00
mmentovai
12a5245bfe
Disable exception handling warnings in Windows client code ( #38 ).
...
Patch by Ted Mielczarek. r=me
http://groups.google.com/group/airbag-dev/browse_thread/thread/133814673f75d5fa
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@56 4c0a9323-5329-0410-9bdc-e9ce6186880e
2006-10-27 19:47:21 +00:00
mmentovai
1bff57e589
Add set_dump_path method to ExceptionHandler ( #37 ). Patch by Ted Mielczarek.
...
r=me
http://groups.google.com/group/airbag-dev/browse_thread/thread/06167df948717f4d
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@55 4c0a9323-5329-0410-9bdc-e9ce6186880e
2006-10-27 16:10:55 +00:00
mmentovai
6b9955cc42
minidump_stackwalk should use MinidumpProcessor ( #64 ). r=bryner
...
- Commit missing test data.
http://groups.google.com/group/airbag-dev/browse_thread/thread/cce30a84f6b2d728
--This line, and .those below, will be ignored--
A src/processor/testdata/minidump2.stackwalk.out
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@54 4c0a9323-5329-0410-9bdc-e9ce6186880e
2006-10-27 00:41:52 +00:00
mmentovai
c34850a202
minidump_stackwalk should use MinidumpProcessor ( #64 ). r=bryner
...
- minidump_stackwalk is now much more useful as a debugging tool and
even as a standalone tool.
- Reimplementation of minidump_stackwalk around MinidumpProcessor.
- minidump_stackwalk displays all pertinent information returned by
MinidumpProcessor in the ProcessState.
- New PathnameStripper::File static utility method to display only the
leaf file name in a pathname, cleaning up minidump_stackwalk's output.
- New SimpleSymbolSupplier class, which implements a simple
filesystem-based symbol supplier compatible with the layout used by
Microsoft Symbol Server and its client cache.
- minidump_stackwalk now accepts an optional second argument, a pathname
to use as a symbol directory for a SimpleSymbolSupplier.
- Updated test data to be compatible with SimpleSymbolSupplier, and added
test data for kernel32.pdb. Test data converted from CRLF line endings
to LF.
http://groups.google.com/group/airbag-dev/browse_thread/thread/cce30a84f6b2d728
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@53 4c0a9323-5329-0410-9bdc-e9ce6186880e
2006-10-27 00:40:56 +00:00
mmentovai
f944ba3fbb
MinidumpProcessor uses the wrong context for non-crash threads ( #62 ). r=bryner
...
http://groups.google.com/group/airbag-dev/browse_thread/thread/74743a397c52b7e2
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@52 4c0a9323-5329-0410-9bdc-e9ce6186880e
2006-10-26 23:09:02 +00:00
mmentovai
29401d2457
Support building with WIN32_LEAN_AND_MEAN ( #60 )
...
- All Windows code now builds with WIN32_LEAN_AND_MEAN by default.
- Header inclusion is adjusted as needed.
Remove use of UuidToString (#39 )
- Also breaks dependency on RpcStringFree and therefore rpcrt4.lib.
r=bryner
http://groups.google.com/group/airbag-dev/browse_thread/thread/30f844cfc7ccd37f
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@51 4c0a9323-5329-0410-9bdc-e9ce6186880e
2006-10-26 18:06:43 +00:00
mmentovai
aa57b8e3de
Add MDString to minidump_format.h ( #59 ). r=bryner
...
http://groups.google.com/group/airbag-dev/browse_thread/thread/599a47765598cf34
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@50 4c0a9323-5329-0410-9bdc-e9ce6186880e
2006-10-26 00:27:00 +00:00
mmentovai
80e98391dc
Fix minor style problems ( #58 ). r=bryner
...
http://groups.google.com/group/airbag-dev/browse_thread/thread/bbcecab979fa82bc
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@49 4c0a9323-5329-0410-9bdc-e9ce6186880e
2006-10-25 21:25:41 +00:00
mmentovai
0a7e6bf16c
minidump_dump does not print MDRawSystemInfo::processor_revision. No bug.
...
r=bryner
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@48 4c0a9323-5329-0410-9bdc-e9ce6186880e
2006-10-25 19:41:56 +00:00
mmentovai
e5468b8a49
MinidumpProcessor should process all threads ( #35 ). r=bryner
...
- MinidumpProcessor now processes all threads and returns a new ProcessState
object. (Interface change.)
- ProcessState contains a CallStack for each thread in the process, and
additional information about whether the process crashed, which thread
crashed, the reason for the crash, and identifying attributes for the
OS and CPU.
- MinidumpSystemInfo now contains a GetCPUVendor() method that returns the
vendor information from CPUID 0 on x86 processors ("GenuineIntel").
http://groups.google.com/group/airbag-dev/browse_thread/thread/16dd2c981e3361ba
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@47 4c0a9323-5329-0410-9bdc-e9ce6186880e
2006-10-24 19:31:21 +00:00
mmentovai
2466d8e993
Replace auto_ptr with scoped_ptr ( #56 ). r=bryner
...
http://groups.google.com/group/airbag-dev/browse_thread/thread/54c66451ed8e2835
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@46 4c0a9323-5329-0410-9bdc-e9ce6186880e
2006-10-23 20:25:42 +00:00
mmentovai
d119a921ea
Make stack_frame_info vector hold linked_ptrs instead of objects;
...
make Stackwalker::Walk create and return a CallStack instead of filling a
caller-supplied one (#54 ). r=bryner
Interface change: Stackwalker::Walk and MinidumpProcessor::Process now return
a new CallStack*.
http://groups.google.com/group/airbag-dev/browse_thread/thread/d2bad5d7c115c3fe
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@45 4c0a9323-5329-0410-9bdc-e9ce6186880e
2006-10-23 19:24:58 +00:00
bryner
7772046297
Update comments to reflect HTTPS support, r=mark.
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@44 4c0a9323-5329-0410-9bdc-e9ce6186880e
2006-10-23 17:50:59 +00:00
mmentovai
2fc823f579
Add PUBLIC support to SourceLineResolver (resolve function names in Windows
...
system libraries) (#53 )
StackFrame::function_base is not populated (#49 )
r=bryner
http://groups.google.com/group/airbag-dev/browse_thread/thread/a17d35348e7027bb
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@43 4c0a9323-5329-0410-9bdc-e9ce6186880e
2006-10-20 19:50:01 +00:00
mmentovai
246f406828
Handle frame pointer omission, ( #21 ), part 4 (final part!): FPO stackwalker.
...
r=bryner
- This change allows Airbag to properly walk win32 stacks produced by code
built with MSVC's frame pointer omission optimization (/Oy). This
optimization is enabled at /O1 and /O2.
- There too many interface and file format changes to list here.
http://groups.google.com/group/airbag-dev/browse_thread/thread/85ce85bfa8457ece
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@42 4c0a9323-5329-0410-9bdc-e9ce6186880e
2006-10-20 01:46:38 +00:00
mmentovai
5afd60b067
Improvements for Windows client/tool-side code. r=bryner
...
- Allow Windows sender to use https (#41 ).
- HTTPUpload not proxy-friendly (#46 ).
- Check http status codes (sort of #44 ).
- Allow symupload to work with versionless files (prints a warning, server
may still reject).
http://groups.google.com/group/airbag-dev/browse_thread/thread/5a12a72dffc5999c
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@41 4c0a9323-5329-0410-9bdc-e9ce6186880e
2006-10-19 21:48:51 +00:00
bryner
181f307ffe
Reduce calls to SymbolSupplier::GetSymbolFile() ( #48 ).
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@40 4c0a9323-5329-0410-9bdc-e9ce6186880e
2006-10-16 18:19:09 +00:00
bryner
8b1645d8cd
Implement a tool to upload symbols on Windows, given an exe or dll file with
...
debugging info. Refactor common code into HTTPUpload so that the multipart
POST request code can be shared with CrashReportSender. #47
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@39 4c0a9323-5329-0410-9bdc-e9ce6186880e
2006-10-16 17:27:03 +00:00
mmentovai
fc1c78e60e
Handle frame pointer omission ( #21 ), part 3: SourceLineResolver and PDBSourceLineWriter changes. r=bryner.
...
- PDBSourceLineWriter (dump_syms) outputs stack frame debugging information
- SourceLineResolver reads the new information and puts it into a
new StackFrameInfo structure, which is stored in a ContainedRangeMap.
FillSourceLineInfo passes the StackFrameInfo back to the caller.
- The base Stackwalker makes StackFrameInfo data available to subclasses
during stackwalking, but does not use this information directly itself.
Stackwalkers may access stack_frame_info_ for enhanced stackwalking
(this will be part 4).
- New test data for the updated dumped-symbol format
http://groups.google.com/group/airbag-dev/browse_thread/thread/735f191c9a1a1de4
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@38 4c0a9323-5329-0410-9bdc-e9ce6186880e
2006-09-28 21:09:37 +00:00
bryner
f140025664
Add static-CRT build configurations. Get rid of the largely redundant README,
...
moving the linkage comments to the corresponding headers.
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@37 4c0a9323-5329-0410-9bdc-e9ce6186880e
2006-09-28 19:35:08 +00:00
bryner
1217c1f898
Initial version of Windows exception handler and crash report sender classes
...
(#31 ). r=mmentovai.
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@36 4c0a9323-5329-0410-9bdc-e9ce6186880e
2006-09-27 01:00:32 +00:00
mmentovai
0dbedc973d
Better testing for Stackwalker ( #18 ). r=bryner
...
- Test StackwalkerX86 and StackwalkerPPC on the current process, if built
by a supported compiler (gcc) on a supported (walkable) CPU (x86, ppc).
- This test is not enabled by default because of certain optimizations
that interfere with it (stack frame reuse, frame pointer omission). See
the comments at the top of stackwalker_selftest.cc. To enable this
test in the standard "make check" suite, configure with --enable-selftest.
http://groups.google.com/group/airbag-dev/browse_thread/thread/2ca1c8e72c809bec
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@35 4c0a9323-5329-0410-9bdc-e9ce6186880e
2006-09-25 21:16:15 +00:00
mmentovai
960e5277ee
ppc stackwalker ( #30 ). r=bryner
...
- Implementation of PowerPC stackwalker. Tested using stackwalker_selftest
(#18 ).
- Hook up processor-side multi-CPU support in MinidumpProcessor and
minidump_stackwalk using the new Stackwalker::StackwalkerForCPU method.
http://groups.google.com/group/airbag-dev/browse_thread/thread/1c2fa7c5182a77a9
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@34 4c0a9323-5329-0410-9bdc-e9ce6186880e
2006-09-25 18:29:48 +00:00
mmentovai
3402cae5e5
Add ppc support to minidump reader ( #27 ). r=bryner.
...
- Uses new MDRawContextPPC structure from #25 .
- Interface change: (MinidumpContext).context() replaced with
GetContextCPU to determine CPU type and GetContextX86/GetContextPPC to
get CPU-specific context.
http://groups.google.com/group/airbag-dev/browse_thread/thread/f6c2e9cab2832b4c
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@33 4c0a9323-5329-0410-9bdc-e9ce6186880e
2006-09-22 01:10:25 +00:00
mmentovai
b934bb974a
Handle frame pointer omission ( #21 ), part 2: PostfixEvaluator. r=bryner.
...
- A postfix (reverse-Polish) notation expression evaluator that we can
feed stack-frame debug information into, crank, and get pointers to
the calling frame from.
http://groups.google.com/group/airbag-dev/browse_thread/thread/a1d6c5d1fd5fdcb9
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@32 4c0a9323-5329-0410-9bdc-e9ce6186880e
2006-09-22 00:42:23 +00:00
mmentovai
7daf246e4b
Relicense to BSD ( #29 ). r=bryner
...
http://groups.google.com/group/airbag-dev/browse_thread/thread/5f19f13fc172c4e0
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@31 4c0a9323-5329-0410-9bdc-e9ce6186880e
2006-09-20 21:16:16 +00:00
mmentovai
355c757b49
Improve documentation in minidump_format.h ( #28 ). r=bryner
...
http://groups.google.com/group/airbag-dev/browse_thread/thread/17840a32fb296638
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@30 4c0a9323-5329-0410-9bdc-e9ce6186880e
2006-09-20 17:36:21 +00:00
mmentovai
8c2a4def4e
Handle frame pointer omission ( #21 ), part 1: ContainedRangeMap. r=bryner.
...
- ContainedRangeMap is the data structure that will be used to store and
look up debugging information for frames by instruction address. The
debugging information includes a way to locate the calling frame in
the absence of a saved frame pointer.
- Restructure RangeMap into an -inl file to match ContainedRangeMap.
http://groups.google.com/group/airbag-dev/browse_thread/thread/c5823bfc1828ed42
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@29 4c0a9323-5329-0410-9bdc-e9ce6186880e
2006-09-20 16:20:15 +00:00
mmentovai
82a6c6037b
Add ppc types to minidump_format.h ( #25 ). r=waylonis
...
- New MDRawContextPPC struct, based on ppc_thread_state and others in
mach/ppc/_types.h.
- Add (defining where necessary) MDCPUArchitecture and MDOSPlatform enums
to support non-x86/win dumps. Add MD_CONTEXT_* definitions for non-x86
CPUs.
- Document a few more fields.
http://groups.google.com/group/airbag-dev/browse_thread/thread/963028fc01547851
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@28 4c0a9323-5329-0410-9bdc-e9ce6186880e
2006-09-20 01:14:59 +00:00
bryner
0170bea32f
Follow-up to #26 : get rid of supplier_data, it's not really needed since
...
the caller can implement their own supplier object. r=mmentovai.
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@27 4c0a9323-5329-0410-9bdc-e9ce6186880e
2006-09-20 00:00:12 +00:00
bryner
cce3492afc
Get rid of CrashReport, and rename CrashReportProcessor to MinidumpProcessor
...
(#26 ) r=mmentovai.
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@26 4c0a9323-5329-0410-9bdc-e9ce6186880e
2006-09-19 21:58:41 +00:00
mmentovai
d9fb68c3e0
Stylistic changes for RangeMap ( #24 ). r=bryner
...
http://groups.google.com/group/airbag-dev/browse_thread/thread/97c378bd175ab7c0
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@25 4c0a9323-5329-0410-9bdc-e9ce6186880e
2006-09-14 19:19:24 +00:00
mmentovai
683c86e6c5
Typo fixes. Patch by Ludovic Hirlimann.
...
http://groups.google.com/group/airbag-dev/browse_thread/thread/5d523eea06731806
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@24 4c0a9323-5329-0410-9bdc-e9ce6186880e
2006-09-14 16:31:38 +00:00
bryner
4c13853437
Add a client_id field to CrashReport ( #22 ) r=mmentovai.
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@23 4c0a9323-5329-0410-9bdc-e9ce6186880e
2006-09-11 22:50:25 +00:00
bryner
adf186cc76
Change report id to be a string ( #21 ) r=mmentovai.
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@22 4c0a9323-5329-0410-9bdc-e9ce6186880e
2006-09-11 17:35:19 +00:00
mmentovai
cb9fd5b773
Make SourceLineResolver use RangeMap ( #13 ). r=bryner
...
- Eliminate MemAddrMap from source_line_resolver.cc and adapt it to use
RangeMap, also used by minidump.cc.
- RangeMap operates on both a base address and a size, where MemAddrMap
only used a base address, so the dumped symbol file format is modified
to include size information. dump_syms produces these files and
SourceLineResolver consumes them.
- Provide updated test data conforming to the new dumped symbol format.
http://groups.google.com/group/airbag-dev/browse_thread/thread/e9403cf3ad6336a1
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@21 4c0a9323-5329-0410-9bdc-e9ce6186880e
2006-09-08 18:03:56 +00:00
mmentovai
6dd21d3baf
Change interface for providing files to Minidump ( #19 ). r=bryner
...
- Interface change: Minidump constructor now accepts a const string& path
argument instead of int fd. Minidump will open the file on first Read
and close it upon destruction.
- Adapt callers to new interface, no longer leaking file descriptors.
http://groups.google.com/group/airbag-dev/browse_thread/thread/ff24dbcde7db8ae3
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@20 4c0a9323-5329-0410-9bdc-e9ce6186880e
2006-09-08 16:41:17 +00:00
bryner
512511a895
addressing follow-up review comments from mark ( #17 )
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@19 4c0a9323-5329-0410-9bdc-e9ce6186880e
2006-09-08 04:05:46 +00:00
bryner
d5e66382d1
Add support to the StackWalker for resolving symbols, using a
...
caller-implemented SymbolSupplier object to get a symbol file.
Add a CrashReportProcessor object which provides a simple API for processing
a CrashReport struct, given a SymbolSupplier and a minidump file.
r=mmentovai (#17 ))
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@18 4c0a9323-5329-0410-9bdc-e9ce6186880e
2006-09-08 02:35:53 +00:00
bryner
39716226cf
Make SourceLineResolver fill a StackFrame rather than using its own struct ( #16 ), r=mmentovai.
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@17 4c0a9323-5329-0410-9bdc-e9ce6186880e
2006-09-07 17:26:17 +00:00
mmentovai
53d0f69d35
Conform to style guidelines.
...
- In class definitions, one-space indent for public/protected/private.
- Multi-line initializer format puts comma at end of line.
Also:
- Eliminate the long list of friends in Minidump by making swap() public.
(People who need to access unknown stream types directly will need
access to swap() too.)
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@16 4c0a9323-5329-0410-9bdc-e9ce6186880e
2006-09-07 15:56:38 +00:00
mmentovai
8d2f465c8a
minidump_dump test is timezone-dependent ( #15 ). r=bryner
...
- Use gmtime (UTC) instead of localtime for human-readable presentation of
(MDRawHeader).time_date_stamp.
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@15 4c0a9323-5329-0410-9bdc-e9ce6186880e
2006-09-07 15:17:40 +00:00
mmentovai
7f686d1953
Conform to style guidelines: methods overriding virtual methods should also be declared virtual.
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@14 4c0a9323-5329-0410-9bdc-e9ce6186880e
2006-09-06 21:37:46 +00:00
mmentovai
73badfc376
Initial implementation of x86 stackwalker ( #9 ), missing file. r=bryner
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@13 4c0a9323-5329-0410-9bdc-e9ce6186880e
2006-09-06 20:58:56 +00:00
mmentovai
213800d30c
Initial implementation of x86 stackwalker ( #9 ). r=bryner
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@12 4c0a9323-5329-0410-9bdc-e9ce6186880e
2006-09-06 19:28:46 +00:00
mmentovai
3261e8b6ea
Initial implementation of minidump reader ( #6 ). r=bryner
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@11 4c0a9323-5329-0410-9bdc-e9ce6186880e
2006-09-06 02:56:44 +00:00
bryner
07f8ef56ac
Change header paths and include guards to be relative to the "src" directory. r=mmentovai.
...
http://groups.google.com/group/airbag-dev/msg/cbe061dd563e9d17
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@10 4c0a9323-5329-0410-9bdc-e9ce6186880e
2006-09-05 19:42:57 +00:00
bryner
70e12562b8
Adding a CrashReport struct, r=mmentovai.
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@9 4c0a9323-5329-0410-9bdc-e9ce6186880e
2006-09-01 19:34:00 +00:00
mmentovai
425d256321
Make build system less annoying ( #8 ) r=bryner
...
- Place objects in the appropriate directories, instead of filling up
the root directory.
- Remove namespace macros, which made maintenance troublesome and which
created a dependency on config.h in public headers
- Skip useless Fortran checks at configure time
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@8 4c0a9323-5329-0410-9bdc-e9ce6186880e
2006-08-30 20:05:05 +00:00
bryner
cb91a2f879
Initial import, which includes the Windows client-side dump_syms tool, and
...
part of the server-side dump processor.
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@4 4c0a9323-5329-0410-9bdc-e9ce6186880e
2006-08-25 21:14:45 +00:00