yuzu/mbedtls
1
0
Fork 0
mirror of https://github.com/yuzu-emu/mbedtls.git synced 2024-10-19 08:31:27 +00:00
Code Issues Packages Projects Releases Wiki Activity
15162 commits 88 branches 205 tags 69 MiB
Commit graph

15162 commits

This branch
This branch
All branches
Author SHA1 Message Date
Gilles Peskine 392d1010dc Clarify some comments 
Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>
 2021-04-09 15:46:51 +02:00
Gilles Peskine bd43f67a9b Fix copypasta in test case description 
Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>
 2021-04-09 15:46:40 +02:00
Gilles Peskine ff6a32d79c Fix low-probability arithmetic error in ECC 
Fix the subtraction in fix_negative, which was incorrectly not looking
for a carry. This caused the result to be wrong when the least
significant limb of N was 0. Fix #4296.

The bug was introduced by d10e8fae9e
"Optimize fix_negative". Thanks to Philippe Antoine (catenacyber) for
reporting the bug which was found by his EC differential fuzzer.
Credit to OSS-Fuzz.

Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>
 2021-04-04 01:10:41 +02:00
Gilles Peskine 349b37273e Fix an incorrect comment about fix_negative 
We're subtracting multiples of 2^bits, not 2^(bits+32).

Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>
 2021-04-04 01:10:41 +02:00
Gilles Peskine 618be2ec41 Add unit tests for fix_negative 
Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>
 2021-04-04 01:10:41 +02:00
Gilles Peskine 80ba850e27 Create a header file for ECP internal functions 
This header file will contain declarations of functions that are not
part of the public ABI/API, and must not be called from other modules,
but can be called from unit tests.

Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>
 2021-04-04 01:10:41 +02:00
Gilles Peskine ca91ee4ed8 Unit test function for mbedtls_ecp_muladd 
Write a simple unit test for mbedtls_ecp_muladd().

Add just one pair of test cases. #2 fails since PR #3512. Thanks to
Philippe Antoine (catenacyber) for the test case, found by ecfuzzer.

Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>
 2021-04-04 01:10:41 +02:00
Gilles Peskine 80f56733b0 Fix and simplify sign handling in mbedtls_mpi_read_string 
Move the handling of the sign out of the base-specific loops. This
both simplifies the code, and corrects an edge case: the code in the
non-hexadecimal case depended on mbedtls_mpi_mul_int() preserving the
sign bit when multiplying a "negative zero" MPI by an integer, which
used to be the case but stopped with PR #2512.

Fix #4295. Thanks to Guido Vranken for analyzing the cause of the bug.
Credit to OSS-Fuzz.

Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>
 2021-04-04 01:10:07 +02:00
Gilles Peskine b13a26cd8c Add a few unit tests for mbedtls_mpi_read_string with leading zeros 
Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>
 2021-04-03 18:25:29 +02:00
Gilles Peskine d5200371ec
Merge pull request #3512 from gilles-peskine-arm/ecp-alloc-202007 
Reduce the number of allocations in ECP operations
 2021-04-02 00:08:35 +02:00
Ronald Cron 2af9641a7d
Merge pull request #4198 from maulik-arm/maulik-arm/fix-4162 
PSA Update return code for non-existing key in various key operations
 2021-04-01 13:27:31 +02:00
Maulik Patel f41be14269 Add Change log entry for bug fix. 
Signed-off-by: Maulik  Patel <Maulik.Patel@arm.com>
 2021-04-01 10:01:32 +01:00
Gilles Peskine e93095fe6b
Merge pull request #4175 from mpg/expand-doc-visibility 
Improve the visibility of some informations
 2021-03-31 11:48:02 +02:00
Gilles Peskine bf792e0a82
Merge pull request #3616 from militant-daos/bug_3175 
Fix premature fopen() call in mbedtls_entropy_write_seed_file
 2021-03-30 17:33:08 +02:00
Ronald Cron 17fbf5b3c4
Merge pull request #4237 from paul-elliott-arm/fix_printf_extra 
Fix printf missed issues
 2021-03-30 16:40:56 +02:00
Ronald Cron 48ffe622f9
Merge pull request #4215 from paul-elliott-arm/remove_fallthrough 
Remove deliberate fallthrough
 2021-03-30 16:40:24 +02:00
Ronald Cron 841ae226a4
Merge pull request #4019 from gilles-peskine-arm/etags-no-line-directive 
TAGS: Fix lookup in test/suites/!(test_suite_*).function
 2021-03-30 16:38:26 +02:00
paul-elliott-arm f08ec01e2b
Merge pull request #4014 from hanno-arm/mps_reader 
Add MPS reader component
 2021-03-29 16:26:02 +01:00
Hanno Becker ecb02fbbc5 Apply suggestions from code review 
Signed-off-by: Hanno Becker <hanno.becker@arm.com>
 2021-03-29 14:20:18 +01:00
Hanno Becker c0b1b252bc Update tests/suites/test_suite_mps.function 
Signed-off-by: Hanno Becker <hanno.becker@arm.com>
 2021-03-29 14:20:18 +01:00
Hanno Becker 5b3841d592 Fix uninitialized memory bug in MPS reader test 
Signed-off-by: Hanno Becker <hanno.becker@arm.com>
 2021-03-29 14:20:18 +01:00
Hanno Becker 3c6386cde5 Revert accidental gitignore change 
Signed-off-by: Hanno Becker <hanno.becker@arm.com>
 2021-03-29 14:20:18 +01:00
Hanno Becker 1b1e7eb611 Add unit test for integer overflow in mbedtls_mps_reader_reclaim() 
Signed-off-by: Hanno Becker <hanno.becker@arm.com>
 2021-03-29 14:20:18 +01:00
Hanno Becker d4d33a1b6b Remove unnecessary check before calling memcpy() 
This check was added earlier to avoid useless calls to `memcpy()`
with length `0` in the _frequent_ case where we're not accumulating.
By now, the whole code path has been moved to a branch which is only
executed if the reader is accumulating, and the only time this check
would be relevant is if we happen to feed an empty fragment to the
reader. In this case, the call to memcpy() could be removed, but
since this case is exceptional and the call to memcpy() is still
correct even for a length 0 copy, we remove the check for simplicity
of the code.

Signed-off-by: Hanno Becker <hanno.becker@arm.com>
 2021-03-29 14:20:18 +01:00
Hanno Becker 756abeb4e1 Fix typo in MPS test suite 
Signed-off-by: Hanno Becker <hanno.becker@arm.com>
 2021-03-29 14:20:18 +01:00
Hanno Becker d7fcbfa71e Test paused argument of MPS reader mbedtls_mps_reader_reclaim() 
Signed-off-by: Hanno Becker <hanno.becker@arm.com>
 2021-03-29 14:20:18 +01:00
Hanno Becker 032b352684 Improve naming of local variables in MPS reader implementation 
Signed-off-by: Hanno Becker <hanno.becker@arm.com>
 2021-03-29 14:20:18 +01:00
Hanno Becker 00931492da Fix spacing in MPS test suite 
Signed-off-by: Hanno Becker <hanno.becker@arm.com>
 2021-03-29 14:20:18 +01:00
Hanno Becker 7594c68049 Document status of MPS upstreaming 
Signed-off-by: Hanno Becker <hanno.becker@arm.com>
 2021-03-29 14:20:18 +01:00
Hanno Becker 43c8f8cf79 Put MPS under the umbrella of the TLS 1.3 experimental configuration 
Signed-off-by: Hanno Becker <hanno.becker@arm.com>
 2021-03-29 14:20:18 +01:00
Hanno Becker 61d7eedcb5 Fix Doxygen headers for MPS files 
Signed-off-by: Hanno Becker <hanno.becker@arm.com>
 2021-03-29 14:20:18 +01:00
Hanno Becker 2332f8f435 Rename static variable for MPS trace depth 
Signed-off-by: Hanno Becker <hanno.becker@arm.com>
 2021-03-29 14:20:18 +01:00
Hanno Becker 15da2fcf81 Remove unnecessary parameter in MPS reader unit test 
Signed-off-by: Hanno Becker <hanno.becker@arm.com>
 2021-03-29 14:20:18 +01:00
Hanno Becker 5047b56758 Improve wording in MPS unit tests 
Signed-off-by: Hanno Becker <hanno.becker@arm.com>
 2021-03-29 14:20:18 +01:00
Hanno Becker b17212a8bf Use size_t instead of int for index in buffer loops in MPS unit test 
Signed-off-by: Hanno Becker <hanno.becker@arm.com>
 2021-03-29 14:20:18 +01:00
Hanno Becker 8a04b10ed8 Fix include path for MPS reader header in MPS test suite 
Signed-off-by: Hanno Becker <hanno.becker@arm.com>
 2021-03-29 14:20:18 +01:00
Hanno Becker 77e4f485e1 Move illustration of (un)supported cases in MPS reader documentation 
Signed-off-by: Hanno Becker <hanno.becker@arm.com>
 2021-03-29 14:20:18 +01:00
Hanno Becker 97c8e930e2 Fix diagram in documentation of MPS reader 
Signed-off-by: Hanno Becker <hanno.becker@arm.com>
 2021-03-29 14:20:18 +01:00
Hanno Becker 1682a8b6fe Don't use abbreviated names for local variables in MPS reader 
Signed-off-by: Hanno Becker <hanno.becker@arm.com>
 2021-03-29 14:20:18 +01:00
Hanno Becker b9c086adc5 Use int pointer for paused param in mbedtls_mps_reader_reclaim() 
Signed-off-by: Hanno Becker <hanno.becker@arm.com>
 2021-03-29 14:20:18 +01:00
Hanno Becker fea81b3997 Improve and fix wording in MPS reader documentation 
Signed-off-by: Hanno Becker <hanno.becker@arm.com>
 2021-03-29 14:20:18 +01:00
Hanno Becker f1cfa319c4 Fix typos in documentation of MBEDTLS_ERR_MPS_READER_NEED_MORE 
Signed-off-by: Hanno Becker <hanno.becker@arm.com>
 2021-03-29 14:20:18 +01:00
Hanno Becker d913e2e982 Remove duplicate definition of MBEDTLS_MPS_ERR_BASE 
Signed-off-by: Hanno Becker <hanno.becker@arm.com>
 2021-03-29 14:20:18 +01:00
Hanno Becker 4a079c5be7 Fix documentation for mbedtls_mps_[stored_]size_t 
Signed-off-by: Hanno Becker <hanno.becker@arm.com>
 2021-03-29 14:20:18 +01:00
Hanno Becker 46101c76f9 Improve wording of documentation of mbedtls_mps_size_t 
Signed-off-by: Hanno Becker <hanno.becker@arm.com>
 2021-03-29 14:20:18 +01:00
Hanno Becker 6e3484e123 Clarify documentation of MBEDTLS_MPS_STATE_VALIDATION 
Signed-off-by: Hanno Becker <hanno.becker@arm.com>
 2021-03-29 14:20:18 +01:00
Hanno Becker 53314aade1 Adjust spacing for MPS reader entries in library/Makefile 
Existing entries use combination of tabs and spaces, for whatever reason.

Signed-off-by: Hanno Becker <hanno.becker@arm.com>
 2021-03-29 14:20:18 +01:00
Hanno Becker 3d0db81690 Fix typo in MPS reader documentation 
Signed-off-by: Hanno Becker <hanno.becker@arm.com>
 2021-03-29 14:20:18 +01:00
Hanno Becker 8fc107c9fb Clarify wording in MPS reader documentation 
Signed-off-by: Hanno Becker <hanno.becker@arm.com>
 2021-03-29 14:20:18 +01:00
Hanno Becker a408c1719c Clarify wording in MPS reader documentation 
Signed-off-by: Hanno Becker <hanno.becker@arm.com>
 2021-03-29 14:20:18 +01:00