yuzu/unicorn
1
0
Fork 0
mirror of https://github.com/yuzu-emu/unicorn.git synced 2024-12-23 00:35:34 +00:00
Code Issues Packages Projects Releases Wiki Activity

target/arm: Make M-profile VTOR loads on reset handle memory aliasing

Browse source 
For Arm M-profile CPUs, on reset the CPU must load its initial PC and
SP from a vector table in guest memory. Because we can't guarantee
reset ordering, we have to handle the possibility that the ROM blob
loader's reset function has not yet run when the CPU resets, in which
case the data in an ELF file specified by the user won't be in guest
memory to be read yet.

We work around the reset ordering problem by checking whether the ROM
blob loader has any data for the address where the vector table is,
using rom_ptr(). Unfortunately this does not handle the possibility
of memory aliasing. For many M-profile boards, memory can be
accessed via multiple possible physical addresses; if the board has
the vector table at address X but the user's ELF file loads data via
a different address Y which is an alias to the same underlying guest
RAM then rom_ptr() will not find it.

Use the new rom_ptr_for_as() function, which deals with memory
aliasing when locating a relevant ROM blob.

Backports 75ce72b785a7c9fcb9af2779854142a34825da59
This commit is contained in:
Peter Maydell 2021-03-30 15:24:15 -04:00 committed by Lioncash
parent 83116e69b5
commit 250e263ae3
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
qemu/target/arm/cpu.c
View file

@ -322,7 +322,7 @@ static void arm_cpu_reset(CPUState *s)
/* Load the initial SP and PC from offset 0 and 4 in the vector table */ /* Load the initial SP and PC from offset 0 and 4 in the vector table */
vecbase = env->v7m.vecbase[env->v7m.secure]; vecbase = env->v7m.vecbase[env->v7m.secure];
rom = rom_ptr(vecbase); rom = rom_ptr_for_as(s->as, vecbase, 8);
if (rom) { if (rom) {
/* Address zero is covered by ROM which hasn't yet been /* Address zero is covered by ROM which hasn't yet been
* copied into physical memory. * copied into physical memory.