mirror of
https://github.com/yuzu-emu/unicorn.git
synced 2024-12-22 19:05:32 +00:00
320b59ddb9
clang's C11 atomic_fetch_*() functions only take a C11 atomic type
pointer argument. QEMU uses direct types (int, etc) and this causes a
compiler error when a QEMU code calls these functions in a source file
that also included <stdatomic.h> via a system header file:
$ CC=clang CXX=clang++ ./configure ... && make
../util/async.c:79:17: error: address argument to atomic operation must be a pointer to _Atomic type ('unsigned int *' invalid)
Avoid using atomic_*() names in QEMU's atomic.h since that namespace is
used by <stdatomic.h>. Prefix QEMU's APIs with 'q' so that atomic.h
and <stdatomic.h> can co-exist. I checked /usr/include on my machine and
searched GitHub for existing "qatomic_" users but there seem to be none.
This patch was generated using:
$ git grep -h -o '\<atomic\(64\)\?_[a-z0-9_]\+' include/qemu/atomic.h | \
sort -u >/tmp/changed_identifiers
$ for identifier in $(</tmp/changed_identifiers); do
sed -i "s%\<$identifier\>%q$identifier%g" \
$(git grep -I -l "\<$identifier\>")
done
I manually fixed line-wrap issues and misaligned rST tables.
Backports d73415a315471ac0b127ed3fad45c8ec5d711de1
|
||
|---|---|---|
| .. | ||
| atomic.h | ||
| atomic128.h | ||
| bitmap.h | ||
| bitops.h | ||
| bswap.h | ||
| compiler.h | ||
| cpuid.h | ||
| crc32.h | ||
| crc32c.h | ||
| cutils.h | ||
| fprintf-fn.h | ||
| host-utils.h | ||
| int128.h | ||
| log.h | ||
| mmap-alloc.h | ||
| module.h | ||
| osdep.h | ||
| queue.h | ||
| range.h | ||
| sys_membarrier.h | ||
| thread-posix.h | ||
| thread-win32.h | ||
| thread.h | ||
| timer.h | ||
| typedefs.h | ||
| units.h | ||
| xxhash.h | ||