unicorn/qemu
David Greenaway 0c1c359b5c target/i386: Fix decoding of certain BMI instructions
This patch fixes a translation bug for a subset of x86 BMI instructions
such as the following:

c4 e2 f9 f7 c0 shlxq %rax, %rax, %rax

Currently, these incorrectly generate an undefined instruction exception
when SSE is disabled via CR4, while instructions like "shrxq" work fine.

The problem appears to be related to BMI instructions encoded using VEX
and with a mandatory prefix of "0x66" (data). Instructions with this
data prefix (such as shlxq) are currently rejected. Instructions with
other mandatory prefixes (such as shrxq) translate as expected.

This patch removes the incorrect check in "gen_sse" that causes the
exception to be generated. For the non-BMI cases, the check is
redundant: prefixes are already checked at line 3696.

Buglink: https://bugs.launchpad.net/qemu/+bug/1748296

Backports 51909241d26fe6fe18a08def93ccc8273f61a8b3
2021-03-04 18:08:47 -05:00
..
accel cpu: move cc->do_interrupt to tcg_ops 2021-03-04 17:10:14 -05:00
crypto crypto: Clean up includes 2018-02-19 00:47:40 -05:00
default-configs target/riscv: Initial introduction of the RISC-V target 2019-03-08 21:46:10 -05:00
docs docs/devel/memory.txt: Document _with_attrs accessors 2018-10-04 04:46:26 -04:00
fpu softfloat: Define misc operations for bfloat16 2021-02-27 16:41:46 -05:00
hw target/arm: Set instance_align on CPUARM TypeInfo 2021-03-01 18:58:44 -05:00
include cpu: move debug_check_watchpoint to tcg_ops 2021-03-04 17:30:20 -05:00
qapi qapi: Rewrite string-input-visitor's integer and list parsing 2018-12-18 04:57:25 -05:00
qobject qstring: Move qstring_from_substr()'s @end one to the right 2018-08-02 21:24:19 -04:00
qom cpu: move debug_check_watchpoint to tcg_ops 2021-03-04 17:30:20 -05:00
scripts decodetree: Open files with encoding='utf-8' 2021-03-04 13:34:08 -05:00
target target/i386: Fix decoding of certain BMI instructions 2021-03-04 18:08:47 -05:00
tcg tcg: Remove TCG_TARGET_CON_SET_H 2021-03-04 16:29:16 -05:00
util util/cutils: Turn FIXME comment into QEMU_BUILD_BUG_ON() 2020-01-14 08:04:30 -05:00
aarch64.h qemu/compiler: Split out qemu_build_not_reached_always 2021-03-04 15:23:27 -05:00
aarch64eb.h qemu/compiler: Split out qemu_build_not_reached_always 2021-03-04 15:23:27 -05:00
accel.c target/arm: Set instance_align on CPUARM TypeInfo 2021-03-01 18:58:44 -05:00
arm.h qemu/compiler: Split out qemu_build_not_reached_always 2021-03-04 15:23:27 -05:00
armeb.h qemu/compiler: Split out qemu_build_not_reached_always 2021-03-04 15:23:27 -05:00
CODING_STYLE.rst docs: split the CODING_STYLE doc into distinct groups 2019-11-28 02:54:44 -05:00
configure configure: Support -static-pie if requested 2020-04-30 07:09:34 -04:00
COPYING
COPYING.LIB
cpus.c Include qapi/error.h exactly where needed 2018-03-07 12:26:38 -05:00
exec.c cpu: move debug_check_watchpoint to tcg_ops 2021-03-04 17:30:20 -05:00
gen_all_header.sh
glib_compat.c tcg: Introduce TYPE_CONST temporaries 2021-03-03 21:29:40 -05:00
header_gen.py qemu/compiler: Split out qemu_build_not_reached_always 2021-03-04 15:23:27 -05:00
ioport.c hw: remove pio_addr_t 2018-02-24 02:43:16 -05:00
LICENSE
m68k.h qemu/compiler: Split out qemu_build_not_reached_always 2021-03-04 15:23:27 -05:00
Makefile Makefile: Rename targets for make recursion 2019-08-08 17:26:49 -04:00
Makefile.objs qapi: Move qapi-schema.json to qapi/, rename generated files 2018-03-09 11:35:11 -05:00
Makefile.target configure: Remove old -fno-gcse workaround for GCC 4.6.x and 4.7.[012] 2018-12-18 03:52:36 -05:00
memory.c target/arm: Set instance_align on CPUARM TypeInfo 2021-03-01 18:58:44 -05:00
memory_ldst.inc.c memory: Single byte swap along the I/O path 2020-01-07 19:12:04 -05:00
memory_mapping.c include/qemu/osdep.h: Don't include qapi/error.h 2018-02-21 23:08:18 -05:00
mips.h qemu/compiler: Split out qemu_build_not_reached_always 2021-03-04 15:23:27 -05:00
mips64.h qemu/compiler: Split out qemu_build_not_reached_always 2021-03-04 15:23:27 -05:00
mips64el.h qemu/compiler: Split out qemu_build_not_reached_always 2021-03-04 15:23:27 -05:00
mipsel.h qemu/compiler: Split out qemu_build_not_reached_always 2021-03-04 15:23:27 -05:00
powerpc.h qemu/compiler: Split out qemu_build_not_reached_always 2021-03-04 15:23:27 -05:00
qemu-timer.c timer/cpus: fix some typos and update some comments 2018-02-25 23:21:57 -05:00
riscv32.h qemu/compiler: Split out qemu_build_not_reached_always 2021-03-04 15:23:27 -05:00
riscv64.h qemu/compiler: Split out qemu_build_not_reached_always 2021-03-04 15:23:27 -05:00
rules.mak build-sys: silence make by default or V=0 2018-03-06 08:58:03 -05:00
sparc.h qemu/compiler: Split out qemu_build_not_reached_always 2021-03-04 15:23:27 -05:00
sparc64.h qemu/compiler: Split out qemu_build_not_reached_always 2021-03-04 15:23:27 -05:00
unicorn_common.h tcg: Move sorted_args into TCGArgConstraint.sort_index 2021-03-01 19:33:45 -05:00
VERSION Open 6.0 development tree 2021-03-02 13:39:05 -05:00
vl.c Use cpu_create(type) instead of cpu_init(cpu_model) 2018-03-20 14:20:30 -04:00
vl.h
x86_64.h qemu/compiler: Split out qemu_build_not_reached_always 2021-03-04 15:23:27 -05:00