Luc Michel 1ae9d988c6 target/arm: fix smc incorrectly trapping to EL3 when secure is off ... This commit fixes a case where the CPU would try to go to EL3 when executing an smc instruction, even though ARM_FEATURE_EL3 is false. This case is raised when the PSCI conduit is set to smc, but the smc instruction does not lead to a valid PSCI call. QEMU crashes with an assertion failure latter on because of incoherent mmu_idx. This commit refactors the pre_smc helper by enumerating all the possible way of handling an scm instruction, and covering the previously missing case leading to the crash. The following minimal test would crash before this commit: .global _start .text _start: ldr x0, =0xdeadbeef ; invalid PSCI call smc #0 run with the following command line: aarch64-linux-gnu-gcc -nostdinc -nostdlib -Wl,-Ttext=40000000 \ -o test test.s qemu-system-aarch64 -M virt,virtualization=on,secure=off \ -cpu cortex-a57 -kernel test Backports commit 7760da729ac88f112f98f36395ac3b55fc9e4211 from qemu		2018-11-23 18:57:23 -05:00
..
arm	target/arm: fix smc incorrectly trapping to EL3 when secure is off	2018-11-23 18:57:23 -05:00
i386	target/i386: Clear RF on SYSCALL instruction	2018-11-11 08:41:09 -05:00
m68k	m68k: Silence compiler warnings	2018-11-16 21:23:55 -05:00
mips	target/mips: Disable R5900 support	2018-11-23 18:55:12 -05:00
sparc	Sparc increase ttl number	2018-10-06 04:55:52 -04:00